Properly handle server in error status

Author: kayrus

pkg/server.go

@@ -48,6 +48,10 @@ var serverNormalStates = []string{
 	"stopped",
 }
 
+var serverErrorStates = []string{
+	"error",
+}
+
 var serverNormalStatuses = []string{
 	"ACTIVE",
 	"SHUTOFF",
@@ -62,6 +66,10 @@ var serverWaitStatuses = []string{
 	"BUILD",
 }
 
+var serverErrorStatuses = []string{
+	"ERROR",
+}
+
 func createServerSpeed(server *serverExtended) {
 	t := server.Updated.Sub(server.Created)
 	log.Printf("Time to create a server: %s", t)
@@ -79,6 +87,10 @@ func waitForServer(client *gophercloud.ServiceClient, id string, secs float64) (
 		// this is needed, because if new data contains a "null", the struct will contain an old data, e.g. `"OS-EXT-STS:task_state": null`
 		server = tmp
 
+		if isSliceContainsStr(serverErrorStates, server.VmState) || isSliceContainsStr(serverErrorStatuses, server.Status) {
+			return false, fmt.Errorf("server status: %s (%s)", server.Status, joinSkipEmpty(", ", server.VmState, server.TaskState))
+		}
+
 		if !isSliceContainsStr(serverNormalStates, server.VmState) || server.TaskState != "" {
 			log.Printf("Server status: %s (%s)", server.Status, joinSkipEmpty(", ", server.VmState, server.TaskState))
 			return false, nil