Force OpenStack client re-auth before long running actions

In order to avoid internal auth issues between OpenStack services

Author: kayrus

pkg/backup.go

@@ -452,6 +452,8 @@ func uploadBackup(srcImgClient, srcObjClient, dstObjClient, dstVolClient *gopher
 }
 
 func backupToVolume(dstVolClient *gophercloud.ServiceClient, backupObj *backups.Backup, volumeName, volumeType, az string) (*volumes.Volume, error) {
+	reauthClient(dstVolClient, "backupToVolume")
+
 	// create a volume from a backup
 	dstVolClient.Microversion = "3.47"
 	volOpts := volumes.CreateOpts{

pkg/image.go

@@ -283,6 +283,9 @@ func migrateImage(srcImageClient, dstImageClient, srcObjectClient, dstObjectClie
 		}
 	}()
 
+	reauthClient(srcImageClient, "migrateImage")
+	reauthClient(dstImageClient, "migrateImage")
+
 	if imageWebDownload {
 		if !isSliceContainsStr(dstImg.OpenStackImageImportMethods, string(imageimport.WebDownloadMethod)) {
 			return nil, fmt.Errorf("the %q import method is not supported, supported import methods: %q", imageimport.WebDownloadMethod, dstImg.OpenStackImageImportMethods)

pkg/utils.go

@@ -172,6 +172,15 @@ func newOpenStackClient(loc Location) (*gophercloud.ProviderClient, error) {
 	return provider, nil
 }
 
+func reauthClient(client *gophercloud.ServiceClient, funcName string) {
+	// reauth the client before the long running action to avoid openstack internal auth issues
+	if client.ProviderClient.ReauthFunc != nil {
+		if err := client.ProviderClient.Reauthenticate(client.ProviderClient.TokenID); err != nil {
+			log.Printf("Failed to re-authenticate the provider client in the %s func: %v", err, funcName)
+		}
+	}
+}
+
 func newGlanceV2Client(provider *gophercloud.ProviderClient, region string) (*gophercloud.ServiceClient, error) {
 	return openstack.NewImageServiceV2(provider, gophercloud.EndpointOpts{
 		Region: region,

pkg/volume.go

@@ -139,6 +139,8 @@ func cloneVolume(srcVolumeClient, srcObjectClient *gophercloud.ServiceClient, sr
 		VolumeType:  srcVolume.VolumeType,
 	}
 
+	reauthClient(srcVolumeClient, "cloneVolume")
+
 	if cloneViaSnapshot {
 		// clone via snapshot using cinder storage, because it was explicitly set
 		log.Printf("Cloning a %q volume using volume snapshot", srcVolume.ID)
@@ -216,6 +218,8 @@ func cloneVolume(srcVolumeClient, srcObjectClient *gophercloud.ServiceClient, sr
 		}
 	}
 
+	reauthClient(srcVolumeClient, "cloneVolume")
+
 	var newVolume *volumes.Volume
 	var err error
 	newVolume, err = volumes.Create(srcVolumeClient, volOpts).Extract()
@@ -276,6 +280,8 @@ func volumeToImage(srcImageClient, srcVolumeClient, srcObjectClient *gophercloud
 		createSrcImage.DiskFormat = v
 	}
 
+	reauthClient(srcVolumeClient, "volumeToImage")
+
 	srcVolumeClient.Microversion = "3.1" // required to set the image visibility
 	var srcVolumeImage volumeactions.VolumeImage
 	srcVolumeImage, err := volumeactions.UploadImage(srcVolumeClient, srcVolume.ID, createSrcImage).Extract()
@@ -405,6 +411,8 @@ func migrateVolume(srcImageClient, srcVolumeClient, srcObjectClient, dstImageCli
 }
 
 func imageToVolume(imgToVolClient, imgDstClient *gophercloud.ServiceClient, imageID, volumeName, volumeDescription, volumeType, az string, volumeSize int, srcVolume *volumes.Volume) (*volumes.Volume, error) {
+	reauthClient(imgToVolClient, "imageToVolume")
+
 	dstVolumeCreateOpts := volumes.CreateOpts{
 		Size:             volumeSize,
 		Name:             volumeName,