add source parameter to rsyslog::snippet, fixes #300

Author: saz

REFERENCE.md

@@ -1111,6 +1111,7 @@ The following parameters are available in the `rsyslog::snippet` defined type:
 * [`content`](#-rsyslog--snippet--content)
 * [`ensure`](#-rsyslog--snippet--ensure)
 * [`file_mode`](#-rsyslog--snippet--file_mode)
+* [`source`](#-rsyslog--snippet--source)
 
 ##### <a name="-rsyslog--snippet--content"></a>`content`
 
@@ -1136,3 +1137,11 @@ The mode of the file snippet
 
 Default value: `undef`
 
+##### <a name="-rsyslog--snippet--source"></a>`source`
+
+Data type: `Optional[String[1]]`
+
+
+
+Default value: `undef`
+

manifests/snippet.pp

@@ -16,10 +16,15 @@
 #   The mode of the file snippet
 #
 define rsyslog::snippet (
-  Optional[String[1]] $content = undef,
   Enum['present', 'file', 'absent'] $ensure = 'present',
+  Optional[String[1]] $content = undef,
+  Optional[String[1]] $source = undef,
   Optional[Stdlib::Filemode] $file_mode = undef,
 ) {
+  if $content and $source {
+    fail("rsyslog::snippet[${title}]: Can't set 'content' and 'source' at the same time")
+  }
+
   if $file_mode {
     $file_mode_real = $file_mode
   } else {
@@ -39,6 +44,7 @@
     group   => $rsyslog::run_group,
     mode    => $file_mode_real,
     content => $content_real,
+    source  => $source,
     notify  => Service[$rsyslog::service_name],
     require => File[$rsyslog::rsyslog_d],
   }

spec/defines/rsyslog_snippet_spec.rb

@@ -31,6 +31,35 @@
           is_expected.to contain_file("#{rsyslog_d}/rsyslog-snippet-basic.conf").with_content("# This file is managed by Puppet, changes may be overwritten\nRandom Content\n")
         end
       end
+
+      context 'source provided' do
+        let(:title) { 'rsyslog-snippet-basic' }
+        let(:params) { { 'source' => 'puppet:///files/rsyslog.snippet' } }
+
+        it 'compiles' do
+          is_expected.to contain_file("#{rsyslog_d}/rsyslog-snippet-basic.conf").with_source('puppet:///files/rsyslog.snippet')
+        end
+      end
+
+      context 'content and source provided' do
+        let(:title) { 'rsyslog-snippet-basic' }
+        let(:params) { {
+          'source'  => 'puppet:///files/rsyslog.snippet',
+          'content' => 'Random Content'
+        } }
+
+        it 'compiles' do
+          is_expected.to compile.and_raise_error(/Can't set 'content' and 'source' at the same time/)
+        end
+      end
+
+      context 'content and source not provided' do
+        let(:title) { 'rsyslog-snippet-basic' }
+
+        it 'compiles' do
+          is_expected.to contain_file("#{rsyslog_d}/rsyslog-snippet-basic.conf").with_source(nil).with_content(nil)
+        end
+      end
     end
   end
 end