Skip to content
This repository was archived by the owner on Oct 8, 2021. It is now read-only.

Commit f1e7fd6

Browse files
simonschoellysbromberger
authored andcommitted
Small fixes for 1.0 (#52)
* small fixes for 1.0 * appveyor needs platform * some tests assumed that Int==Int64
1 parent 371ddda commit f1e7fd6

File tree

3 files changed

+25
-28
lines changed

3 files changed

+25
-28
lines changed

appveyor.yml

Lines changed: 22 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,18 @@
11
environment:
22
matrix:
3-
- JULIA_URL: "https://julialang-s3.julialang.org/bin/winnt/x86/0.6/julia-0.6-latest-win32.exe"
4-
- JULIA_URL: "https://julialang-s3.julialang.org/bin/winnt/x64/0.6/julia-0.6-latest-win64.exe"
5-
- JULIA_URL: "https://julialangnightlies-s3.julialang.org/bin/winnt/x86/julia-latest-win32.exe"
6-
- JULIA_URL: "https://julialangnightlies-s3.julialang.org/bin/winnt/x64/julia-latest-win64.exe"
3+
# - julia_version: 0.7
4+
- julia_version: 1
5+
- julia_version: nightly
76

8-
## uncomment the following lines to allow failures on nightly julia
9-
## (tests will run but not make your overall status red)
7+
platform:
8+
- x86 # 32-bit
9+
- x64 # 64-bit
10+
11+
# # Uncomment the following lines to allow failures on nightly julia
12+
# # (tests will run but not make your overall status red)
1013
#matrix:
11-
# allow_failures:
12-
# - JULIA_URL: "https://julialangnightlies-s3.julialang.org/bin/winnt/x86/julia-latest-win32.exe"
13-
# - JULIA_URL: "https://julialangnightlies-s3.julialang.org/bin/winnt/x64/julia-latest-win64.exe"
14+
# allow_failures:
15+
# - julia_version: nightly
1416

1517
branches:
1618
only:
@@ -23,25 +25,21 @@ notifications:
2325
on_build_failure: false
2426
on_build_status_changed: false
2527

28+
2629
install:
27-
- ps: "[System.Net.ServicePointManager]::SecurityProtocol = [System.Net.SecurityProtocolType]::Tls12"
28-
# If there's a newer build queued for the same PR, cancel this one
29-
- ps: if ($env:APPVEYOR_PULL_REQUEST_NUMBER -and $env:APPVEYOR_BUILD_NUMBER -ne ((Invoke-RestMethod `
30-
https://ci.appveyor.com/api/projects/$env:APPVEYOR_ACCOUNT_NAME/$env:APPVEYOR_PROJECT_SLUG/history?recordsNumber=50).builds | `
31-
Where-Object pullRequestId -eq $env:APPVEYOR_PULL_REQUEST_NUMBER)[0].buildNumber) { `
32-
throw "There are newer queued builds for this pull request, failing early." }
33-
# Download most recent Julia Windows binary
34-
- ps: (new-object net.webclient).DownloadFile(
35-
$env:JULIA_URL,
36-
"C:\projects\julia-binary.exe")
37-
# Run installer silently, output to C:\projects\julia
38-
- C:\projects\julia-binary.exe /S /D=C:\projects\julia
30+
- ps: iex ((new-object net.webclient).DownloadString("https://raw.githubusercontent.com/JuliaCI/Appveyor.jl/version-1/bin/install.ps1"))
3931

4032
build_script:
4133
# Need to convert from shallow to complete for Pkg.clone to work
4234
- IF EXIST .git\shallow (git fetch --unshallow)
43-
- C:\projects\julia\bin\julia -e "versioninfo();
44-
Pkg.clone(pwd(), \"MetaGraphs\"); Pkg.build(\"MetaGraphs\")"
35+
- C:\julia\bin\julia -e "using InteractiveUtils, Pkg; versioninfo();
36+
Pkg.clone(pwd(), \"MetaGraphs\"); Pkg.build(\"MetaGraphs\")"
4537

4638
test_script:
47-
- C:\projects\julia\bin\julia -e "Pkg.test(\"MetaGraphs\")"
39+
- C:\julia\bin\julia -e "using Pkg; Pkg.test(\"MetaGraphs\")"
40+
41+
# # Uncomment to support code coverage upload. Should only be enabled for packages
42+
# # which would have coverage gaps without running on Windows
43+
# on_success:
44+
# - echo "%JL_CODECOV_SCRIPT%"
45+
# - C:\julia\bin\julia -e "%JL_CODECOV_SCRIPT%"

src/MetaGraphs.jl

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,7 @@ using JLD2
55
import Base:
66
eltype, show, ==, Pair,
77
Tuple, copy, length, size,
8-
start, next, done, issubset,
9-
zero, getindex
8+
issubset, zero, getindex
109
import Random:
1110
randstring, seed!
1211

test/metagraphs.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ import Base64:
165165
mg = MetaGraph(CompleteGraph(3), 3.0)
166166
@test enumerate_paths(dijkstra_shortest_paths(mg, 1), 3) == [1, 3]
167167
@test typeof(set_prop!(mg, 1, 2, :weight, 0.2)) == Dict{Symbol,Float64}
168-
@test typeof(set_prop!(mg, 2, 3, :weight, 1)) == Dict{Symbol,Int64}
168+
@test typeof(set_prop!(mg, 2, 3, :weight, 1)) == Dict{Symbol,Int}
169169
@test enumerate_paths(dijkstra_shortest_paths(mg, 1), 3) == [1, 2, 3]
170170

171171
@test typeof(set_prop!(mg, 1, :color, "blue")) == Dict{Symbol,String}
@@ -226,7 +226,7 @@ import Base64:
226226
add_edge!(mg, 1, 3)
227227
@test enumerate_paths(dijkstra_shortest_paths(mg, 1), 3) == [1, 3]
228228
@test typeof(set_prop!(mg, 1, 2, :weight, 0.2)) == Dict{Symbol,Float64}
229-
@test typeof(set_prop!(mg, 2, 3, :weight, 1)) == Dict{Symbol,Int64}
229+
@test typeof(set_prop!(mg, 2, 3, :weight, 1)) == Dict{Symbol,Int}
230230
@test enumerate_paths(dijkstra_shortest_paths(mg, 1), 3) == [1, 2, 3]
231231

232232
@test typeof(set_prop!(mg, 1, :color, "blue")) == Dict{Symbol,String}

0 commit comments

Comments
 (0)