Merge remote-tracking branch 'origin/bugfix/ARSN-494-cloudserverCrashPuttingReplicationConfiguration' into w/7.70/bugfix/ARSN-494-cloudserverCrashPuttingReplicationConfiguration

Author: jonathan-gramain

lib/models/ReplicationConfiguration.ts

@@ -195,8 +195,7 @@ export default class ReplicationConfiguration {
         const invalidRole = rolesArr.find((r) => !this._isValidRoleARN(r));
         if (invalidRole !== undefined) {
             return errorInstances.InvalidArgument.customizeDescription(
-                'Invalid Role specified in replication configuration: ' +
-                    `'${invalidRole}'`
+                `Invalid Role specified in replication configuration: '${invalidRole}'`
             );
         }
         this._role = role;
@@ -269,8 +268,7 @@ export default class ReplicationConfiguration {
         }
         if (prefix.length > 1024) {
             return errorInstances.InvalidArgument.customizeDescription(
-                'Rule prefix ' +
-                    'cannot be longer than maximum allowed key length of 1024'
+                'Rule prefix cannot be longer than maximum allowed key length of 1024'
             );
         }
         // Each Prefix in a list of rules must not overlap. For example, two
@@ -280,7 +278,7 @@ export default class ReplicationConfiguration {
             const used = this._configPrefixes[i];
             if (prefix.startsWith(used) || used.startsWith(prefix)) {
                 return errorInstances.InvalidRequest.customizeDescription(
-                    'Found ' + `overlapping prefixes '${used}' and '${prefix}'`
+                    `Found overlapping prefixes '${used}' and '${prefix}'`
                 );
             }
         }
@@ -296,13 +294,13 @@ export default class ReplicationConfiguration {
         const id = rule.ID && rule.ID[0];
         if (id && id.length > RULE_ID_LIMIT) {
             return errorInstances.InvalidArgument.customizeDescription(
-                'Rule Id cannot be greater than 255'
+                'Rule ID length cannot be greater than 255'
             );
         }
         // Each ID in a list of rules must be unique.
         if (id && this._configIDs.includes(id)) {
             return errorInstances.InvalidRequest.customizeDescription(
-                'Rule Id must be unique'
+                'Duplicate Rule ID'
             );
         }
         if (id !== undefined) {
@@ -324,14 +322,13 @@ export default class ReplicationConfiguration {
             replicationEndpoints[0];
         // StorageClass is optional.
         if (destination.StorageClass === undefined) {
-            this._hasScalityDestination = defaultEndpoint.type === undefined;
+            this._hasScalityDestination = (defaultEndpoint && defaultEndpoint.type === undefined);
             return undefined;
         }
         const storageClasses = destination.StorageClass[0].split(',');
         const isValidStorageClass = storageClasses.every((storageClass) => {
             if (validStorageClasses.includes(storageClass)) {
-                this._hasScalityDestination =
-                    defaultEndpoint.type === undefined;
+                this._hasScalityDestination = (defaultEndpoint && defaultEndpoint.type === undefined);
                 return true;
             }
             const endpoint = replicationEndpoints.find(
@@ -344,7 +341,7 @@ export default class ReplicationConfiguration {
                 if (!this._hasScalityDestination) {
                     // If any endpoint does not have a type, then we know it is
                     // a Scality destination.
-                    this._hasScalityDestination = endpoint.type === undefined;
+                    this._hasScalityDestination = (endpoint.type === undefined);
                 }
                 return true;
             }
@@ -396,7 +393,7 @@ export default class ReplicationConfiguration {
         // We can replicate objects only to one destination bucket.
         if (this._destination && this._destination !== bucketARN) {
             return errorInstances.InvalidRequest.customizeDescription(
-                'The destination bucket must be same for all rules'
+                'The destination bucket must be the same for all rules'
             );
         }
         this._destination = bucketARN;
@@ -427,6 +424,11 @@ export default class ReplicationConfiguration {
         if (err) {
             return err;
         }
+        const { replicationEndpoints } = this._config;
+        if (replicationEndpoints.length === 0) {
+            return errors.InvalidRequest.customizeDescription(
+                'No configured replication endpoint');
+        }
         return this._parseRole();
     }
 

package.json

@@ -3,7 +3,7 @@
   "engines": {
     "node": ">=16"
   },
-  "version": "7.70.42",
+  "version": "7.70.43",
   "description": "Common utilities for the S3 project components",
   "main": "build/index.js",
   "repository": {