Skip to content

Modal closes when click ends outside of modal, even if input is focused. #160

@vingkan

Description

@vingkan

Description

Modal closes when click ends outside of modal, even if input is focused.

This is a bug in the sense that it is disruptive to the user. It's not an edge case that we anticipated, but that doesn't make it not a bug. That being said, it may be tricky to fix and is not super high priority, so we don't have to fix it now.

To Reproduce

  • Go to scatter view or timeline view
  • Click metric selector to open modal
  • Type something in search bar
  • Drag mouse to highlight the search bar contents
  • Release mouse drag outside of modal
  • Modal will close

Recording showing example:

https://www.loom.com/share/8afac30dc06f41abbaba11ae064924f5

Expected Behavior

Modal should not close while input is focused.

Suggested Solution

Add a state variable to keep track of whether the input is focused. This should capture when someone is typing in the input as well as when they are highlighting content in the input. If the input is focused, do not close the modal.

Metadata

Metadata

Assignees

Labels

appWork for frontend appbugSomething isn't workingstretchStretch project for Scarlet Data Studio interns.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions