Merge pull request #69 from schemacrawler/transport

Make --transport mandatory

Author: sualeh

.github/workflows/docker-image.yml

@@ -105,7 +105,6 @@ jobs:
 
     - id: build-docker-early-release
       name: Build and push SchemaCrawler AI early release Docker image
-      if: ${{ !startsWith(github.ref, 'refs/tags/') }}
       uses: docker/build-push-action@v6
       with:
         file: ./Dockerfile.early-access-release

changelog.md

@@ -2,6 +2,12 @@
 
 SchemaCrawler AI release notes.
 
+<a name="v16.26.3-3"></a>
+## Release 16.26.3-3 - 2025-07-15
+
+- Make `--transport` required, with no defaults
+
+
 <a name="v16.26.3-2"></a>
 ## Release 16.26.3-2 - 2025-07-15
 

schemacrawler-ai-mcpserver/src/main/bin/schemacrawler-ai.sh

@@ -3,4 +3,4 @@
 # SPDX-License-Identifier: CC-BY-NC-4.0
 
 SC_DIR=/opt/schemacrawler
-java -cp "$SC_DIR"/lib/*:"$SC_DIR"/config schemacrawler.tools.command.aichat.mcp.DockerMcpServer "$@"
+java -cp "$SC_DIR"/lib/*:"$SC_DIR"/config schemacrawler.tools.ai.mcpserver.DockerMcpServer "$@"

schemacrawler-ai-mcpserver/src/main/java/schemacrawler/tools/ai/mcpserver/DockerMcpServer.java

@@ -13,8 +13,8 @@
 import java.util.logging.Level;
 import static us.fatehi.utility.Utility.isBlank;
 import schemacrawler.schemacrawler.InfoLevel;
+import schemacrawler.tools.command.mcpserver.McpServerTransportType;
 import schemacrawler.tools.commandline.command.AvailableServers;
-import us.fatehi.utility.LoggingConfig;
 
 /**
  * Construct SchemaCrawler arguments from environment variables and run SchemaCrawler MCP Server.
@@ -76,7 +76,7 @@ public void addSchemaCrawlerArguments(final List<String> arguments) {
 
       // Add additional SchemaCrawler command line arguments
       arguments.add("--log-level");
-      arguments.add(Level.OFF.getName());
+      arguments.add(Level.INFO.getName());
 
       arguments.add("--routines");
       arguments.add(".*");
@@ -85,7 +85,7 @@ public void addSchemaCrawlerArguments(final List<String> arguments) {
       arguments.add("mcpserver");
 
       arguments.add("--transport");
-      arguments.add("stdio");
+      arguments.add(McpServerTransportType.stdio.name());
     }
 
     /**
@@ -200,9 +200,6 @@ public boolean isValidInfoLevel(final String infoLevel) {
    * @throws Exception If an error occurs during execution
    */
   public static void main(final String[] args) throws Exception {
-
-    new LoggingConfig(Level.OFF);
-
     final McpServerContext runner = new McpServerContext();
     final String[] arguments = runner.buildArguments();
     schemacrawler.Main.main(arguments);

schemacrawler-ai-mcpserver/src/main/java/schemacrawler/tools/ai/mcpserver/McpServerUtility.java

@@ -10,7 +10,7 @@
 
 import java.util.logging.Level;
 import java.util.logging.Logger;
-import schemacrawler.tools.command.mcpserver.McpTransport;
+import schemacrawler.tools.command.mcpserver.McpServerTransportType;
 import us.fatehi.utility.UtilityMarker;
 import us.fatehi.utility.string.StringFormat;
 
@@ -19,7 +19,7 @@ public class McpServerUtility {
 
   private static final Logger LOGGER = Logger.getLogger(McpServerUtility.class.getName());
 
-  public static void startMcpServer(final McpTransport mcpTransport) {
+  public static void startMcpServer(final McpServerTransportType mcpTransport) {
     if (mcpTransport == null) {
       throw new IllegalArgumentException("MCP transport not provided");
     }

schemacrawler-ai-mcpserver/src/main/java/schemacrawler/tools/ai/mcpserver/server/ToolProviderService.java

@@ -58,7 +58,7 @@ public String getSchemaCrawlerVersion(
           final String clientId,
       @ToolParam(description = "Event id, if available.", required = false) final String eventId) {
     final ObjectNode objectNode = JsonUtility.mapper.createObjectNode();
-    objectNode.put("schemacrawler-version", Version.about());
+    objectNode.put("schemacrawler-version", Version.version().toString());
     objectNode.put("mcp-client-id", clientId);
     objectNode.put("mcp-event-id", eventId);
     return objectNode.toString();

schemacrawler-ai-mcpserver/src/main/java/schemacrawler/tools/command/mcpserver/McpServerCommandOptions.java

@@ -10,4 +10,12 @@
 
 import schemacrawler.tools.executable.CommandOptions;
 
-public record McpServerCommandOptions(McpTransport mcpTransport) implements CommandOptions {}
+public record McpServerCommandOptions(McpServerTransportType mcpTransport)
+    implements CommandOptions {
+
+  public McpServerCommandOptions {
+    if (mcpTransport == null || mcpTransport == McpServerTransportType.unknown) {
+      throw new IllegalArgumentException("No MCR Server transport specified");
+    }
+  }
+}

schemacrawler-ai-mcpserver/src/main/java/schemacrawler/tools/command/mcpserver/McpServerCommandOptionsBuilder.java

@@ -8,6 +8,7 @@
 
 package schemacrawler.tools.command.mcpserver;
 
+import static schemacrawler.tools.command.mcpserver.McpServerTransportType.unknown;
 import schemacrawler.schemacrawler.OptionsBuilder;
 import schemacrawler.tools.options.Config;
 import schemacrawler.tools.options.ConfigOptionsBuilder;
@@ -20,10 +21,12 @@ public static McpServerCommandOptionsBuilder builder() {
     return new McpServerCommandOptionsBuilder();
   }
 
-  private McpTransport mcpTransport;
+  private McpServerTransportType mcpTransport;
 
   private McpServerCommandOptionsBuilder() {
-    mcpTransport = McpTransport.stdio;
+    // MCP Server transport needs to be explicitly specified,
+    // so default to known
+    mcpTransport = unknown;
   }
 
   @Override
@@ -34,7 +37,7 @@ public McpServerCommandOptionsBuilder fromOptions(final McpServerCommandOptions
     return this;
   }
 
-  public McpServerCommandOptionsBuilder withMcpTransport(McpTransport mcpServerType) {
+  public McpServerCommandOptionsBuilder withMcpTransport(McpServerTransportType mcpServerType) {
     if (mcpServerType != null) {
       mcpTransport = mcpServerType;
     }
@@ -49,7 +52,7 @@ public McpServerCommandOptions toOptions() {
   @Override
   public McpServerCommandOptionsBuilder fromConfig(final Config config) {
     if (config != null) {
-      mcpTransport = config.getEnumValue("transport", mcpTransport.stdio);
+      mcpTransport = config.getEnumValue("transport", unknown);
     }
 
     return this;

schemacrawler-ai-mcpserver/src/main/java/schemacrawler/tools/command/mcpserver/McpServerCommandProvider.java

@@ -26,7 +26,8 @@ public McpServerCommandProvider() {
   @Override
   public PluginCommand getCommandLineCommand() {
     final PluginCommand pluginCommand = newPluginCommand(COMMAND);
-    pluginCommand.addOption("transport", McpTransport.class, "Type of MCP server to start");
+    pluginCommand.addOption(
+        "transport", McpServerTransportType.class, "Type of MCP server to start");
     return pluginCommand;
   }
 

schemacrawler-ai-mcpserver/src/main/java/schemacrawler/tools/command/mcpserver/McpTransport.java renamed to schemacrawler-ai-mcpserver/src/main/java/schemacrawler/tools/command/mcpserver/McpServerTransportType.java

@@ -8,7 +8,8 @@
 
 package schemacrawler.tools.command.mcpserver;
 
-public enum McpTransport {
+public enum McpServerTransportType {
+  unknown,
   stdio,
   sse;
 }