Skip to content

Commit 19fe5d4

Browse files
author
Sergio
committed
fix: UC Browser android checking
1 parent 335ae46 commit 19fe5d4

File tree

4 files changed

+9
-5
lines changed

4 files changed

+9
-5
lines changed

Gemfile.lock

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
PATH
22
remote: .
33
specs:
4-
should_send_same_site_none (0.1.0)
4+
should_send_same_site_none (0.1.1)
55

66
GEM
77
remote: https://rubygems.org/

lib/should_send_same_site_none.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ def self.is_uc_browser_version_at_least(major, minor, build, user_agent)
7373
major_version = extract_regex_match(user_agent, regex, 1).to_i
7474
minor_version = extract_regex_match(user_agent, regex, 2).to_i
7575
build_version = extract_regex_match(user_agent, regex, 3).to_i
76-
if (major_version == major)
76+
if (major_version != major)
7777
return major_version > major
7878
end
7979

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
module ShouldSendSameSiteNone
2-
VERSION = "0.1.0"
2+
VERSION = "0.1.1"
33
end

spec/should_send_same_site_none_spec.rb

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
RSpec.describe ShouldSendSameSiteNone do
22
positive_cases = {
3+
"UC Browser 12.13.2 @ Android":
4+
"Mozilla/5.0 (Linux; U; Android 8.0.0; en-US; Pixel XL Build/OPR3.170623.007) AppleWebKit/534.30 (KHTML, like Gecko) Version/4.0 UCBrowser/12.13.2.1005 U3/0.8.0 Mobile Safari/534.30",
5+
"UC Browser 12.13.4 @ Android":
6+
"Mozilla/5.0 (Linux; U; Android 8.0.0; en-US; Pixel XL Build/OPR3.170623.007) AppleWebKit/534.30 (KHTML, like Gecko) Version/4.0 UCBrowser/12.13.4.1005 U3/0.8.0 Mobile Safari/534.30",
37
"Chrome 50 @ Win10":
48
"Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/50.0.2661.102 Safari/537.36",
59
"Chrome 67 @ Win10":
@@ -73,15 +77,15 @@
7377
expect(ShouldSendSameSiteNone::VERSION).not_to be nil
7478
end
7579

76-
describe 'positive cases' do
80+
describe 'Compatible browsers' do
7781
positive_cases.each do |key, value|
7882
it "#{key}" do
7983
expect(ShouldSendSameSiteNone.is_same_site_compatible(value)).to be(true)
8084
end
8185
end
8286
end
8387

84-
describe 'negative cases' do
88+
describe 'Incompatible browsers' do
8589
negative_cases.each do |key, value|
8690
it "#{key}" do
8791
expect(ShouldSendSameSiteNone.is_same_site_compatible(value)).to be(false)

0 commit comments

Comments
 (0)