main 🧊 timer on tick fix

Author: debabin

packages/core/src/bundle/hooks/useTimer/useTimer.js

@@ -63,8 +63,8 @@ export const useTimer = (...params) => {
     if (!active) return;
     optionsRef.current?.onStart?.();
     const onInterval = () => {
-      optionsRef.current?.onTick?.(seconds);
       setSeconds((prevSeconds) => {
+        optionsRef.current?.onTick?.(prevSeconds);
         const updatedSeconds = prevSeconds - 1;
         if (updatedSeconds === 0) {
           setActive(false);

packages/core/src/hooks/useTimer/useTimer.test.ts

@@ -174,11 +174,17 @@ it('Should call onStart when timer starts', () => {
 
 it('Should call onTick on each second', () => {
   const onTick = vi.fn();
-  renderHook(() => useTimer(1, { onTick }));
+  renderHook(() => useTimer(2, { onTick }));
 
   act(() => vi.advanceTimersToNextTimer());
 
   expect(onTick).toBeCalledTimes(1);
+  expect(onTick).toBeCalledWith(2);
+
+  act(() => vi.advanceTimersToNextTimer());
+
+  expect(onTick).toBeCalledTimes(2);
+  expect(onTick).toBeCalledWith(1);
 });
 
 it('Should pause timer', () => {

packages/core/src/hooks/useTimer/useTimer.ts

@@ -131,8 +131,8 @@ export const useTimer = ((...params: any[]) => {
 
     optionsRef.current?.onStart?.();
     const onInterval = () => {
-      optionsRef.current?.onTick?.(seconds);
       setSeconds((prevSeconds) => {
+        optionsRef.current?.onTick?.(prevSeconds);
         const updatedSeconds = prevSeconds - 1;
         if (updatedSeconds === 0) {
           setActive(false);