Skip to content

Commit 8fc0b49

Browse files
authored
tweak OpenTelemetry configuration
1 parent db4c713 commit 8fc0b49

File tree

2 files changed

+19
-2
lines changed

2 files changed

+19
-2
lines changed

service/src/main/java/org/whispersystems/textsecuregcm/configuration/OpenTelemetryConfiguration.java

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,17 @@
88
import com.fasterxml.jackson.annotation.JsonAnyGetter;
99
import com.fasterxml.jackson.annotation.JsonAnySetter;
1010
import com.fasterxml.jackson.annotation.JsonProperty;
11+
12+
import io.micrometer.registry.otlp.HistogramFlavor;
1113
import io.micrometer.registry.otlp.OtlpConfig;
1214
import java.time.Duration;
1315
import java.util.Map;
1416

1517
public record OpenTelemetryConfiguration(
1618
@JsonProperty boolean enabled,
1719
@JsonProperty Duration shutdownWaitDuration,
20+
@JsonProperty int maxBucketCount,
21+
@JsonProperty Map<String, Integer> maxBucketsPerMeter,
1822
@JsonAnyGetter @JsonAnySetter Map<String, String> otlpConfig
1923
) implements OtlpConfig {
2024

@@ -23,6 +27,19 @@ public String get(String key) {
2327
return otlpConfig.get(key.split("\\.", 2)[1]);
2428
}
2529

30+
@Override
31+
public Map<String, Integer> maxBucketsPerMeter() {
32+
if (maxBucketsPerMeter == null) {
33+
return Map.of();
34+
}
35+
return maxBucketsPerMeter;
36+
}
37+
38+
@Override
39+
public HistogramFlavor histogramFlavor() {
40+
return HistogramFlavor.BASE2_EXPONENTIAL_BUCKET_HISTOGRAM;
41+
}
42+
2643
public Duration shutdownWaitDuration() {
2744
if (shutdownWaitDuration == null) {
2845
return step().plus(step().dividedBy(2));

service/src/main/java/org/whispersystems/textsecuregcm/metrics/MetricsUtil.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ public static void configureRegistries(final WhisperServerConfiguration config,
6565

6666
Duration shutdownWaitDuration = Duration.ZERO;
6767

68-
if (config.getDatadogConfiguration() != null && config.getDatadogConfiguration().enabled()) {
68+
if (config.getDatadogConfiguration().enabled()) {
6969
final StatsdMeterRegistry dogstatsdMeterRegistry = new StatsdMeterRegistry(
7070
config.getDatadogConfiguration(), io.micrometer.core.instrument.Clock.SYSTEM);
7171

@@ -81,7 +81,7 @@ public static void configureRegistries(final WhisperServerConfiguration config,
8181
shutdownWaitDuration = config.getDatadogConfiguration().getShutdownWaitDuration();
8282
}
8383

84-
if (config.getOpenTelemetryConfiguration() != null && config.getOpenTelemetryConfiguration().enabled()) {
84+
if (config.getOpenTelemetryConfiguration().enabled()) {
8585
final OtlpMeterRegistry otlpMeterRegistry = new OtlpMeterRegistry(
8686
config.getOpenTelemetryConfiguration(), io.micrometer.core.instrument.Clock.SYSTEM);
8787

0 commit comments

Comments
 (0)