fix: issues found by SonarCloud

Author: sjinks

examples/sync_generator_adapter.cpp

@@ -20,9 +20,9 @@ wwa::coro::async_generator<int> async_iota(int start = 0)
 int main()
 {
     //! [usage]
-    wwa::coro::sync_generator_adapter<int> sync_iota(async_iota(10));
+    wwa::coro::sync_generator_adapter sync_iota(async_iota(10));
 
-    for (auto& n : sync_iota | std::views::take(5)) {
+    for (const auto& n : sync_iota | std::views::take(5)) {
         std::cout << n << "\n";
     }
     //! [usage]

src/async_generator.h

@@ -130,7 +130,7 @@ class [[nodiscard]] async_generator {
          *
          * This method is called when the coroutine returns. Does nothing.
          */
-        constexpr void return_void() noexcept {}
+        constexpr void return_void() const noexcept {}
 
         /**
          * @brief Yields a value from the generator.
@@ -234,7 +234,7 @@ class [[nodiscard]] async_generator {
              * @brief Constructs a new yield operation.
              * @param consumer The consumer coroutine.
              */
-            constexpr yield_op(std::coroutine_handle<> consumer) noexcept : m_consumer(consumer) {}
+            constexpr explicit yield_op(std::coroutine_handle<> consumer) noexcept : m_consumer(consumer) {}
 
             /**
              * @brief Determines whether the coroutine should suspend or continue immediately.

src/detail.h

@@ -17,7 +17,7 @@
 /// @cond INTERNAL
 
 // NOLINTNEXTLINE(modernize-concat-nested-namespaces)
-namespace wwa::coro {
+namespace wwa::coro {  // NOSONAR
 
 /**
  * @brief Internal utility functions for coroutine handling.

src/eager_task.h

@@ -61,7 +61,7 @@ class eager_task {
          * @internal
          * @test @a SimpleTaskDeathTest.UnhandledException ensures that the program terminates on an unhandled exception.
          */
-        [[noreturn]] void unhandled_exception() noexcept { std::terminate(); }
+        [[noreturn]] void unhandled_exception() const noexcept { std::terminate(); }
 
         /**
          * @brief Handles the exit out of the coroutine body.
@@ -85,7 +85,7 @@ class eager_task {
          * @internal
          * @test @a SimpleTaskTest.Basic
          */
-        constexpr auto initial_suspend() noexcept { return std::suspend_never{}; }
+        [[nodiscard]] constexpr auto initial_suspend() const noexcept { return std::suspend_never{}; }
 
         /**
          * @brief Issues an awaiter for final suspend point.
@@ -99,7 +99,7 @@ class eager_task {
          * @internal
          * @test @a SimpleTaskTest.Basic
          */
-        constexpr auto final_suspend() noexcept { return std::suspend_never{}; }
+        [[nodiscard]] constexpr auto final_suspend() const noexcept { return std::suspend_never{}; }
 
         /// @endcond
     };

src/generator.h

@@ -246,37 +246,6 @@ class [[nodiscard]] generator : public std::ranges::view_interface<generator<Res
         explicit iterator(std::coroutine_handle<promise_type> coroutine) noexcept : m_coroutine(coroutine) {}
         /// @endcond
 
-        /**
-         * @brief Move constructor.
-         *
-         * Constructs a new iterator object by moving the coroutine handle from another iterator.
-         *
-         * @param other Another iterator.
-         */
-        iterator(iterator&& other) noexcept : m_coroutine(std::exchange(other.m_coroutine, nullptr)) {}
-
-        /**
-         * @brief Destructor.
-         */
-        ~iterator() = default;
-
-        /**
-         * @brief Move assignment operator.
-         *
-         * Assigns the coroutine handle from another iterator to this iterator.
-         *
-         * @param other Another iterator.
-         * @return Reference to this iterator.
-         */
-        constexpr iterator& operator=(iterator&& other) noexcept
-        {
-            if (this != std::addressof(other)) {
-                this->m_coroutine = std::exchange(other.m_coroutine, nullptr);
-            }
-
-            return *this;
-        }
-
         /**
          * @brief Default constructor.
          *
@@ -286,26 +255,6 @@ class [[nodiscard]] generator : public std::ranges::view_interface<generator<Res
          */
         iterator() noexcept = default;
 
-        /**
-         * @brief Default copy constructor.
-         *
-         * @param other Another iterator.
-         *
-         * @internal
-         * @test @a GeneratorTest.View
-         * @note This constructor is required to satisfy the `std::ranges::view` concept.
-         */
-        iterator(const iterator& other) = default;
-
-        /**
-         * @brief Default assignment operator.
-         *
-         * @param other Another iterator (right hand side of the assignment operator).
-         * @return A reference to self.
-         * @note This operator is required to satisfy the `std::ranges::view` concept.
-         */
-        iterator& operator=(const iterator& other) = default;
-
         /**
          * @brief Compares two iterators.
          *

test/generator.cpp

@@ -366,37 +366,6 @@ TEST(GeneratorTest, EmptyGenerator)
     EXPECT_THROW(++it, bad_result_access);
 }
 
-TEST(GeneratorIteratorTest, Move)
-{
-    constexpr int v1 = 1;
-    constexpr int v2 = 4;
-
-    auto g1 = value<decltype(v1)>(v1);
-    auto g2 = value<decltype(v2)>(v2);
-
-    auto it1 = g1.begin();
-    auto it2 = g2.begin();
-
-    it2 = std::move(it1);
-
-    EXPECT_EQ(*it2, v1);
-}
-
-TEST(GeneratorIteratorTest, MoveSelf)
-{
-    constexpr int expected = 1983;
-
-    auto g = value<decltype(expected)>(expected);
-
-    auto it = g.begin();
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wself-move"
-    it = std::move(it);
-#pragma clang diagnostic pop
-
-    EXPECT_EQ(*it, expected);
-}
-
 TEST(GeneratorIteratorTest, AccessEndIterator)
 {
     auto g = value(1);