Skip to content

Commit 55e6d86

Browse files
committed
fixes for ios and doc update
1 parent 5a37d15 commit 55e6d86

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

71 files changed

+33
-27
lines changed

README.md

Lines changed: 12 additions & 11 deletions

android/src/main/java/com/reactnativechangeicon/ChangeIconModule.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ public void getIcon(Promise promise) {
4848
final String activityName = activity.getComponentName().getClassName();
4949

5050
if (activityName.endsWith("MainActivity")) {
51-
promise.resolve("default");
51+
promise.resolve("Default");
5252
return;
5353
}
5454
String[] activityNameSplit = activityName.split("MainActivity");
@@ -71,8 +71,8 @@ public void changeIcon(String iconName, Promise promise) {
7171
if (this.componentClass.isEmpty()) {
7272
this.componentClass = activity.getComponentName().getClassName();
7373
}
74-
75-
final String newIconName = (iconName == null || iconName.isEmpty() || iconName.equals("default")) ? "" : iconName;
74+
75+
final String newIconName = (iconName == null || iconName.isEmpty() || iconName.equals("Default")) ? "" : iconName;
7676
final String activeClass = this.packageName + ".MainActivity" + newIconName;
7777
if (this.componentClass.equals(activeClass)) {
7878
promise.reject("ANDROID:ICON_ALREADY_USED:" + this.componentClass);
@@ -83,7 +83,7 @@ public void changeIcon(String iconName, Promise promise) {
8383
new ComponentName(this.packageName, activeClass),
8484
PackageManager.COMPONENT_ENABLED_STATE_ENABLED,
8585
PackageManager.DONT_KILL_APP);
86-
promise.resolve(newIconName);
86+
promise.resolve(newIconName.isEmpty() ? "Default" : newIconName);
8787
} catch (Exception e) {
8888
promise.reject("ANDROID:ICON_INVALID");
8989
return;

dist/index.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
import { NativeModules, Platform } from "react-native";
2-
const defaultIcon = () => Platform.select({ ios: "AppIcon", android: "" });
3-
export const changeIcon = (iconName) => NativeModules.ChangeIcon.changeIcon(iconName || defaultIcon());
1+
import { NativeModules } from "react-native";
2+
export const changeIcon = (iconName) => NativeModules.ChangeIcon.changeIcon(iconName);
43
export const resetIcon = () => changeIcon();
54
export const getIcon = () => NativeModules.ChangeIcon.getIcon();

docs/examples/Step-3/Dark/ios/AppIconDark.appiconset/Contents.json

Lines changed: 0 additions & 1 deletion
This file was deleted.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.

docs/examples/Step-3/Default/ios/AppIcon.appiconset/Contents.json

Lines changed: 0 additions & 1 deletion
This file was deleted.

0 commit comments

Comments
 (0)