Skip to content

Commit ece3fb9

Browse files
authored
Merge pull request #59 from skiptomyliu/2022-08-15
Fix crash when selecting artist link from now playing
2 parents 12df190 + d0aedf9 commit ece3fb9

File tree

6 files changed

+7
-7
lines changed

6 files changed

+7
-7
lines changed

App/Milkshake.dmg

-47 Bytes
Binary file not shown.
Binary file not shown.

Milkshake.xcworkspace/xcuserdata/dean.xcuserdatad/xcdebugger/Breakpoints_v2.xcbkptlist

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,8 @@
7676
endingColumnNumber = "9223372036854775807"
7777
startingLineNumber = "52"
7878
endingLineNumber = "52"
79-
landmarkName = "actionSelectedCell(sender:)"
80-
landmarkType = "7">
79+
landmarkName = "unknown"
80+
landmarkType = "0">
8181
</BreakpointContent>
8282
</BreakpointProxy>
8383
<BreakpointProxy

Milkshake/Info.plist

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,9 @@
1919
<key>CFBundlePackageType</key>
2020
<string>APPL</string>
2121
<key>CFBundleShortVersionString</key>
22-
<string>1.3.0</string>
22+
<string>1.3.1</string>
2323
<key>CFBundleVersion</key>
24-
<string>41</string>
24+
<string>42</string>
2525
<key>LSApplicationCategoryType</key>
2626
<string>public.app-category.music</string>
2727
<key>LSMinimumSystemVersion</key>

Milkshake/MainViewController.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -274,7 +274,7 @@ class MainViewController: NSViewController {
274274
let cell = rvc.searchTableView.view(atColumn: 0, row: i, makeIfNecessary: false) as! SearchTableCellView
275275
if (
276276
// skip shuffle banner
277-
!cell.item.isShuffle! && (
277+
!(cell.item.isShuffle ?? false) && (
278278
// check song
279279
cell.item.pandoraId == music.curPlayingItem.pandoraId ||
280280
// check station
@@ -537,7 +537,7 @@ extension MainViewController: CellSelectedProtocol {
537537
}
538538
}
539539
else if type == MusicType.SHUFFLESTATION {
540-
if item.isShuffle! {
540+
if item.isShuffle ?? false {
541541
if !self.appDelegate.radio.isShuffle {
542542
self.appDelegate.api.shuffleStation(stationsIds: [], callbackHandler: callbackShuffle)
543543
}

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ Milkshake is a Mac OS X [Pandora](https://www.pandora.com) client.
77

88
If you don't have a Pandora account, you can [sign up here](https://www.pandora.com/account/register)
99

10-
# Download v1.3.0
10+
# Download v1.3.1
1111
[💾 DMG Installer](https://github.com/skiptomyliu/milkshake/raw/master/App/Milkshake.dmg)
1212

1313

0 commit comments

Comments
 (0)