refactor: split registration functionality between StudentCourseRegistration and AdminCourseRegistration

frooooooo7 · frooooooo7 · commit 854a7a533d7a · 2025-02-04T17:41:06.000+01:00
feat: add StudentCourseRegistrationController and its functionalities
diff --git a/app/Http/Controllers/CourseRegistration/AdminCourseRegistrationController.php b/app/Http/Controllers/CourseRegistration/AdminCourseRegistrationController.php
@@ -0,0 +1,34 @@
+<?php
+
+
+namespace App\Http\Controllers\CourseRegistration;
+
+use App\Http\Controllers\Controller;
+use App\Http\Requests\CourseRegistration\StoreCourseRegistrationRequest;
+use App\Http\Requests\CourseRegistration\UpdateCourseRegistrationRequest;
+use App\Http\Resources\CourseRegistration\CourseRegistrationCollection;
+use App\Http\Resources\CourseRegistration\CourseRegistrationResource;
+use App\Models\Course;
+use App\Models\CourseRegistration;
+use App\Services\CourseRegistrationService;
+
+class AdminCourseRegistrationController extends Controller
+{
+    public function __construct(protected CourseRegistrationService $courseRegistrationService)
+    {
+    }
+//    public function index(): CourseRegistrationCollection
+//    {
+//        return new CourseRegistrationCollection($this->courseRegistrationService->index());
+//    }
+//
+//    public function store(StoreCourseRegistrationRequest $request, Course $course): CourseRegistrationResource
+//    {
+//        return new CourseRegistrationResource($this->courseRegistrationService->create($request->getCourseRegistration($course)));
+//    }
+//
+//    public function update(UpdateCourseRegistrationRequest $request, CourseRegistration $courseRegistration): CourseRegistrationResource
+//    {
+//        return new CourseRegistrationResource($this->courseRegistrationService->update($request->getCourseRegistration(), $courseRegistration));
+//    }
+}
diff --git a/app/Http/Controllers/CourseRegistration/StudentCourseRegistrationController.php b/app/Http/Controllers/CourseRegistration/StudentCourseRegistrationController.php
@@ -0,0 +1,19 @@
+<?php
+
+namespace App\Http\Controllers\CourseRegistration;
+
+use App\Http\Controllers\Controller;
+use App\Http\Requests\CourseRegistration\StoreStudentCourseRegistrationRequest;
+use App\Http\Resources\CourseRegistration\StudentCourseRegistrationResource;
+use App\Models\Course;
+use App\Services\StudentCourseRegistrationService;
+
+class StudentCourseRegistrationController extends Controller
+{
+    public function __construct(protected StudentCourseRegistrationService $studentCourseRegistrationService) {}
+
+    public function store(StoreStudentCourseRegistrationRequest $request, Course $course): StudentCourseRegistrationResource
+    {
+        return new StudentCourseRegistrationResource($this->studentCourseRegistrationService->store($request->getStudentCourseRegistration($course)));
+    }
+}
diff --git a/app/Http/Controllers/CourseRegistrationController.php b/app/Http/Controllers/CourseRegistrationController.php
diff --git a/app/Http/Requests/CourseRegistration/StoreCourseRegistrationRequest.php b/app/Http/Requests/CourseRegistration/StoreCourseRegistrationRequest.php
@@ -1,6 +1,6 @@
 <?php
 
-namespace App\Http\Requests;
+namespace App\Http\Requests\CourseRegistration;
 
 use App\Models\Course;
 use App\ValueObjects\CreateCourseRegistration;
diff --git a/app/Http/Requests/CourseRegistration/StoreStudentCourseRegistrationRequest.php b/app/Http/Requests/CourseRegistration/StoreStudentCourseRegistrationRequest.php
@@ -0,0 +1,62 @@
+<?php
+
+namespace App\Http\Requests\CourseRegistration;
+
+use App\Models\Course;
+use App\ValueObjects\StoreStudentCourseRegistration;
+use Illuminate\Foundation\Http\FormRequest;
+
+class StoreStudentCourseRegistrationRequest extends FormRequest
+{
+    /**
+     * Determine if the user is authorized to make this request.
+     */
+    public function authorize(): bool
+    {
+        return true;
+    }
+
+    /**
+     * Get the validation rules that apply to the request.
+     *
+     * @return array<string, \Illuminate\Contracts\Validation\ValidationRule|array<mixed>|string>
+     */
+    public function rules(): array
+    {
+        return [
+            'name' => [
+                'required',
+                'string',
+                'min:2',
+                'max:30',
+                'regex:/^[a-zA-ZÀ-ž\s\'-]+$/',
+            ],
+            'last_name' => [
+                'required',
+                'string',
+                'min:2',
+                'max:30',
+                'regex:/^[a-zA-ZÀ-ž\s\'-]+$/',
+            ],
+            'email' => [
+                'required',
+                'email',
+            ],
+            'phone' => [
+                'required',
+                'regex:/^\+?\d{9,15}$/',
+            ],
+        ];
+    }
+
+    public function getStudentCourseRegistration(Course $course): StoreStudentCourseRegistration
+    {
+        return new StoreStudentCourseRegistration(
+            $course->id,
+            $this->get('name'),
+            $this->get('last_name'),
+            $this->get('email'),
+            $this->get('phone'),
+        );
+    }
+}
diff --git a/app/Http/Requests/CourseRegistration/UpdateCourseRegistrationRequest.php b/app/Http/Requests/CourseRegistration/UpdateCourseRegistrationRequest.php
@@ -1,6 +1,6 @@
 <?php
 
-namespace App\Http\Requests;
+namespace App\Http\Requests\CourseRegistration;
 
 use App\Enums\RegistrationStatus;
 use App\ValueObjects\UpdateCourseRegistration;
diff --git a/app/Http/Resources/CourseRegistration/CourseRegistrationCollection.php b/app/Http/Resources/CourseRegistration/CourseRegistrationCollection.php
@@ -1,6 +1,6 @@
 <?php
 
-namespace App\Http\Resources;
+namespace App\Http\Resources\CourseRegistration;
 
 use Illuminate\Http\Request;
 use Illuminate\Http\Resources\Json\ResourceCollection;
diff --git a/app/Http/Resources/CourseRegistration/CourseRegistrationResource.php b/app/Http/Resources/CourseRegistration/CourseRegistrationResource.php
@@ -1,6 +1,6 @@
 <?php
 
-namespace App\Http\Resources;
+namespace App\Http\Resources\CourseRegistration;
 
 use Illuminate\Http\Request;
 use Illuminate\Http\Resources\Json\JsonResource;
diff --git a/app/Http/Resources/CourseRegistration/StudentCourseRegistrationResource.php b/app/Http/Resources/CourseRegistration/StudentCourseRegistrationResource.php
@@ -0,0 +1,29 @@
+<?php
+
+namespace App\Http\Resources\CourseRegistration;
+
+use Illuminate\Http\Request;
+use Illuminate\Http\Resources\Json\JsonResource;
+
+class StudentCourseRegistrationResource extends JsonResource
+{
+    /**
+     * Transform the resource into an array.
+     *
+     * @return array<string, mixed>
+     */
+    public function toArray(Request $request): array
+    {
+        return [
+            'id' => $this->id,
+            'course_id' => $this->course_id,
+            'name' => $this->name,
+            'last_name' => $this->last_name,
+            'email' => $this->email,
+            'phone' => $this->phone,
+            'status' => $this->status,
+            'created_at' => $this->created_at?->toDateTimeString(),
+            'updated_at' => $this->updated_at?->toDateTimeString(),
+        ];
+    }
+}
diff --git a/app/Models/Course.php b/app/Models/Course.php
@@ -7,6 +7,7 @@
 use Illuminate\Database\Eloquent\Factories\HasFactory;
 use Illuminate\Database\Eloquent\Model;
 use Illuminate\Database\Eloquent\Relations\BelongsTo;
+use Illuminate\Database\Eloquent\Relations\BelongsToMany;
 use Illuminate\Database\Eloquent\Relations\HasMany;
 
 /**
@@ -43,7 +44,11 @@ public function category(): BelongsTo
         return $this->belongsTo(Category::class);
     }
 
-    public function courseRegistrations(): HasMany
+    public function users(): BelongsToMany
+    {
+        return $this->belongsToMany(User::class, 'course_user');
+    }
+    public function registrations(): hasMany
     {
         return $this->hasMany(CourseRegistration::class);
     }
diff --git a/app/Models/CourseRegistration.php b/app/Models/CourseRegistration.php
@@ -6,6 +6,7 @@
 use Database\Factories\CourseRegistrationFactory;
 use Illuminate\Database\Eloquent\Factories\HasFactory;
 use Illuminate\Database\Eloquent\Model;
+use Illuminate\Database\Eloquent\Relations\BelongsTo;
 
 class CourseRegistration extends Model
 {
@@ -14,21 +15,15 @@ class CourseRegistration extends Model
 
     protected $fillable = [
         'course_id',
-        'user_id',
-        'status',
+        'name',
+        'last_name',
+        'email',
+        'phone'
     ];
 
-    protected $casts = [
-        'status' => RegistrationStatus::class,
-    ];
-
-    public function user()
-    {
-        return $this->belongsTo(User::class);
-    }
-
-    public function course()
+    public function course(): BelongsTo
     {
         return $this->belongsTo(Course::class);
     }
+
 }
diff --git a/app/Models/User.php b/app/Models/User.php
@@ -5,6 +5,7 @@
 // use Illuminate\Contracts\Auth\MustVerifyEmail;
 use Database\Factories\UserFactory;
 use Illuminate\Database\Eloquent\Factories\HasFactory;
+use Illuminate\Database\Eloquent\Relations\BelongsToMany;
 use Illuminate\Database\Eloquent\Relations\HasMany;
 use Illuminate\Database\Eloquent\Relations\HasOne;
 use Illuminate\Foundation\Auth\User as Authenticatable;
@@ -62,9 +63,9 @@ public function creditCard(): HasOne
     {
         return $this->hasOne(CreditCard::class);
     }
-
-    public function courseRegistrations(): HasMany
+    public function courses(): BelongsToMany
     {
-        return $this->hasMany(CourseRegistration::class);
+        return $this->belongsToMany(Course::class, 'course_user');
     }
+
 }
diff --git a/app/Services/StudentCourseRegistrationService.php b/app/Services/StudentCourseRegistrationService.php
@@ -0,0 +1,15 @@
+<?php
+
+namespace App\Services;
+
+use App\Models\CourseRegistration;
+use App\ValueObjects\StoreStudentCourseRegistration;
+
+class StudentCourseRegistrationService
+{
+    public function store(StoreStudentCourseRegistration $data): CourseRegistration
+    {
+        return CourseRegistration::create($data->toArray());
+    }
+
+}
diff --git a/app/ValueObjects/StoreStudentCourseRegistration.php b/app/ValueObjects/StoreStudentCourseRegistration.php
@@ -0,0 +1,51 @@
+<?php
+
+namespace App\ValueObjects;
+
+use App\Enums\RegistrationStatus;
+use Illuminate\Contracts\Support\Arrayable;
+
+final readonly class StoreStudentCourseRegistration implements Arrayable
+{
+    public function __construct(
+        private int $courseId,
+        private string $name,
+        private string $last_name,
+        private string $email,
+        private string $phone,
+    ) {}
+
+    public function getCourseId(): int
+    {
+        return $this->courseId;
+    }
+    public function getName(): string
+    {
+        return $this->name;
+    }
+    public function getLast_Name(): string
+    {
+        return $this->last_name;
+    }
+
+    public function getEmail(): string
+    {
+        return $this->email;
+    }
+    public function getPhone(): string
+    {
+        return $this->phone;
+    }
+
+    public function toArray(): array
+    {
+        return [
+            'course_id' => $this->getCourseId(),
+            'name' => $this->getName(),
+            'last_name' => $this->getLast_Name(),
+            'email' => $this->getEmail(),
+            'phone' => $this->getPhone(),
+            'status' => RegistrationStatus::PENDING->value,
+        ];
+    }
+}
diff --git a/database/factories/CourseRegistrationFactory.php b/database/factories/CourseRegistrationFactory.php
@@ -2,16 +2,23 @@
 
 namespace Database\Factories;
 
-use App\Enums\RegistrationStatus;
+use App\Models\CourseRegistration;
 use App\Models\Course;
-use App\Models\User;
 use Illuminate\Database\Eloquent\Factories\Factory;
+use Illuminate\Support\Str;
 
 /**
  * @extends \Illuminate\Database\Eloquent\Factories\Factory<\App\Models\CourseRegistration>
  */
 class CourseRegistrationFactory extends Factory
 {
+    /**
+     * The name of the factory's corresponding model.
+     *
+     * @var string
+     */
+    protected $model = CourseRegistration::class;
+
     /**
      * Define the model's default state.
      *
@@ -21,8 +28,10 @@ public function definition(): array
     {
         return [
             'course_id' => Course::factory(),
-            'user_id' => User::factory(),
-            'status' => RegistrationStatus::PENDING->value,
+            'name' => $this->faker->firstName(),
+            'last_name' => $this->faker->lastName(),
+            'email' => $this->faker->unique()->safeEmail(),
+            'phone' => $this->faker->phoneNumber(),
         ];
     }
 }
diff --git a/database/migrations/2025_01_08_183400_create_course_registrations_table.php b/database/migrations/2025_01_08_183400_create_course_registrations_table.php
diff --git a/database/migrations/2025_02_02_182015_create_course_user_table.php b/database/migrations/2025_02_02_182015_create_course_user_table.php
diff --git a/database/seeders/CourseRegistrationSeeder.php b/database/seeders/CourseRegistrationSeeder.php
diff --git a/database/seeders/DatabaseSeeder.php b/database/seeders/DatabaseSeeder.php
diff --git a/routes/api.php b/routes/api.php

Original file line number	Diff line number	Diff line change
`@@ -7,6 +7,7 @@`
`7`	`7`	`use Illuminate\Database\Eloquent\Factories\HasFactory;`
`8`	`8`	`use Illuminate\Database\Eloquent\Model;`
`9`	`9`	`use Illuminate\Database\Eloquent\Relations\BelongsTo;`
	`10`	`+use Illuminate\Database\Eloquent\Relations\BelongsToMany;`
`10`	`11`	`use Illuminate\Database\Eloquent\Relations\HasMany;`
`11`	`12`
`12`	`13`	`/**`
`@@ -43,7 +44,11 @@ public function category(): BelongsTo`
`43`	`44`	`return $this->belongsTo(Category::class);`
`44`	`45`	`}`
`45`	`46`
`46`		`- public function courseRegistrations(): HasMany`
	`47`	`+ public function users(): BelongsToMany`
	`48`	`+ {`
	`49`	`+ return $this->belongsToMany(User::class, 'course_user');`
	`50`	`+ }`
	`51`	`+ public function registrations(): hasMany`
`47`	`52`	`{`
`48`	`53`	`return $this->hasMany(CourseRegistration::class);`
`49`	`54`	`}`