feat: add support for string arrays in rules engine parameters

Author: 0marperez

.changes/f1afb4d6-fa61-4eba-8695-b9a8bc59418a.json

@@ -0,0 +1,5 @@
+{
+    "id": "f1afb4d6-fa61-4eba-8695-b9a8bc59418a",
+    "type": "feature",
+    "description": "Add support for string arrays in rules engine parameters"
+}

codegen/smithy-kotlin-codegen/src/main/kotlin/software/amazon/smithy/kotlin/codegen/model/RulesEngineExt.kt

@@ -8,6 +8,7 @@ import software.amazon.smithy.codegen.core.Symbol
 import software.amazon.smithy.kotlin.codegen.lang.KotlinTypes
 import software.amazon.smithy.kotlin.codegen.utils.doubleQuote
 import software.amazon.smithy.kotlin.codegen.utils.toCamelCase
+import software.amazon.smithy.rulesengine.language.evaluation.value.ArrayValue
 import software.amazon.smithy.rulesengine.language.evaluation.value.BooleanValue
 import software.amazon.smithy.rulesengine.language.evaluation.value.StringValue
 import software.amazon.smithy.rulesengine.language.evaluation.value.Value
@@ -32,7 +33,7 @@ fun ParameterType.toSymbol(): Symbol =
     when (this) {
         ParameterType.STRING -> KotlinTypes.String
         ParameterType.BOOLEAN -> KotlinTypes.Boolean
-        ParameterType.STRING_ARRAY -> KotlinTypes.Collections.MutableList
+        ParameterType.STRING_ARRAY -> KotlinTypes.Collections.mutableList(KotlinTypes.String)
     }.asNullable()
 
 /**
@@ -42,5 +43,8 @@ fun Value.toLiteral(): String =
     when (this) {
         is StringValue -> value.doubleQuote()
         is BooleanValue -> value.toString()
+        is ArrayValue -> values.joinToString(",", "mutableListOf(", ")") { value ->
+            value.expectStringValue().value.doubleQuote()
+        }
         else -> throw IllegalArgumentException("unrecognized parameter value type $type")
     }

codegen/smithy-kotlin-codegen/src/main/kotlin/software/amazon/smithy/kotlin/codegen/rendering/endpoints/DefaultEndpointProviderTestGenerator.kt

@@ -10,7 +10,9 @@ import software.amazon.smithy.kotlin.codegen.KotlinSettings
 import software.amazon.smithy.kotlin.codegen.core.*
 import software.amazon.smithy.kotlin.codegen.model.buildSymbol
 import software.amazon.smithy.kotlin.codegen.rendering.protocol.ProtocolGenerator
+import software.amazon.smithy.kotlin.codegen.utils.doubleQuote
 import software.amazon.smithy.kotlin.codegen.utils.toCamelCase
+import software.amazon.smithy.model.node.ArrayNode
 import software.amazon.smithy.model.node.BooleanNode
 import software.amazon.smithy.model.node.Node
 import software.amazon.smithy.model.node.StringNode
@@ -130,6 +132,13 @@ class DefaultEndpointProviderTestGenerator(
         when (v) {
             is StringNode -> writer.writeInline("#S", v.value)
             is BooleanNode -> writer.writeInline("#L", v.value)
+            is ArrayNode -> {
+                writer.writeInline(
+                    v.elements.joinToString(",", "mutableListOf(", ")") { element ->
+                        element.expectStringNode().value.doubleQuote()
+                    },
+                )
+            }
             else -> throw IllegalArgumentException("unexpected test case param value")
         }
     }

codegen/smithy-kotlin-codegen/src/main/kotlin/software/amazon/smithy/kotlin/codegen/rendering/endpoints/EndpointResolverAdapterGenerator.kt

@@ -12,6 +12,7 @@ import software.amazon.smithy.kotlin.codegen.integration.SectionId
 import software.amazon.smithy.kotlin.codegen.model.*
 import software.amazon.smithy.kotlin.codegen.model.knowledge.EndpointParameterIndex
 import software.amazon.smithy.kotlin.codegen.rendering.protocol.ProtocolGenerator
+import software.amazon.smithy.kotlin.codegen.utils.doubleQuote
 import software.amazon.smithy.model.knowledge.TopDownIndex
 import software.amazon.smithy.model.shapes.OperationShape
 import software.amazon.smithy.rulesengine.language.syntax.parameters.ParameterType
@@ -192,6 +193,11 @@ class EndpointResolverAdapterGenerator(
                 when (param.type) {
                     ParameterType.STRING -> writer.write("#S", staticParam.value.expectStringNode().value)
                     ParameterType.BOOLEAN -> writer.write("#L", staticParam.value.expectBooleanNode().value)
+                    ParameterType.STRING_ARRAY -> writer.write(
+                        staticParam.value.expectArrayNode().elements.joinToString(",", "mutableListOf(", ")") { element ->
+                            element.expectStringNode().value.doubleQuote()
+                        },
+                    )
                     else -> throw CodegenException("unexpected static context param type ${param.type}")
                 }
                 continue

codegen/smithy-kotlin-codegen/src/test/kotlin/software/amazon/smithy/kotlin/codegen/rendering/endpoints/EndpointParametersGeneratorTest.kt

@@ -29,6 +29,10 @@ class EndpointParametersGeneratorTest {
                         "type": "Boolean",
                         "required": false
                     },
+                    "StringArrayField": {
+                        "type": "stringArray",
+                        "required": false
+                    },
                     "RequiredStringField": {
                         "type": "String",
                         "required": true
@@ -161,6 +165,8 @@ class EndpointParametersGeneratorTest {
             public val requiredBooleanField: Boolean? = requireNotNull(builder.requiredBooleanField) { "endpoint provider parameter #requiredBooleanField is required" }
          
             public val requiredStringField: String? = requireNotNull(builder.requiredStringField) { "endpoint provider parameter #requiredStringField is required" }
+            
+            public val stringArrayField: kotlin.collections.MutableList<kotlin.String>? = builder.stringArrayField
          
             public val stringField: String? = builder.stringField
         """.formatForTest()
@@ -195,6 +201,7 @@ class EndpointParametersGeneratorTest {
                 if (this.documentedField != other.documentedField) return false
                 if (this.requiredBooleanField != other.requiredBooleanField) return false
                 if (this.requiredStringField != other.requiredStringField) return false
+                if (this.stringArrayField != other.stringArrayField) return false
                 if (this.stringField != other.stringField) return false
                 return true
             }
@@ -218,6 +225,7 @@ class EndpointParametersGeneratorTest {
                 result = 31 * result + (documentedField?.hashCode() ?: 0)
                 result = 31 * result + (requiredBooleanField?.hashCode() ?: 0)
                 result = 31 * result + (requiredStringField?.hashCode() ?: 0)
+                result = 31 * result + (stringArrayField?.hashCode() ?: 0)
                 result = 31 * result + (stringField?.hashCode() ?: 0)
                 return result
             }
@@ -242,6 +250,7 @@ class EndpointParametersGeneratorTest {
                 append("documentedField=${'$'}documentedField,")
                 append("requiredBooleanField=${'$'}requiredBooleanField,")
                 append("requiredStringField=${'$'}requiredStringField,")
+                append("stringArrayField=${'$'}stringArrayField,")
                 append("stringField=${'$'}stringField)")
             }
         """.formatForTest()
@@ -265,6 +274,7 @@ class EndpointParametersGeneratorTest {
                     documentedField = this@TestEndpointParameters.documentedField
                     requiredBooleanField = this@TestEndpointParameters.requiredBooleanField
                     requiredStringField = this@TestEndpointParameters.requiredStringField
+                    stringArrayField = this@TestEndpointParameters.stringArrayField
                     stringField = this@TestEndpointParameters.stringField
                     block()
                 }
@@ -304,6 +314,8 @@ class EndpointParametersGeneratorTest {
                 public var requiredBooleanField: Boolean? = null
          
                 public var requiredStringField: String? = null
+                
+                public var stringArrayField: kotlin.collections.MutableList<kotlin.String>? = null
          
                 public var stringField: String? = null