Skip to content

Commit 75a204a

Browse files
committed
Add FIXMEs
1 parent 1d099ae commit 75a204a

File tree

6 files changed

+9
-9
lines changed

6 files changed

+9
-9
lines changed

codegen/protocol-tests/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ dependencies {
8888

8989
val generateProtocolTestProjectionTasks = smithyBuild.projections.map { projection ->
9090
tasks.register<Exec>("testProtocol-${projection.name}") {
91-
dependsOn(tasks.generateSmithyProjections)
91+
dependsOn(tasks.generateSmithyProjections) // FIXME This is breaking Gradle configuration cache
9292
group = "Verification"
9393

9494
val wrapper = if (System.getProperty("os.name").lowercase().contains("windows")) "gradlew.bat" else "gradlew"

tests/benchmarks/serde-benchmarks/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ val benchmarkModels = listOf(
100100

101101
val stageGeneratedSources = tasks.register("stageGeneratedSources") {
102102
group = "codegen"
103-
dependsOn(tasks.generateSmithyProjections)
103+
dependsOn(tasks.generateSmithyProjections) // FIXME This is breaking Gradle configuration cache
104104
doLast {
105105
benchmarkModels.forEach {
106106
copy {

tests/codegen/nullability-tests/build.gradle.kts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ tasks.generateSmithyProjections {
2424
}
2525

2626
tasks.kotlinSourcesJar {
27-
dependsOn(tasks.generateSmithyProjections)
27+
dependsOn(tasks.generateSmithyProjections) // FIXME This is breaking Gradle configuration cache
2828
}
2929

3030
val optinAnnotations = listOf("kotlin.RequiresOptIn", "aws.smithy.kotlin.runtime.InternalApi")
@@ -44,7 +44,7 @@ kotlin.sourceSets.getByName("main") {
4444
}
4545

4646
tasks.withType<org.jetbrains.kotlin.gradle.tasks.KotlinCompile> {
47-
dependsOn(tasks.generateSmithyProjections)
47+
dependsOn(tasks.generateSmithyProjections) // FIXME This is breaking Gradle configuration cache
4848
// FIXME - generated code has warnings unfortunately, see https://github.com/awslabs/aws-sdk-kotlin/issues/1169
4949
compilerOptions.allWarningsAsErrors = false
5050
}

tests/codegen/paginator-tests/build.gradle.kts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ tasks.generateSmithyProjections {
2424
}
2525

2626
tasks.kotlinSourcesJar {
27-
dependsOn(tasks.generateSmithyProjections)
27+
dependsOn(tasks.generateSmithyProjections) // FIXME This is breaking Gradle configuration cache
2828
}
2929

3030
val optinAnnotations = listOf("kotlin.RequiresOptIn", "aws.smithy.kotlin.runtime.InternalApi")
@@ -37,7 +37,7 @@ kotlin.sourceSets.getByName("main") {
3737
}
3838

3939
tasks.withType<org.jetbrains.kotlin.gradle.tasks.KotlinCompile> {
40-
dependsOn(tasks.generateSmithyProjections)
40+
dependsOn(tasks.generateSmithyProjections) // FIXME This is breaking Gradle configuration cache
4141
}
4242

4343
tasks.test {

tests/codegen/serde-tests/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ val generatedSrcDir = project.layout.projectDirectory.dir("generated-src/main/ko
6060

6161
val stageGeneratedSources = tasks.register("stageGeneratedSources") {
6262
group = "codegen"
63-
dependsOn(tasks.generateSmithyProjections)
63+
dependsOn(tasks.generateSmithyProjections) // FIXME This is breaking Gradle configuration cache
6464
outputs.dir(generatedSrcDir)
6565
// FIXME - this task up-to-date checks are wrong, likely something is not setup right with inputs/outputs somewhere
6666
// for now just always run it

tests/codegen/waiter-tests/build.gradle.kts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ tasks.generateSmithyProjections {
2323
}
2424

2525
tasks.kotlinSourcesJar {
26-
dependsOn(tasks.generateSmithyProjections)
26+
dependsOn(tasks.generateSmithyProjections) // FIXME This is breaking Gradle configuration cache
2727
}
2828

2929
val optinAnnotations = listOf("kotlin.RequiresOptIn", "aws.smithy.kotlin.runtime.InternalApi")
@@ -36,7 +36,7 @@ kotlin.sourceSets.getByName("main") {
3636
}
3737

3838
tasks.withType<org.jetbrains.kotlin.gradle.tasks.KotlinCompile> {
39-
dependsOn(tasks.generateSmithyProjections)
39+
dependsOn(tasks.generateSmithyProjections) // FIXME This is breaking Gradle configuration cache
4040
compilerOptions {
4141
// generated code has warnings unfortunately
4242
allWarningsAsErrors = false

0 commit comments

Comments
 (0)