Add a comment

Author: lauzadis

build.gradle.kts

@@ -5,6 +5,7 @@
 import aws.sdk.kotlin.gradle.dsl.configureJReleaser
 import aws.sdk.kotlin.gradle.dsl.configureLinting
 import aws.sdk.kotlin.gradle.util.typedProp
+import org.jetbrains.kotlin.gradle.tasks.KotlinCompile
 
 buildscript {
     // NOTE: buildscript classpath for the root project is the parent classloader for the subprojects, we
@@ -46,6 +47,12 @@ val testJavaVersion = typedProp<String>("test.java.version")?.let {
 }
 
 allprojects {
+    tasks.withType<KotlinCompile> {
+        compilerOptions {
+            allWarningsAsErrors = true
+        }
+    }
+
     if (testJavaVersion != null) {
         tasks.withType<Test> {
             // JDK8 tests fail with out of memory sometimes, not sure why...

codegen/smithy-kotlin-codegen/src/main/kotlin/software/amazon/smithy/kotlin/codegen/rendering/waiters/KotlinJmespathExpressionVisitor.kt

@@ -164,6 +164,7 @@ class KotlinJmespathExpressionVisitor(
 
         val codegen = buildString {
             val nullables = buildList {
+                // FIXME In some cases we are unnecessarily handling nulls here, leading to compiler warnings.
                 if (left.shape?.isNullable == true || left.nullable) add("${left.identifier} == null")
                 if (right.shape?.isNullable == true || right.nullable) add("${right.identifier} == null")
             }

tests/codegen/waiter-tests/build.gradle.kts

@@ -38,6 +38,10 @@ kotlin.sourceSets.getByName("main") {
 
 tasks.withType<org.jetbrains.kotlin.gradle.tasks.KotlinCompile> {
     dependsOn(tasks.generateSmithyProjections)
+    // FIXME Re-enable warnings as errors
+    compilerOptions {
+        allWarningsAsErrors = false
+    }
 }
 
 tasks.test {