chore: string class name to class constant in extension (#742)

Author: shakaran

src/DependencyInjection/SncRedisExtension.php

@@ -142,7 +142,7 @@ private function loadPredisClient(array $client, ContainerBuilder $container): v
         if (is_string($client['options']['connection_persistent'])) {
             $client['options']['persistent'] = true;
             // For predis, use the string value as conn_uid (requires predis >= 2.4.0)
-            if (class_exists('Predis\Client')) {
+            if (class_exists(Client::class)) {
                 if (!version_compare(Client::VERSION, '2.4.0', '>=')) {
                     throw new InvalidConfigurationException(
                         'Using connection_persistent as string for Predis requires predis/predis version 2.4.0 or higher. ' .

tests/DependencyInjection/SncRedisExtensionTest.php

@@ -14,13 +14,21 @@
 namespace Snc\RedisBundle\Tests\DependencyInjection;
 
 use InvalidArgumentException;
+use Monolog\Formatter\LogstashFormatter;
+use Monolog\Handler\RedisHandler;
 use PHPUnit\Framework\TestCase;
 use Predis\Client;
+use Predis\Configuration\Options;
+use Predis\Connection\Parameters;
 use Redis;
 use RedisException;
 use Relay\Relay;
+use Snc\RedisBundle\Client\Predis\Connection\ConnectionFactory;
+use Snc\RedisBundle\Client\Predis\Connection\ConnectionWrapper;
+use Snc\RedisBundle\DataCollector\RedisDataCollector;
 use Snc\RedisBundle\DependencyInjection\Configuration\Configuration;
 use Snc\RedisBundle\DependencyInjection\SncRedisExtension;
+use Snc\RedisBundle\Logger\RedisLogger;
 use Symfony\Component\Config\Definition\Exception\InvalidConfigurationException;
 use Symfony\Component\Config\Definition\Processor;
 use Symfony\Component\Config\FileLocator;
@@ -46,15 +54,15 @@ class SncRedisExtensionTest extends TestCase
     public static function parameterValues(): array
     {
         return [
-            ['snc_redis.client.class', 'Predis\Client'],
+            ['snc_redis.client.class', Client::class],
             ['snc_redis.relay_client.class', Relay::class],
-            ['snc_redis.client_options.class', 'Predis\Configuration\Options'],
-            ['snc_redis.connection_parameters.class', 'Predis\Connection\Parameters'],
-            ['snc_redis.connection_factory.class', 'Snc\RedisBundle\Client\Predis\Connection\ConnectionFactory'],
-            ['snc_redis.connection_wrapper.class', 'Snc\RedisBundle\Client\Predis\Connection\ConnectionWrapper'],
-            ['snc_redis.logger.class', 'Snc\RedisBundle\Logger\RedisLogger'],
-            ['snc_redis.data_collector.class', 'Snc\RedisBundle\DataCollector\RedisDataCollector'],
-            ['snc_redis.monolog_handler.class', 'Monolog\Handler\RedisHandler'],
+            ['snc_redis.client_options.class', Options::class],
+            ['snc_redis.connection_parameters.class', Parameters::class],
+            ['snc_redis.connection_factory.class', ConnectionFactory::class],
+            ['snc_redis.connection_wrapper.class', ConnectionWrapper::class],
+            ['snc_redis.logger.class', RedisLogger::class],
+            ['snc_redis.data_collector.class', RedisDataCollector::class],
+            ['snc_redis.monolog_handler.class', RedisHandler::class],
         ];
     }
 
@@ -193,7 +201,7 @@ public function testMonologFormatterOption(): void
     {
         $container = $this->getContainer();
         //Create a fake formatter definition
-        $container->setDefinition('my_monolog_formatter', new Definition('Monolog\\Formatter\\LogstashFormatter', ['symfony']));
+        $container->setDefinition('my_monolog_formatter', new Definition(LogstashFormatter::class, ['symfony']));
         $extension = new SncRedisExtension();
         $config    = $this->parseYaml($this->getMonologFormatterOptionYamlConfig());
         $extension->load([$config], $container);
@@ -763,7 +771,7 @@ private function getPhpRedisWithInvalidACLYamlMinimalConfig(): string
 
     public function testPredisWithConnectionPersistentBool(): void
     {
-        if (!class_exists('Predis\Client')) {
+        if (!class_exists(Client::class)) {
             $this->markTestSkipped('Predis not available');
         }
 
@@ -783,7 +791,7 @@ public function testPredisWithConnectionPersistentBool(): void
 
     public function testPredisWithConnectionPersistentString(): void
     {
-        if (!class_exists('Predis\Client')) {
+        if (!class_exists(Client::class)) {
             $this->markTestSkipped('Predis not available');
         }
 
@@ -803,7 +811,7 @@ public function testPredisWithConnectionPersistentString(): void
 
     public function testPredisWithConnectionPersistentVersionTooOld(): void
     {
-        if (!class_exists('Predis\Client')) {
+        if (!class_exists(Client::class)) {
             $this->markTestSkipped('Predis not available');
         }
 
@@ -849,7 +857,7 @@ private function getPredisWithConnectionPersistentStringYamlConfig(): string
 
     public function testPredisWithConnectionPersistentFalse(): void
     {
-        if (!class_exists('Predis\Client')) {
+        if (!class_exists(Client::class)) {
             $this->markTestSkipped('Predis not available');
         }