Fix/memory manage improvements (#378)

* chore: .clang-format refactor

* refactor: examples refactoring

* fix: memory management

* fix: fixed small nitpicks

---------

Co-authored-by: Maciej Makowski <maciej.makowski2608@gmail.com>

Author: maciejmakowski2003

apps/common-app/src/examples/DrumMachine/DrumMachine.tsx

@@ -136,7 +136,7 @@ const DrumMachine: React.FC = () => {
           label="BPM"
           step={1}
           min={24}
-          max={320}
+          max={2000}
           value={bpm}
           onValueChange={setBpm}
         />
@@ -148,7 +148,8 @@ const DrumMachine: React.FC = () => {
             // @ts-ignore ???
             width={size}
             height={size}
-            onLayout={onCanvasLayout}>
+            onLayout={onCanvasLayout}
+          >
             <Grid />
             {patterns.map((pattern) => (
               <PatternShape key={pattern.instrumentName} pattern={pattern} />

apps/common-app/src/examples/DrumMachine/constants.ts

@@ -9,7 +9,7 @@ export const padding = 24;
 export const maxSize =
   Math.min(screenSize.width, screenSize.height) - padding * 2;
 
-export const initialBpm = 120;
+export const initialBpm = 240;
 export const numBeats = 16;
 export const noteDensity = 2;
 

apps/common-app/src/utils/usePlayer.tsx

@@ -137,6 +137,7 @@ export default function usePlayer(options: PlayerOptions) {
     }
 
     return () => {
+      playingInstruments.value = getPlayingInstruments();
       audioContext.close();
     };
 

packages/react-native-audio-api/.clang-format

@@ -4,7 +4,7 @@ AlignAfterOpenBracket: AlwaysBreak
 AlignConsecutiveAssignments: false
 AlignConsecutiveDeclarations: false
 AlignEscapedNewlinesLeft: true
-AlignOperands:   false
+AlignOperands: false
 AlignTrailingComments: false
 AllowAllParametersOfDeclarationOnNextLine: false
 AllowShortBlocksOnASingleLine: false
@@ -18,45 +18,45 @@ AlwaysBreakTemplateDeclarations: true
 BinPackArguments: false
 BinPackParameters: false
 BraceWrapping:
-  AfterClass:      false
+  AfterClass: false
   AfterControlStatement: false
-  AfterEnum:       false
-  AfterFunction:   false
-  AfterNamespace:  false
+  AfterEnum: false
+  AfterFunction: false
+  AfterNamespace: false
   AfterObjCDeclaration: false
-  AfterStruct:     false
-  AfterUnion:      false
-  BeforeCatch:     false
-  BeforeElse:      false
-  IndentBraces:    false
+  AfterStruct: false
+  AfterUnion: false
+  BeforeCatch: false
+  BeforeElse: false
+  IndentBraces: false
 BreakBeforeBinaryOperators: None
 BreakBeforeBraces: Attach
 BreakBeforeTernaryOperators: true
 BreakConstructorInitializersBeforeComma: false
 BreakAfterJavaFieldAnnotations: false
 BreakStringLiterals: false
-ColumnLimit:       80
-CommentPragmas:  '^ IWYU pragma:'
+ColumnLimit: 80
+CommentPragmas: '^ IWYU pragma:'
 ConstructorInitializerAllOnOneLineOrOnePerLine: true
 ConstructorInitializerIndentWidth: 4
 ContinuationIndentWidth: 4
 Cpp11BracedListStyle: true
 DerivePointerAlignment: false
-DisableFormat:   false
-ForEachMacros:   [ FOR_EACH_RANGE, FOR_EACH, ]
+DisableFormat: false
+ForEachMacros: [FOR_EACH_RANGE, FOR_EACH]
 IncludeCategories:
-  - Regex:           '^<.*\.h(pp)?>'
-    Priority:        1
-  - Regex:           '^<.*'
-    Priority:        2
-  - Regex:           '.*'
-    Priority:        3
+  - Regex: '^<.*\.h(pp)?>'
+    Priority: 1
+  - Regex: '^<.*'
+    Priority: 2
+  - Regex: '.*'
+    Priority: 3
 IndentCaseLabels: true
-IndentWidth:     2
+IndentWidth: 2
 IndentWrappedFunctionNames: false
 KeepEmptyLinesAtTheStartOfBlocks: false
 MacroBlockBegin: ''
-MacroBlockEnd:   ''
+MacroBlockEnd: ''
 MaxEmptyLinesToKeep: 1
 NamespaceIndentation: None
 ObjCBlockIndentWidth: 2
@@ -69,23 +69,22 @@ PenaltyBreakString: 1000
 PenaltyExcessCharacter: 1000000
 PenaltyReturnTypeOnItsOwnLine: 200
 PointerAlignment: Right
-ReflowComments:  true
-SortIncludes:    true
+ReflowComments: true
+SortIncludes: true
 SpaceAfterCStyleCast: false
 SpaceBeforeAssignmentOperators: true
 SpaceBeforeParens: ControlStatements
 SpaceInEmptyParentheses: false
 SpacesBeforeTrailingComments: 1
-SpacesInAngles:  false
+SpacesInAngles: false
 SpacesInContainerLiterals: true
 SpacesInCStyleCastParentheses: false
 SpacesInParentheses: false
 SpacesInSquareBrackets: false
-Standard:        Cpp11
-TabWidth:        4
-UseTab:          Never
+Standard: Cpp11
+TabWidth: 2
+UseTab: Never
 ---
 Language: ObjC
-ColumnLimit:     120
+ColumnLimit: 120
 BreakBeforeBraces: WebKit
-...

packages/react-native-audio-api/android/src/main/cpp/audioapi/android/core/AudioDecoder.cpp

@@ -36,6 +36,7 @@ std::shared_ptr<AudioBus> AudioDecoder::decodeWithFilePath(
 
   ma_uint64 framesDecoded;
   ma_decoder_read_pcm_frames(&decoder, buffer, totalFrameCount, &framesDecoded);
+
   if (framesDecoded == 0) {
     __android_log_print(ANDROID_LOG_ERROR, "AudioDecoder", "Failed to decode");
 

packages/react-native-audio-api/common/cpp/audioapi/core/AudioNode.cpp

@@ -12,7 +12,9 @@ AudioNode::AudioNode(BaseAudioContext *context) : context_(context) {
 }
 
 AudioNode::~AudioNode() {
-  isInitialized_ = false;
+  if (isInitialized_) {
+    cleanup();
+  }
 }
 
 int AudioNode::getNumberOfInputs() const {
@@ -41,8 +43,9 @@ void AudioNode::connect(const std::shared_ptr<AudioNode> &node) {
 }
 
 void AudioNode::disconnect() {
-  for (auto &outputNode : outputNodes_) {
-    disconnect(outputNode);
+  for (auto it = outputNodes_.begin(), end = outputNodes_.end(); it != end;
+       ++it) {
+    disconnect(*it);
   }
 }
 
@@ -56,18 +59,28 @@ bool AudioNode::isEnabled() const {
 }
 
 void AudioNode::enable() {
+  if (isEnabled()) {
+    return;
+  }
+
   isEnabled_ = true;
 
-  for (auto &outputNode : outputNodes_) {
-    outputNode->onInputEnabled();
+  for (auto it = outputNodes_.begin(), end = outputNodes_.end(); it != end;
+       ++it) {
+    it->get()->onInputEnabled();
   }
 }
 
 void AudioNode::disable() {
+  if (!isEnabled()) {
+    return;
+  }
+
   isEnabled_ = false;
 
-  for (auto &outputNode : outputNodes_) {
-    outputNode->onInputDisabled();
+  for (auto it = outputNodes_.begin(), end = outputNodes_.end(); it != end;
+       ++it) {
+    it->get()->onInputDisabled();
   }
 }
 
@@ -96,7 +109,7 @@ std::string AudioNode::toString(ChannelInterpretation interpretation) {
 }
 
 std::shared_ptr<AudioBus> AudioNode::processAudio(
-    std::shared_ptr<AudioBus> outputBus,
+    const std::shared_ptr<AudioBus> &outputBus,
     int framesToProcess,
     bool checkIsAlreadyProcessed) {
   if (!isInitialized_) {
@@ -148,7 +161,9 @@ std::shared_ptr<AudioBus> AudioNode::processInputs(
   processingBus->zero();
 
   int maxNumberOfChannels = 0;
-  for (auto inputNode : inputNodes_) {
+  for (auto it = inputNodes_.begin(), end = inputNodes_.end(); it != end;
+       ++it) {
+    auto inputNode = *it;
     assert(inputNode != nullptr);
 
     if (!inputNode->isEnabled()) {
@@ -169,7 +184,7 @@ std::shared_ptr<AudioBus> AudioNode::processInputs(
 }
 
 std::shared_ptr<AudioBus> AudioNode::applyChannelCountMode(
-    std::shared_ptr<AudioBus> processingBus) {
+    const std::shared_ptr<AudioBus> &processingBus) {
   // If the channelCountMode is EXPLICIT, the node should output the number of
   // channels specified by the channelCount.
   if (channelCountMode_ == ChannelCountMode::EXPLICIT) {
@@ -189,21 +204,25 @@ std::shared_ptr<AudioBus> AudioNode::applyChannelCountMode(
 void AudioNode::mixInputsBuses(const std::shared_ptr<AudioBus> &processingBus) {
   assert(processingBus != nullptr);
 
-  for (const auto &inputBus : inputBuses_) {
-    processingBus->sum(inputBus.get(), channelInterpretation_);
+  for (auto it = inputBuses_.begin(), end = inputBuses_.end(); it != end;
+       ++it) {
+    processingBus->sum(it->get(), channelInterpretation_);
   }
 
   inputBuses_.clear();
 }
 
 void AudioNode::connectNode(const std::shared_ptr<AudioNode> &node) {
-  outputNodes_.insert(node);
-  node->onInputConnected(this);
+  auto position = outputNodes_.find(node);
+
+  if (position == outputNodes_.end()) {
+    outputNodes_.insert(node);
+    node->onInputConnected(this);
+  }
 }
 
 void AudioNode::disconnectNode(const std::shared_ptr<AudioNode> &node) {
   outputNodes_.erase(node);
-  node->onInputDisconnected(this);
 }
 
 void AudioNode::onInputEnabled() {
@@ -239,30 +258,26 @@ void AudioNode::onInputDisconnected(AudioNode *node) {
     return;
   }
 
-  inputNodes_.erase(node);
+  if (node->isEnabled()) {
+    onInputDisabled();
+  }
 
-  if (isEnabled()) {
-    node->onInputDisabled();
+  auto position = inputNodes_.find(node);
+
+  if (position != inputNodes_.end()) {
+    inputNodes_.erase(position);
   }
 }
 
 void AudioNode::cleanup() {
   isInitialized_ = false;
 
-  for (const auto &inputNode : inputNodes_) {
-    if (inputNode) {
-      inputNode->disconnectNode(shared_from_this());
-    }
-  }
-
-  for (const auto &outputNode : outputNodes_) {
-    if (outputNode) {
-      outputNode->onInputDisconnected(this);
-    }
+  for (auto it = outputNodes_.begin(), end = outputNodes_.end(); it != end;
+       ++it) {
+    it->get()->onInputDisconnected(this);
   }
 
   outputNodes_.clear();
-  inputNodes_.clear();
 }
 
 } // namespace audioapi

packages/react-native-audio-api/common/cpp/audioapi/core/AudioNode.h

@@ -58,19 +58,17 @@ class AudioNode : public std::enable_shared_from_this<AudioNode> {
   std::size_t lastRenderedFrame_{SIZE_MAX};
 
  private:
-  friend class StretcherNode;
-
   std::vector<std::shared_ptr<AudioBus>> inputBuses_ = {};
 
   static std::string toString(ChannelCountMode mode);
   static std::string toString(ChannelInterpretation interpretation);
 
-  virtual std::shared_ptr<AudioBus> processAudio(std::shared_ptr<AudioBus> outputBus, int framesToProcess, bool checkIsAlreadyProcessed);
+  virtual std::shared_ptr<AudioBus> processAudio(const std::shared_ptr<AudioBus> &outputBus, int framesToProcess, bool checkIsAlreadyProcessed);
   virtual void processNode(const std::shared_ptr<AudioBus>&, int) = 0;
 
   bool isAlreadyProcessed();
   std::shared_ptr<AudioBus> processInputs(const std::shared_ptr<AudioBus>& outputBus, int framesToProcess, bool checkIsAlreadyProcessed);
-  std::shared_ptr<AudioBus> applyChannelCountMode(std::shared_ptr<AudioBus> processingBus);
+  std::shared_ptr<AudioBus> applyChannelCountMode(const std::shared_ptr<AudioBus> &processingBus);
   void mixInputsBuses(const std::shared_ptr<AudioBus>& processingBus);
 
   void connectNode(const std::shared_ptr<AudioNode> &node);

packages/react-native-audio-api/common/cpp/audioapi/core/effects/PeriodicWave.cpp

@@ -72,6 +72,7 @@ PeriodicWave::~PeriodicWave() {
     delete[] bandLimitedTables_[i];
   }
   delete[] bandLimitedTables_;
+  bandLimitedTables_ = nullptr;
 }
 
 int PeriodicWave::getPeriodicWaveSize() const {

packages/react-native-audio-api/common/cpp/audioapi/core/sources/AudioBufferSourceNode.cpp

@@ -144,24 +144,23 @@ std::mutex &AudioBufferSourceNode::getBufferLock() {
 void AudioBufferSourceNode::processNode(
     const std::shared_ptr<AudioBus> &processingBus,
     int framesToProcess) {
-  if (!Locker::tryLock(getBufferLock())) {
-    processingBus->zero();
-    return;
-  }
+  if (auto locker = Locker::tryLock(getBufferLock())) {
+    // No audio data to fill, zero the output and return.
+    if (!alignedBus_) {
+      processingBus->zero();
+      return;
+    }
 
-  // No audio data to fill, zero the output and return.
-  if (!alignedBus_) {
-    processingBus->zero();
-    return;
-  }
+    if (!pitchCorrection_) {
+      processWithoutPitchCorrection(processingBus, framesToProcess);
+    } else {
+      processWithPitchCorrection(processingBus, framesToProcess);
+    }
 
-  if (!pitchCorrection_) {
-    processWithoutPitchCorrection(processingBus, framesToProcess);
+    handleStopScheduled();
   } else {
-    processWithPitchCorrection(processingBus, framesToProcess);
+    processingBus->zero();
   }
-
-  handleStopScheduled();
 }
 
 double AudioBufferSourceNode::getStopTime() const {

packages/react-native-audio-api/common/cpp/audioapi/core/sources/OscillatorNode.cpp

@@ -16,6 +16,7 @@ OscillatorNode::OscillatorNode(BaseAudioContext *context)
       1200 * LOG2_MOST_POSITIVE_SINGLE_FLOAT);
   type_ = OscillatorType::SINE;
   periodicWave_ = context_->getBasicWaveForm(type_);
+
   isInitialized_ = true;
 }