feat: added errror handling to BaseAudioContext

Author: Maciej Makowski

packages/react-native-audio-api/common/cpp/core/BiquadFilterNode.cpp

@@ -83,10 +83,6 @@ void BiquadFilterNode::getFrequencyResponse(
   }
 }
 
-float BiquadFilterNode::clamp(float value, float min, float max) {
-  return std::min(std::max(value, min), max);
-}
-
 void BiquadFilterNode::resetCoefficients() {
   x1_ = 0.0;
   x2_ = 0.0;
@@ -110,7 +106,7 @@ void BiquadFilterNode::setNormalizedCoefficients(
 }
 
 void BiquadFilterNode::setLowpassCoefficients(float frequency, float Q) {
-  frequency = clamp(frequency, 0.0, 1.0);
+  frequency = std::clamp(frequency, 0.0f, 1.0f);
   if (frequency == 1.0) {
     setNormalizedCoefficients(1.0f, 0.0f, 0.0f, 1.0f, 0.0f, 0.0f);
     return;
@@ -133,7 +129,7 @@ void BiquadFilterNode::setLowpassCoefficients(float frequency, float Q) {
 }
 
 void BiquadFilterNode::setHighpassCoefficients(float frequency, float Q) {
-  frequency = clamp(frequency, 0.0, 1.0);
+  frequency = std::clamp(frequency, 0.0f, 1.0f);
   if (frequency == 1.0) {
     setNormalizedCoefficients(0.0f, 0.0f, 0.0f, 1.0f, 0.0f, 0.0f);
     return;
@@ -156,7 +152,7 @@ void BiquadFilterNode::setHighpassCoefficients(float frequency, float Q) {
 }
 
 void BiquadFilterNode::setBandpassCoefficients(float frequency, float Q) {
-  frequency = clamp(frequency, 0.0, 1.0);
+  frequency = std::clamp(frequency, 0.0f, 1.0f);
   Q = std::max(0.0f, Q);
 
   if (frequency <= 0.0 || frequency >= 1.0) {
@@ -178,7 +174,7 @@ void BiquadFilterNode::setBandpassCoefficients(float frequency, float Q) {
 }
 
 void BiquadFilterNode::setLowshelfCoefficients(float frequency, float gain) {
-  frequency = clamp(frequency, 0.0, 1.0);
+  frequency = std::clamp(frequency, 0.0f, 1.0f);
   float A = std::pow(10.0f, gain / 40.0f);
 
   if (frequency == 1.0) {
@@ -207,7 +203,7 @@ void BiquadFilterNode::setLowshelfCoefficients(float frequency, float gain) {
 }
 
 void BiquadFilterNode::setHighshelfCoefficients(float frequency, float gain) {
-  frequency = clamp(frequency, 0.0, 1.0);
+  frequency = std::clamp(frequency, 0.0f, 1.0f);
   float A = std::pow(10.0f, gain / 40.0f);
 
   if (frequency == 1.0) {
@@ -239,7 +235,7 @@ void BiquadFilterNode::setPeakingCoefficients(
     float frequency,
     float Q,
     float gain) {
-  frequency = clamp(frequency, 0.0, 1.0);
+  frequency = std::clamp(frequency, 0.0f, 1.0f);
   Q = std::max(0.0f, Q);
   float A = std::pow(10.0f, gain / 40.0f);
 
@@ -267,7 +263,7 @@ void BiquadFilterNode::setPeakingCoefficients(
 }
 
 void BiquadFilterNode::setNotchCoefficients(float frequency, float Q) {
-  frequency = clamp(frequency, 0.0, 1.0);
+  frequency = std::clamp(frequency, 0.0f, 1.0f);
   Q = std::max(0.0f, Q);
 
   if (frequency <= 0.0 || frequency >= 1.0) {
@@ -288,7 +284,7 @@ void BiquadFilterNode::setNotchCoefficients(float frequency, float Q) {
 }
 
 void BiquadFilterNode::setAllpassCoefficients(float frequency, float Q) {
-  frequency = clamp(frequency, 0.0, 1.0);
+  frequency = std::clamp(frequency, 0.0f, 1.0f);
   Q = std::max(0.0f, Q);
 
   if (frequency <= 0.0 || frequency >= 1.0) {

packages/react-native-audio-api/common/cpp/core/BiquadFilterNode.h

@@ -111,7 +111,6 @@ class BiquadFilterNode : public AudioNode {
   float a1_ = 1.0;
   float a2_ = 0;
 
-  static float clamp(float value, float min, float max);
   void resetCoefficients();
   void setNormalizedCoefficients(
       float b0,

packages/react-native-audio-api/src/core/BaseAudioContext.ts

@@ -7,6 +7,7 @@ import StereoPannerNode from './StereoPannerNode';
 import BiquadFilterNode from './BiquadFilterNode';
 import AudioBufferSourceNode from './AudioBufferSourceNode';
 import AudioBuffer from './AudioBuffer';
+import { RangeError } from '../errors';
 
 export default class BaseAudioContext {
   readonly destination: AudioDestinationNode;
@@ -52,11 +53,21 @@ export default class BaseAudioContext {
     length: number,
     sampleRate: number
   ): AudioBuffer {
-    if (numOfChannels !== 1 && numOfChannels !== 2) {
-      throw new Error(
-        'The number of channels provided (' +
-          numOfChannels +
-          ') is outside the range [1, 32]'
+    if (numOfChannels < 1 || numOfChannels > 3) {
+      throw new RangeError(
+        `The number of channels provided (${numOfChannels}) is outside the range [1, 2]`
+      );
+    }
+
+    if (length <= 0) {
+      throw new RangeError(
+        `The number of frames provided (${length}) is less than or equal to the minimum bound (0)`
+      );
+    }
+
+    if (sampleRate <= 0) {
+      throw new RangeError(
+        `The sample rate provided (${sampleRate}) is outside the range [3000, 768000]`
       );
     }