Skip to content

Commit e36f796

Browse files
author
Maciej Makowski
committed
fix: override onEnded in ABSN
1 parent 06ed38b commit e36f796

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed

packages/react-native-audio-api/src/core/AudioBufferSourceNode.ts

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import { IAudioBufferSourceNode } from '../interfaces';
22
import AudioBufferBaseSourceNode from './AudioBufferBaseSourceNode';
33
import AudioBuffer from './AudioBuffer';
44
import { InvalidStateError, RangeError } from '../errors';
5+
import { EventEmptyType } from '../events/types';
56

67
export default class AudioBufferSourceNode extends AudioBufferBaseSourceNode {
78
public get buffer(): AudioBuffer | null {
@@ -79,4 +80,14 @@ export default class AudioBufferSourceNode extends AudioBufferBaseSourceNode {
7980
this.hasBeenStarted = true;
8081
(this.node as IAudioBufferSourceNode).start(when, offset, duration);
8182
}
83+
84+
public override get onEnded(): ((event: EventEmptyType) => void) | undefined {
85+
return super.onEnded as ((event: EventEmptyType) => void) | undefined;
86+
}
87+
88+
public override set onEnded(
89+
callback: ((event: EventEmptyType) => void) | null
90+
) {
91+
super.onEnded = callback;
92+
}
8293
}

packages/react-native-audio-api/src/events/types.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ type SystemEvents = RemoteCommandEvents & {
4444
routeChange: OnRouteChangeEventType;
4545
};
4646

47-
export interface OnEndedEventType {
47+
export interface OnEndedEventType extends EventEmptyType {
4848
bufferId: string | undefined;
4949
}
5050

0 commit comments

Comments
 (0)