refactor(chore): fix sonarqube issues (#2306)

* refactor(chore): fix sonarqube issues

GH-2302

* refactor(chore): fix sonarqube issues

GH-2302

* refactor(chore): fix sonarqube issues

GH-2302

* refactor(chore): fix sonarqube issues

GH-2302

---------

Co-authored-by: Vaibhav  Bhalla <vaibhav.bhalla@SFSupports-MacBook-Air.local>
Co-authored-by: a-ganguly <abir.ganguly@sourcefuse.com>

Author: 3 people

.czferc.js

@@ -100,7 +100,7 @@ module.exports = {
         message:
           'List any ISSUES CLOSED by this change (optional). E.g.: #31, #34:\n',
         filter: (input, answers) => {
-          return input.replace(/^\#/g, 'gh-');
+          return input.replace(/^#/g, 'gh-');
         },
       },
       {
@@ -164,7 +164,7 @@ function getMigrationChanges(staged) {
     .filter(f => f && f.length > 0);
   let timestamps = {};
   for (let item of migrationPaths) {
-    let match = item.match(/[0-9]{14}/g);
+    let match = item.match(/\d{14}/g);
     if (match && match[0]) {
       timestamps[match[0]] = [...(timestamps[match[0]] || []), item];
     }

packages/cli/src/commands/mcp.ts

@@ -91,9 +91,7 @@ export class Mcp extends Base<{}> {
         command.name,
         command.mcpDescription,
         params,
-        async args => {
-          return command.mcpRun(args as Record<string, AnyObject[string]>);
-        },
+        async args => command.mcpRun(args as Record<string, AnyObject[string]>),
       );
     });
   }
@@ -116,10 +114,13 @@ export class Mcp extends Base<{}> {
           timestamp: new Date().toISOString(),
         })
         .catch(err => {
+          // sonarignore:start
           console.error('Error sending exit message:', err);
+          // sonarignore:end
         });
       return undefined as never;
     };
+    // sonarignore:start
     const original = console.error;
     console.error = (...args: AnyObject[]) => {
       // log errors to the MCP client
@@ -135,6 +136,7 @@ export class Mcp extends Base<{}> {
       original(...args);
     };
     console.log = (...args: AnyObject[]) => {
+      // sonarignore:end
       // log messages to the MCP client
       this.server.server
         .sendLoggingMessage({
@@ -143,7 +145,9 @@ export class Mcp extends Base<{}> {
           timestamp: new Date().toISOString(),
         })
         .catch(err => {
+          // sonarignores:start
           console.error('Error sending logging message:', err);
+          // sonarignore:end
         });
     };
   }
@@ -156,27 +160,35 @@ export class Mcp extends Base<{}> {
   private flagToZod<T>(flag: IFlag<T>, checkRequired = false) {
     let option;
     let description = flag.description ?? '';
-    switch (true) {
-      case flag.type === 'boolean':
-        option = z.boolean().optional();
-        option = option.default((flag.default as boolean) ?? false);
-        break;
-      case this._isOptionFlag(flag) && flag.options !== undefined: {
-        // typescript is not able to infer type
-        const typedFlag = flag as IOptionFlag<T>;
-        option = z.enum(typedFlag.options as [string, ...string[]]);
-        description += ` (options: ${typedFlag.options?.join(', ')})`;
-        break;
-      }
-      case this._isOptionFlag(flag) && flag.options === undefined:
-        option = z.string().optional();
-        break;
-      default:
-        throw new Error(
-          `Unsupported flag type: ${flag.type}. Supported types are boolean, option, enum, and integer.`,
-        );
+
+    if (flag.type === 'boolean') {
+      option = z.boolean().optional();
+      option = option.default((flag.default as boolean) ?? false);
+      return this._describeOption(option, description, flag, checkRequired);
+    }
+    if (!this._isOptionFlag(flag)) {
+      throw new Error(
+        'Unsupported flag type. Supported types are boolean, option, enum, and integer.',
+      );
     }
 
+    const optionFlag = flag as IOptionFlag<T>;
+    if (optionFlag.options !== undefined) {
+      option = z.enum(optionFlag.options as [string, ...string[]]);
+      description += ` (options: ${optionFlag.options?.join(', ')})`;
+      return this._describeOption(option, description, flag, checkRequired);
+    } else {
+      option = z.string().optional();
+      return this._describeOption(option, description, flag, checkRequired);
+    }
+  }
+
+  private _describeOption<T>(
+    option: z.ZodTypeAny,
+    description: string,
+    flag: IFlag<T>,
+    checkRequired: boolean,
+  ) {
     if (flag.dependsOn) {
       description += ` (required if ${flag.dependsOn.join(', ')} ${flag.dependsOn.length > 1 ? 'are' : 'is'} provided)`;
       option = option.optional();

packages/cli/src/generators/scaffold/index.ts

@@ -62,7 +62,7 @@ export default class ScaffoldGenerator extends BaseGenerator<ScaffoldOptions> {
         },
       );
     } catch (error) {
-      this.log(chalk.cyan(`Error while adding jenkinsfile{error.message}`));
+      this.log(chalk.cyan(`Error while adding jenkinsfile ${error}`));
     }
   }
   async install() {

packages/cli/src/types.ts

@@ -85,7 +85,7 @@ export type CommandTestCase = {
 export type ICommandWithMcpFlags = {
   mcpFlags?: Record<string, IFlag<AnyObject[string]>>;
   args?: IArg[];
-  flags?: Record<string, IFlag<AnyObject[string]>> | undefined;
+  flags?: Record<string, IFlag<AnyObject[string]>>;
   name: string;
   mcpDescription: string;
   mcpRun: (args: Record<string, AnyObject[string]>) => Promise<McpTextResponse>;

packages/core/src/casbin-secure-sequence.ts

@@ -42,7 +42,10 @@ const SequenceActions = RestBindings.SequenceActions;
 const isJsonString = (str: string) => {
   try {
     JSON.parse(str);
-  } catch (_) {
+  } catch (error) {
+    // sonarignore:start
+    console.error('Invalid JSON string', error);
+    // sonarignore:end
     return false;
   }
   return true;

packages/core/src/mixins/booter.mixin.ts

@@ -24,6 +24,7 @@ const KEY_LENGTH = 5;
  * @param basePath The base path to be used as `projectRoot`
  * @param defaultOptions Default options to merge with user config
  */
+// sonarignore-next-line
 export function BooterBasePathMixin<T extends Constructor<Booter>>(
   booterClass: T,
   basePath: string,

packages/core/src/secure-sequence.ts

@@ -41,7 +41,10 @@ const SequenceActions = RestBindings.SequenceActions;
 const isJsonString = (str: string) => {
   try {
     JSON.parse(str);
-  } catch (_) {
+  } catch (error) {
+    // sonarignore:start
+    console.error('Invalid JSON string', error);
+    // sonarignore:ends
     return false;
   }
   return true;

packages/core/src/service-sequence.ts

@@ -36,7 +36,10 @@ const SequenceActions = RestBindings.SequenceActions;
 const isJsonString = (str: string) => {
   try {
     JSON.parse(str);
-  } catch (_) {
+  } catch (error) {
+    // sonarignore:start
+    console.error('Invalid JSON string', error);
+    // sonarignore:end
     return false;
   }
   return true;

sandbox/auth-multitenant-example/migration.js

@@ -10,7 +10,7 @@ try {
     isLocal = true;
   }
 } catch (err) {
-  console.info('\n');
+  console.error('Error while checking for .infolder:', err);
 }
 if (isLocal) {
   console.info(`Skipping migrations`);

sandbox/telemed-app/backend/authentication-service/cdk/.gen/modules/redis.ts

@@ -13,6 +13,7 @@ To get more info see https://registry.terraform.io/providers/hashicorp/aws/lates
 
    * @default 
    */
+  // sonarignore-next-line
   readonly additionalSecurityGroupRules?: any[];
   /**
    * Additional key-value pairs to add to each map in `tags_as_list_of_maps`. Not added to `tags` or `id`.
@@ -136,6 +137,7 @@ except for attributes, tags, and additional_tag_map, which are merged.
 
    * @default [object Object]
    */
+  // sonarignore-next-line
   readonly context?: any;
   /**
    * Set `true` to create and configure a new security group. If false, `associated_security_group_ids` must be provided.
@@ -172,6 +174,7 @@ Default is `{}` (`descriptors` output will be empty).
 
    * @default [object Object]
    */
+  // sonarignore-next-line
   readonly descriptorFormats?: any;
   /**
    * The subdomain to use for the CNAME record. If not provided then the CNAME record will use var.name.
@@ -183,6 +186,7 @@ Historical description: Outbound traffic address.
 Historical default: ["0.0.0.0/0"]
 
    */
+  // sonarignore-next-line
   readonly egressCidrBlocks?: any[];
   /**
    * Subnet group name for the ElastiCache instance
@@ -278,6 +282,7 @@ Set to `[]` to suppress all generated tags.
    * @default
    * The property type contains a map, they have special handling, please see {@link cdk.tf/module-map-inputs the docs}
    */
+  // sonarignore-next-line
   readonly logDeliveryConfiguration?: {[key: string]: any}[];
   /**
    * Maintenance window
@@ -312,6 +317,7 @@ The "name" tag is set to the full `id` string. There is no tag with the value of
    * A list of Redis parameters to apply. Note that parameters may differ from one Redis family to another
    * @default
    */
+  // sonarignore-next-line
   readonly parameter?: any;
   /**
    * Managed by Terraform
@@ -441,9 +447,11 @@ Can also be a plain string, but that use is DEPRECATED because of Terraform issu
 
    * @default 
    */
+  // sonarignore-next-line
   readonly zoneId?: any;
 }
 export class Redis extends TerraformModule {
+  // sonarignore-next-line
   private readonly inputs: {[name: string]: any} = {};
   public constructor(scope: Construct, id: string, config: RedisConfig) {
     super(scope, id, {