Skip to content

Commit 8c288d8

Browse files
committed
chore(all-services): rebase
gh-1778
1 parent 6572dcb commit 8c288d8

File tree

10 files changed

+43
-32
lines changed

10 files changed

+43
-32
lines changed

packages/archival/src/aws-s3/import-archive-data.provider.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ import {
66
} from '@loopback/core';
77
import {AnyObject} from '@loopback/repository';
88
import {HttpErrors} from '@loopback/rest';
9-
// eslint-disable-next-line @typescript-eslint/naming-convention
109
import AWS from 'aws-sdk';
1110
import {ImportDataExternalSystem} from '../types';
1211

packages/archival/src/component.ts

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,14 @@ import {Class, Repository} from '@loopback/repository';
1414
import {Model, RestApplication} from '@loopback/rest';
1515
import {CoreComponent} from '@sourceloop/core';
1616
import {ArchivalComponentBindings} from './keys';
17-
import {GetJobDetailsProvider, ProcessImportedDataProvider} from './providers';
18-
import {ArchivalMappingRepository, JobDetailsRepository} from './repositories';
17+
import {
18+
ProcessRetrievedDataProvider,
19+
RetrieveArchivedDataProvider,
20+
} from './providers';
21+
import {
22+
ArchivalMappingRepository,
23+
RetrievalJobDetailsRepository,
24+
} from './repositories';
1925
import {BuildWhereConditionService} from './services';
2026
import {ImportArchivedDataService} from './services/import-archived-data.service';
2127
import {ArchivalComponentOptions, DEFAULT_ARCHIVAL_OPTIONS} from './types';
@@ -33,9 +39,9 @@ export class ArchivalComponent implements Component {
3339
this.application.component(CoreComponent);
3440

3541
this.providers[ArchivalComponentBindings.PROCESS_IMPORT_DATA.key] =
36-
ProcessImportedDataProvider;
42+
ProcessRetrievedDataProvider;
3743
this.providers[ArchivalComponentBindings.GET_ARCHIVED_DATA_JOB.key] =
38-
GetJobDetailsProvider;
44+
RetrieveArchivedDataProvider;
3945

4046
this.application
4147
.bind('services.BuildWhereConditionService')
@@ -44,7 +50,10 @@ export class ArchivalComponent implements Component {
4450
.bind('services.ImportArchivedDataService')
4551
.toClass(ImportArchivedDataService);
4652

47-
this.repositories = [ArchivalMappingRepository, JobDetailsRepository];
53+
this.repositories = [
54+
ArchivalMappingRepository,
55+
RetrievalJobDetailsRepository,
56+
];
4857
}
4958
providers?: ProviderMap = {};
5059

packages/archival/src/models/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
export * from './archival-mapping.model';
2-
export * from './job-details.model';
2+
export * from './retrieval-job-details.model';

packages/archival/src/models/job-details.model.ts renamed to packages/archival/src/models/retrieval-job-details.model.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,12 @@ import {CoreEntity} from '@sourceloop/core';
33
import {JobStatus} from '../types';
44

55
@model({
6-
name: 'job_details',
6+
name: 'retrieval_job_details',
77
settings: {
88
strict: false,
99
},
1010
})
11-
export class JobDetails extends CoreEntity<JobDetails> {
11+
export class RetrievalJobDetails extends CoreEntity<RetrievalJobDetails> {
1212
@property({
1313
type: 'string',
1414
id: true,
@@ -26,10 +26,10 @@ export class JobDetails extends CoreEntity<JobDetails> {
2626
status: JobStatus;
2727

2828
@property({
29-
name: 'filter_inquired',
29+
name: 'filter',
3030
type: 'object',
3131
})
32-
filterInquired: Object;
32+
filter: Object;
3333

3434
@property({
3535
name: 'entity',
@@ -43,4 +43,4 @@ export class JobDetails extends CoreEntity<JobDetails> {
4343
result: string;
4444
}
4545

46-
export type JobDetailsWithRelations = JobDetails;
46+
export type RetrievalJobDetailsWithRelations = RetrievalJobDetails;
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
export * from './get-job-details.provider';
2-
export * from './process-import-data.provider';
1+
export * from './process-retrieved-data.provider';
2+
export * from './retrieve-archived-data.provider';

packages/archival/src/providers/process-import-data.provider.ts renamed to packages/archival/src/providers/process-retrieved-data.provider.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import {
77
import {ProcessImportedData} from '../types';
88

99
@injectable({scope: BindingScope.TRANSIENT})
10-
export class ProcessImportedDataProvider
10+
export class ProcessRetrievedDataProvider
1111
implements Provider<ProcessImportedData>
1212
{
1313
/**Implement this provider to process and save the records do desired system

packages/archival/src/providers/get-job-details.provider.ts renamed to packages/archival/src/providers/retrieve-archived-data.provider.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,22 +5,22 @@ import {
55
injectable,
66
} from '@loopback/core';
77
import {Filter, repository} from '@loopback/repository';
8-
import {JobDetails} from '../models';
9-
import {JobDetailsRepository} from '../repositories';
8+
import {RetrievalJobDetails} from '../models';
9+
import {RetrievalJobDetailsRepository} from '../repositories';
1010
import {GetJobDetailsFn, JobResponse, JobStatus} from '../types';
1111

1212
@injectable({scope: BindingScope.TRANSIENT})
13-
export class GetJobDetailsProvider implements Provider<GetJobDetailsFn> {
13+
export class RetrieveArchivedDataProvider implements Provider<GetJobDetailsFn> {
1414
constructor(
15-
@repository(JobDetailsRepository)
16-
public jobDetailsRepo: JobDetailsRepository,
15+
@repository(RetrievalJobDetailsRepository)
16+
public jobDetailsRepo: RetrievalJobDetailsRepository,
1717
) {}
1818
value(): ValueOrPromise<GetJobDetailsFn> {
1919
return async (entityName: string, filter?: Filter) => {
2020
let jobResponse: JobResponse = {jobId: '0'};
21-
const job = new JobDetails({
21+
const job = new RetrievalJobDetails({
2222
status: JobStatus.IN_PROGRESS,
23-
filterInquired: filter,
23+
filter,
2424
entity: entityName,
2525
});
2626

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
export * from './archival-mapping.repository';
2-
export * from './job-details.repository';
2+
export * from './retrieval-job-details.repository';
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
11
import {inject} from '@loopback/core';
22
import {DefaultCrudRepository, juggler} from '@loopback/repository';
33

4-
import {JobDetails} from '../models';
4+
import {RetrievalJobDetails} from '../models';
55
import {ArchivalDbSourceName} from '../types';
66

7-
export class JobDetailsRepository extends DefaultCrudRepository<
8-
JobDetails,
9-
typeof JobDetails.prototype.id
7+
export class RetrievalJobDetailsRepository extends DefaultCrudRepository<
8+
RetrievalJobDetails,
9+
typeof RetrievalJobDetails.prototype.id
1010
> {
1111
constructor(
1212
@inject(`datasources.${ArchivalDbSourceName}`)
1313
dataSource: juggler.DataSource,
1414
) {
15-
super(JobDetails, dataSource);
15+
super(RetrievalJobDetails, dataSource);
1616
}
1717
}

packages/archival/src/services/import-archived-data.service.ts

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,10 @@ import {DefaultUserModifyCrudRepository} from '@sourceloop/core';
1818
import {ArchivalApplication} from '../application';
1919
import {ArchivalComponentBindings} from '../keys';
2020
import {ArchiveMapping} from '../models';
21-
import {ArchivalMappingRepository, JobDetailsRepository} from '../repositories';
21+
import {
22+
ArchivalMappingRepository,
23+
RetrievalJobDetailsRepository,
24+
} from '../repositories';
2225
import {
2326
IBuildWhereConditionService,
2427
ImportDataExternalSystem,
@@ -31,8 +34,8 @@ export class ImportArchivedDataService {
3134
// eslint-disable-next-line @typescript-eslint/no-explicit-any
3235
repo: any; //NOSONAR
3336
constructor(
34-
@repository(JobDetailsRepository)
35-
public jobDetailsRepo: JobDetailsRepository,
37+
@repository(RetrievalJobDetailsRepository)
38+
public jobDetailsRepo: RetrievalJobDetailsRepository,
3639
@repository(ArchivalMappingRepository)
3740
public archivalMappingRepo: ArchivalMappingRepository,
3841
@inject(CoreBindings.APPLICATION_INSTANCE)
@@ -59,7 +62,7 @@ export class ImportArchivedDataService {
5962
async import(jobId: string) {
6063
const jobDetails = await this.jobDetailsRepo.findById(jobId);
6164
const modelName = jobDetails.entity;
62-
const filter = jobDetails.filterInquired;
65+
const filter = jobDetails.filter;
6366

6467
const archiveFilter: Filter<ArchiveMapping> =
6568
await this.buildWhereConditionService.buildConditionForFetch(

0 commit comments

Comments
 (0)