Merge pull request #547 from specklesystems/dimitrie/cnx-1086-stuck-at-publish-when-trying-to-publish-not-supported-array

fix/feat: adds support for arrays (radial and linear) in revit

Author: didimitrie

Connectors/Revit/Speckle.Connectors.RevitShared/HostApp/ElementUnpacker.cs

@@ -64,6 +64,13 @@ private List<Element> UnpackElements(IEnumerable<Element> elements)
         var groupElements = g.GetMemberIds().Select(doc.GetElement);
         unpackedElements.AddRange(UnpackElements(groupElements));
       }
+      else if (element is BaseArray baseArray)
+      {
+        var arrayElements = baseArray.GetCopiedMemberIds().Select(doc.GetElement);
+        var originalElements = baseArray.GetOriginalMemberIds().Select(doc.GetElement);
+        unpackedElements.AddRange(UnpackElements(arrayElements));
+        unpackedElements.AddRange(UnpackElements(originalElements));
+      }
       // UNPACK: Family instances (as they potentially have nested families inside)
       else if (element is FamilyInstance familyInstance)
       {

Connectors/Revit/Speckle.Connectors.RevitShared/Operations/Send/RevitRootObjectBuilder.cs

@@ -63,20 +63,6 @@ CancellationToken cancellationToken
         continue;
       }
 
-      if (!SupportedCategoriesUtils.IsSupportedCategory(el.Category))
-      {
-        results.Add(
-          new(
-            Status.WARNING,
-            el.UniqueId,
-            el.Category.Name,
-            null,
-            new SpeckleException($"Category {el.Category.Name} is not supported.")
-          )
-        );
-        continue;
-      }
-
       revitElements.Add(el);
     }
 
@@ -98,6 +84,20 @@ CancellationToken cancellationToken
       string sourceType = revitElement.GetType().Name;
       try
       {
+        if (!SupportedCategoriesUtils.IsSupportedCategory(revitElement.Category))
+        {
+          results.Add(
+            new(
+              Status.WARNING,
+              revitElement.UniqueId,
+              revitElement.Category.Name,
+              null,
+              new SpeckleException($"Category {revitElement.Category.Name} is not supported.")
+            )
+          );
+          continue;
+        }
+
         Base converted;
         if (sendConversionCache.TryGetValue(sendInfo.ProjectId, applicationId, out ObjectReference? value))
         {