batcher: register blockifier metrics

Author: Yonatan-Starkware

crates/apollo_batcher/src/metrics.rs

@@ -1,5 +1,13 @@
 use apollo_batcher_types::communication::BATCHER_REQUEST_LABELS;
 use apollo_metrics::define_metrics;
+use blockifier::metrics::{
+    CALLS_RUNNING_NATIVE,
+    CLASS_CACHE_HITS,
+    CLASS_CACHE_MISSES,
+    NATIVE_CLASS_RETURNED,
+    NATIVE_COMPILATION_ERROR,
+    TOTAL_CALLS,
+};
 use starknet_api::block::BlockNumber;
 
 define_metrics!(
@@ -53,6 +61,14 @@ pub fn register_metrics(storage_height: BlockNumber) {
 
     FULL_BLOCKS.register();
     PRECONFIRMED_BLOCK_WRITTEN.register();
+
+    // Blockifier's metrics
+    CALLS_RUNNING_NATIVE.register();
+    CLASS_CACHE_HITS.register();
+    CLASS_CACHE_MISSES.register();
+    NATIVE_CLASS_RETURNED.register();
+    NATIVE_COMPILATION_ERROR.register();
+    TOTAL_CALLS.register();
 }
 
 /// A handle to update the proposal metrics when the proposal is created and dropped.

crates/apollo_dashboard/resources/dev_grafana_alerts_mainnet.json

@@ -652,7 +652,7 @@
       "name": "native_compilation_error",
       "title": "Native compilation alert",
       "ruleGroup": "batcher",
-      "expr": "increase(native_compilation_error[1h])",
+      "expr": "increase(native_compilation_error{cluster=~\"$cluster\", namespace=~\"$namespace\"}[1h])",
       "conditions": [
         {
           "evaluator": {
@@ -673,7 +673,7 @@
       ],
       "for": "30s",
       "intervalSec": 30,
-      "severity": "p5"
+      "severity": "p4"
     },
     {
       "name": "batched_transactions_stuck",

crates/apollo_dashboard/resources/dev_grafana_alerts_testnet.json

@@ -652,7 +652,7 @@
       "name": "native_compilation_error",
       "title": "Native compilation alert",
       "ruleGroup": "batcher",
-      "expr": "increase(native_compilation_error[1h])",
+      "expr": "increase(native_compilation_error{cluster=~\"$cluster\", namespace=~\"$namespace\"}[1h])",
       "conditions": [
         {
           "evaluator": {
@@ -673,7 +673,7 @@
       ],
       "for": "30s",
       "intervalSec": 30,
-      "severity": "p5"
+      "severity": "p4"
     },
     {
       "name": "batched_transactions_stuck",

crates/apollo_dashboard/src/alert_definitions.rs

@@ -354,15 +354,15 @@ fn get_native_compilation_error_increase() -> Alert {
         "native_compilation_error",
         "Native compilation alert",
         AlertGroup::Batcher,
-        format!("increase({}[1h])", NATIVE_COMPILATION_ERROR.get_name()),
+        format!("increase({}[1h])", NATIVE_COMPILATION_ERROR.get_name_with_filter()),
         vec![AlertCondition {
             comparison_op: AlertComparisonOp::GreaterThan,
             comparison_value: 0.0,
             logical_op: AlertLogicalOp::And,
         }],
         PENDING_DURATION_DEFAULT,
         EVALUATION_INTERVAL_SEC_DEFAULT,
-        AlertSeverity::Informational,
+        AlertSeverity::WorkingHours,
         AlertEnvFiltering::All,
     )
 }