starknet_os: validate_builtins function

Author: Yonatan-Starkware

crates/starknet_os/src/runner.rs

@@ -29,6 +29,9 @@ use crate::io::os_input::{
 };
 use crate::io::os_output::{StarknetAggregatorRunnerOutput, StarknetOsRunnerOutput};
 use crate::metrics::OsMetrics;
+#[cfg(any(test, feature = "testing"))]
+use crate::test_utils::validate_builtins;
+
 
 pub struct RunnerReturnObject {
     #[cfg(feature = "include_program_output")]
@@ -208,7 +211,7 @@ pub fn run_os_for_testing<S: StateReader>(
     }: OsHints,
     state_readers: Vec<S>,
 ) -> Result<(StarknetOsRunnerOutput, Vec<OsTransactionTrace>), StarknetOsError> {
-    let (runner_output, snos_hint_processor) = create_hint_processor_and_run_os(
+    let (mut runner_output, snos_hint_processor) = create_hint_processor_and_run_os(
         layout,
         os_hints_config,
         &os_block_inputs,
@@ -220,6 +223,8 @@ pub fn run_os_for_testing<S: StateReader>(
         public_key_y,
     )?;
 
+    validate_builtins(&mut runner_output.cairo_runner);
+
     let txs_trace: Vec<OsTransactionTrace> =
         snos_hint_processor.get_current_execution_helper().unwrap().os_logger.get_txs().clone();
 

crates/starknet_os/src/test_utils.rs

@@ -2,3 +2,12 @@ pub mod cairo_runner;
 pub mod errors;
 #[cfg(test)]
 pub mod utils;
+
+#[cfg(any(test, feature = "testing"))]
+use cairo_vm::vm::runners::cairo_runner::CairoRunner;
+pub(crate) fn validate_builtins(runner: &mut CairoRunner) {
+    let builtins_start = runner.get_builtins_final_stack(runner.vm.get_ap()).unwrap();
+    let n_builtins = runner.get_program().builtins_len();
+    let builtins_end = runner.vm.get_ap();
+    assert_eq!((builtins_start + n_builtins).unwrap(), builtins_end);
+}