Auto-generated commit

stdlib-bot · stdlib-bot · commit dbeb62de7b1c · 2025-05-26T21:11:26.000Z
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -224,6 +224,7 @@
 
 ### Bug Fixes
 
+-   [`151f3e5`](https://github.com/stdlib-js/stdlib/commit/151f3e5714bf1b13e00b72ee0c98fb65ee095ba8) - update implementation to preserve signed zeros
 -   [`71cafe3`](https://github.com/stdlib-js/stdlib/commit/71cafe3750d452180ec33524aa0d2fb19322b743) - add support for complex64 and complex128
 -   [`3014ce9`](https://github.com/stdlib-js/stdlib/commit/3014ce93b3fd6a8d7d26b7951d762f5100faffdf) - update return type
 -   [`2acc7f0`](https://github.com/stdlib-js/stdlib/commit/2acc7f03aa6e89410deb74d99f466cc1cd400384) - update return type
@@ -477,6 +478,8 @@ A total of 22 issues were closed in this release:
 
 <details>
 
+-   [`151f3e5`](https://github.com/stdlib-js/stdlib/commit/151f3e5714bf1b13e00b72ee0c98fb65ee095ba8) - **fix:** update implementation to preserve signed zeros _(by Athan Reines)_
+-   [`9bfb869`](https://github.com/stdlib-js/stdlib/commit/9bfb8691fc945a8e38c592d0e387c84aa31d8585) - **test:** add signed zero tests _(by Athan Reines)_
 -   [`f20c234`](https://github.com/stdlib-js/stdlib/commit/f20c234a4112d25281d202e8a0cf9ba223becb4c) - **docs:** update namespace table of contents [(#7092)](https://github.com/stdlib-js/stdlib/pull/7092) _(by stdlib-bot)_
 -   [`71cafe3`](https://github.com/stdlib-js/stdlib/commit/71cafe3750d452180ec33524aa0d2fb19322b743) - **fix:** add support for complex64 and complex128 _(by Athan Reines)_
 -   [`3014ce9`](https://github.com/stdlib-js/stdlib/commit/3014ce93b3fd6a8d7d26b7951d762f5100faffdf) - **fix:** update return type _(by Athan Reines)_
diff --git a/ext/base/dssumors/lib/ndarray.js b/ext/base/dssumors/lib/ndarray.js
@@ -48,18 +48,19 @@ function dssumors( N, x, strideX, offsetX ) {
 	var m;
 	var i;
 
-	sum = 0.0;
 	if ( N <= 0 ) {
-		return sum;
+		return 0.0;
 	}
 	ix = offsetX;
 	if ( strideX === 0 ) {
 		return N * x[ ix ];
 	}
+	sum = x[ ix ];
+	ix += strideX;
 
 	// If the stride is equal to `1`, use unrolled loops...
 	if ( strideX === 1 ) {
-		m = N % M;
+		m = (N-1) % M;
 
 		// If we have a remainder, run a clean-up loop...
 		if ( m > 0 ) {
@@ -71,13 +72,13 @@ function dssumors( N, x, strideX, offsetX ) {
 		if ( N < M ) {
 			return sum;
 		}
-		for ( i = m; i < N; i += M ) {
+		for ( i = m; i < N-1; i += M ) {
 			sum += x[ix] + x[ix+1] + x[ix+2] + x[ix+3] + x[ix+4] + x[ix+5];
 			ix += M;
 		}
 		return sum;
 	}
-	for ( i = 0; i < N; i++ ) {
+	for ( i = 1; i < N; i++ ) {
 		sum += x[ ix ];
 		ix += strideX;
 	}
diff --git a/ext/base/dssumors/src/main.c b/ext/base/dssumors/src/main.c
@@ -48,34 +48,38 @@ double API_SUFFIX(stdlib_strided_dssumors_ndarray)( const CBLAS_INT N, const flo
 	CBLAS_INT i;
 	double sum;
 
-	sum = 0.0;
 	if ( N <= 0 ) {
-		return sum;
+		return 0.0;
 	}
 	ix = offsetX;
 	if ( strideX == 0 ) {
 		return N * X[ ix ];
 	}
+	sum = X[ ix ];
+	ix += strideX;
+
 	// If the stride is equal to `1`, use unrolled loops...
 	if ( strideX == 1 ) {
-		m = N % 6;
+		m = (N-1) % 6;
 
 		// If we have a remainder, run a clean-up loop...
 		if ( m > 0 ) {
 			for ( i = 0; i < m; i++ ) {
-				sum += (double)X[ i ];
+				sum += (double)X[ ix ];
+				ix += strideX;
 			}
 		}
 		if ( N < 6 ) {
 			return sum;
 		}
-		for ( i = m; i < N; i += 6 ) {
-			sum += (double)X[i] + (double)X[i+1] + (double)X[i+2] + (double)X[i+3] + (double)X[i+4] + (double)X[i+5];
+		for ( i = m; i < N-1; i += 6 ) {
+			sum += (double)X[ix] + (double)X[ix+1] + (double)X[ix+2] + (double)X[ix+3] + (double)X[ix+4] + (double)X[ix+5];
+			ix += 6;
 		}
 		return sum;
 	}
 
-	for ( i = 0; i < N; i++ ) {
+	for ( i = 1; i < N; i++ ) {
 		sum += (double)X[ ix ];
 		ix += strideX;
 	}
diff --git a/ext/base/dssumors/test/test.ndarray.js b/ext/base/dssumors/test/test.ndarray.js
@@ -22,6 +22,7 @@
 
 var tape = require( 'tape' );
 var isnan = require( '@stdlib/math/base/assert/is-nan' );
+var isNegativeZero = require( '@stdlib/math/base/assert/is-negative-zero' );
 var Float32Array = require( '@stdlib/array/float32' );
 var dssumors = require( './../lib/ndarray.js' );
 
@@ -74,6 +75,17 @@ tape( 'the function calculates the sum of all strided array elements', function
 	t.end();
 });
 
+tape( 'the function preserves the sign of zero', function test( t ) {
+	var x;
+	var v;
+
+	x = new Float32Array( [ -0.0, -0.0, -0.0, -0.0, -0.0 ] );
+	v = dssumors( x.length, x, 1, 0 );
+	t.strictEqual( isNegativeZero( v ), true, 'returns expected value' );
+
+	t.end();
+});
+
 tape( 'if provided an `N` parameter less than or equal to `0`, the function returns `0.0`', function test( t ) {
 	var x;
 	var v;
diff --git a/ext/base/dssumors/test/test.ndarray.native.js b/ext/base/dssumors/test/test.ndarray.native.js
@@ -23,6 +23,7 @@
 var resolve = require( 'path' ).resolve;
 var tape = require( 'tape' );
 var isnan = require( '@stdlib/math/base/assert/is-nan' );
+var isNegativeZero = require( '@stdlib/math/base/assert/is-negative-zero' );
 var Float32Array = require( '@stdlib/array/float32' );
 var tryRequire = require( '@stdlib/utils/try-require' );
 
@@ -83,6 +84,17 @@ tape( 'the function calculates the sum of all strided array elements', opts, fun
 	t.end();
 });
 
+tape( 'the function preserves the sign of zero', opts, function test( t ) {
+	var x;
+	var v;
+
+	x = new Float32Array( [ -0.0, -0.0, -0.0, -0.0, -0.0 ] );
+	v = dssumors( x.length, x, 1, 0 );
+	t.strictEqual( isNegativeZero( v ), true, 'returns expected value' );
+
+	t.end();
+});
+
 tape( 'if provided an `N` parameter less than or equal to `0`, the function returns `0.0`', opts, function test( t ) {
 	var x;
 	var v;
diff --git a/ext/base/dsum/test/test.ndarray.js b/ext/base/dsum/test/test.ndarray.js
@@ -22,6 +22,8 @@
 
 var tape = require( 'tape' );
 var isnan = require( '@stdlib/math/base/assert/is-nan' );
+var isPositiveZero = require( '@stdlib/math/base/assert/is-positive-zero' );
+var isNegativeZero = require( '@stdlib/math/base/assert/is-negative-zero' );
 var Float64Array = require( '@stdlib/array/float64' );
 var dsum = require( './../lib/ndarray.js' );
 
@@ -66,6 +68,23 @@ tape( 'the function calculates the sum of all strided array elements', function
 	t.end();
 });
 
+tape( 'the function preserves the sign of zero', function test( t ) {
+	var x;
+	var v;
+
+	x = new Float64Array( [ -0.0, -0.0, -0.0 ] );
+
+	v = dsum( x.length, x, 1, 0 );
+	t.strictEqual( isNegativeZero( v ), true, 'returns expected value' );
+
+	x = new Float64Array( [ 0.0, -0.0, -0.0 ] );
+
+	v = dsum( x.length, x, 1, 0 );
+	t.strictEqual( isPositiveZero( v ), true, 'returns expected value' );
+
+	t.end();
+});
+
 tape( 'if provided an `N` parameter less than or equal to `0`, the function returns `0.0`', function test( t ) {
 	var x;
 	var v;
diff --git a/ext/base/dsum/test/test.ndarray.native.js b/ext/base/dsum/test/test.ndarray.native.js
@@ -23,6 +23,8 @@
 var resolve = require( 'path' ).resolve;
 var tape = require( 'tape' );
 var isnan = require( '@stdlib/math/base/assert/is-nan' );
+var isPositiveZero = require( '@stdlib/math/base/assert/is-positive-zero' );
+var isNegativeZero = require( '@stdlib/math/base/assert/is-negative-zero' );
 var Float64Array = require( '@stdlib/array/float64' );
 var tryRequire = require( '@stdlib/utils/try-require' );
 
@@ -75,6 +77,23 @@ tape( 'the function calculates the sum of all strided array elements', opts, fun
 	t.end();
 });
 
+tape( 'the function preserves the sign of zero', opts, function test( t ) {
+	var x;
+	var v;
+
+	x = new Float64Array( [ -0.0, -0.0, -0.0 ] );
+
+	v = dsum( x.length, x, 1, 0 );
+	t.strictEqual( isNegativeZero( v ), true, 'returns expected value' );
+
+	x = new Float64Array( [ 0.0, -0.0, -0.0 ] );
+
+	v = dsum( x.length, x, 1, 0 );
+	t.strictEqual( isPositiveZero( v ), true, 'returns expected value' );
+
+	t.end();
+});
+
 tape( 'if provided an `N` parameter less than or equal to `0`, the function returns `0.0`', opts, function test( t ) {
 	var x;
 	var v;

Original file line number	Diff line number	Diff line change
`@@ -48,34 +48,38 @@ double API_SUFFIX(stdlib_strided_dssumors_ndarray)( const CBLAS_INT N, const flo`
`48`	`48`	`CBLAS_INT i;`
`49`	`49`	`double sum;`
`50`	`50`
`51`		`- sum = 0.0;`
`52`	`51`	`if ( N <= 0 ) {`
`53`		`- return sum;`
	`52`	`+ return 0.0;`
`54`	`53`	`}`
`55`	`54`	`ix = offsetX;`
`56`	`55`	`if ( strideX == 0 ) {`
`57`	`56`	`return N * X[ ix ];`
`58`	`57`	`}`
	`58`	`+ sum = X[ ix ];`
	`59`	`+ ix += strideX;`
	`60`	`+`
`59`	`61`	// If the stride is equal to `1`, use unrolled loops...
`60`	`62`	`if ( strideX == 1 ) {`
`61`		`- m = N % 6;`
	`63`	`+ m = (N-1) % 6;`
`62`	`64`
`63`	`65`	`// If we have a remainder, run a clean-up loop...`
`64`	`66`	`if ( m > 0 ) {`
`65`	`67`	`for ( i = 0; i < m; i++ ) {`
`66`		`- sum += (double)X[ i ];`
	`68`	`+ sum += (double)X[ ix ];`
	`69`	`+ ix += strideX;`
`67`	`70`	`}`
`68`	`71`	`}`
`69`	`72`	`if ( N < 6 ) {`
`70`	`73`	`return sum;`
`71`	`74`	`}`
`72`		`- for ( i = m; i < N; i += 6 ) {`
`73`		`- sum += (double)X[i] + (double)X[i+1] + (double)X[i+2] + (double)X[i+3] + (double)X[i+4] + (double)X[i+5];`
	`75`	`+ for ( i = m; i < N-1; i += 6 ) {`
	`76`	`+ sum += (double)X[ix] + (double)X[ix+1] + (double)X[ix+2] + (double)X[ix+3] + (double)X[ix+4] + (double)X[ix+5];`
	`77`	`+ ix += 6;`
`74`	`78`	`}`
`75`	`79`	`return sum;`
`76`	`80`	`}`
`77`	`81`
`78`		`- for ( i = 0; i < N; i++ ) {`
	`82`	`+ for ( i = 1; i < N; i++ ) {`
`79`	`83`	`sum += (double)X[ ix ];`
`80`	`84`	`ix += strideX;`
`81`	`85`	`}`