Fix new ruff rules

Author: Cadair

ndcube/ndcube.py

@@ -796,8 +796,8 @@ def reproject_to(self,
         However, ``meta`` and ``global_coords`` are copied to the output `ndcube.NDCube`.
         """
         try:
-            from reproject import reproject_adaptive, reproject_exact, reproject_interp
-            from reproject.wcs_utils import has_celestial
+            from reproject import reproject_adaptive, reproject_exact, reproject_interp  # noqa: PLC0415
+            from reproject.wcs_utils import has_celestial  # noqa: PLC0415
         except ModuleNotFoundError:
             raise ImportError(f"The {type(self).__name__}.reproject_to method requires "
                               f"the `reproject` library to be installed.")
@@ -923,7 +923,7 @@ def _as_mpl_axes(self):
         warn_user(f"The current plotter {self.plotter} does not have a '_as_mpl_axes' method. "
                     "The default MatplotlibPlotter._as_mpl_axes method will be used instead.")
 
-        from ndcube.visualization.mpl_plotter import MatplotlibPlotter
+        from ndcube.visualization.mpl_plotter import MatplotlibPlotter  # noqa: PLC0415
 
         plotter = MatplotlibPlotter(self)
         return plotter._as_mpl_axes()

ndcube/tests/test_ndcube_arithmetic.py

@@ -241,7 +241,8 @@ def test_cube_arithmetic_rdivide(ndcube_2d_ln_lt_units, value):
 @pytest.mark.parametrize('value', [1, 2, -1])
 def test_cube_arithmetic_rdivide_uncertainty(ndcube_4d_unit_uncertainty, value):
     cube_quantity = u.Quantity(ndcube_4d_unit_uncertainty.data, ndcube_4d_unit_uncertainty.unit)
-    with pytest.warns(NDCubeUserWarning, match="UnknownUncertainty does not support uncertainty propagation with correlation. Setting uncertainties to None."):
+    match = "UnknownUncertainty does not support uncertainty propagation with correlation. Setting uncertainties to None."
+    with pytest.warns(NDCubeUserWarning, match=match):  # noqa: PT031
         with np.errstate(divide='ignore'):
             new_cube =  value / ndcube_4d_unit_uncertainty
             check_arithmetic_value_and_units(new_cube,  value / cube_quantity)
@@ -280,7 +281,8 @@ def test_cube_arithmetic_power(ndcube_2d_ln_lt, power):
 @pytest.mark.parametrize('power', [2, -2, 10, 0.5])
 def test_cube_arithmetic_power_unknown_uncertainty(ndcube_4d_unit_uncertainty, power):
     cube_quantity = u.Quantity(ndcube_4d_unit_uncertainty.data, ndcube_4d_unit_uncertainty.unit)
-    with pytest.warns(NDCubeUserWarning, match="UnknownUncertainty does not support uncertainty propagation with correlation. Setting uncertainties to None."):
+    match = "UnknownUncertainty does not support uncertainty propagation with correlation. Setting uncertainties to None."
+    with pytest.warns(NDCubeUserWarning, match=match):  # noqa: PT031
         with np.errstate(divide='ignore'):
             new_cube = ndcube_4d_unit_uncertainty ** power
             check_arithmetic_value_and_units(new_cube, cube_quantity**power)
@@ -289,7 +291,8 @@ def test_cube_arithmetic_power_unknown_uncertainty(ndcube_4d_unit_uncertainty, p
 @pytest.mark.parametrize('power', [2, -2, 10, 0.5])
 def test_cube_arithmetic_power_std_uncertainty(ndcube_2d_ln_lt_uncert, power):
     cube_quantity = u.Quantity(ndcube_2d_ln_lt_uncert.data, ndcube_2d_ln_lt_uncert.unit)
-    with pytest.warns(NDCubeUserWarning, match=r"<class 'astropy.nddata.nduncertainty.StdDevUncertainty'> does not support propagation of uncertainties for power. Setting uncertainties to None."):
+    match = r"<class 'astropy.nddata.nduncertainty.StdDevUncertainty'> does not support propagation of uncertainties for power. Setting uncertainties to None."
+    with pytest.warns(NDCubeUserWarning, match=match):  # noqa: PT031
         with np.errstate(divide='ignore'):
             new_cube = ndcube_2d_ln_lt_uncert ** power
             check_arithmetic_value_and_units(new_cube, cube_quantity**power)

ndcube/utils/cube.py

@@ -30,7 +30,7 @@ def sanitize_wcs(func):
     passed is a HighLevelWCS object, or an ExtraCoords object.
     """
     # This needs to be here to prevent a circular import
-    from ndcube.extra_coords.extra_coords import ExtraCoords
+    from ndcube.extra_coords.extra_coords import ExtraCoords  # noqa: PLC0415
 
     @wraps(func)
     def wcs_wrapper(*args, **kwargs):
@@ -92,7 +92,7 @@ def sanitize_crop_inputs(points, wcs):
         raise ValueError("All points must have same number of coordinate objects."
                          f"Number of objects in each point: {n_coords}")
     # Import must be here to avoid circular import.
-    from ndcube.extra_coords.extra_coords import ExtraCoords
+    from ndcube.extra_coords.extra_coords import ExtraCoords  # noqa: PLC0415
     if isinstance(wcs, ExtraCoords):
         # Determine how many dummy axes are needed
         n_dummy_axes = len(wcs._cube_array_axes_without_extra_coords)

ndcube/visualization/descriptor.py

@@ -35,14 +35,15 @@ def _resolve_default_type(self, raise_error=True):
         if self._default_type in ("mpl_plotter", "mpl_sequence_plotter"):
             if self._default_type == "mpl_plotter":
                 try:
-                    from ndcube.visualization.mpl_plotter import MatplotlibPlotter
+                    from ndcube.visualization.mpl_plotter import MatplotlibPlotter  # noqa: PLC0415
                     return MatplotlibPlotter
                 except ImportError as e:
                     if raise_error:
                         raise ImportError(MISSING_MATPLOTLIB_ERROR_MSG) from e
             elif self._default_type == "mpl_sequence_plotter":
                 try:
-                    from ndcube.visualization.mpl_sequence_plotter import MatplotlibSequencePlotter
+                    from ndcube.visualization.mpl_sequence_plotter import \
+                        MatplotlibSequencePlotter  # noqa: PLC0415
                     return MatplotlibSequencePlotter
                 except ImportError as e:
                     if raise_error:

ndcube/visualization/mpl_plotter.py

@@ -196,7 +196,7 @@ def _plot_2D_cube(self, wcs, axes=None, plot_axes=None, axes_coordinates=None,
     def _animate_cube(self, wcs, plot_axes=None, axes_coordinates=None,
                       axes_units=None, data_unit=None, **kwargs):
         try:
-            from mpl_animators import ArrayAnimatorWCS
+            from mpl_animators import ArrayAnimatorWCS  # noqa: PLC0415
         except ImportError as e:
             raise ImportError(MISSING_ANIMATORS_ERROR_MSG) from e
 

ndcube/wcs/wrappers/compound_wcs.py

@@ -148,7 +148,7 @@ def world_to_pixel_values(self, *world_arrays):
     def world_axis_object_components(self):
         all_components = []
         for iw, w in enumerate(self._wcs):
-            all_components += [(f'{component[0]}_{iw}',) + component[1:] for component
+            all_components += [(f'{component[0]}_{iw}', *component[1:]) for component
                                in w.world_axis_object_components]
         return all_components