Fix a couple of clang-19 warnings (#5461)

Remove unused functions in lib/irrlicht/source/Irrlicht/CBlit.h
Handle unused debug variables

Author: nyllet

lib/irrlicht/source/Irrlicht/CBlit.h

@@ -387,7 +387,7 @@ std::shared_ptr<SPShader> SPShaderManager::buildSPShader(const ShaderInfo& si,
     std::shared_ptr<SPShader> sps;
 #ifndef SERVER_ONLY
     sps = std::make_shared<SPShader>(si.m_shader_name,
-        [this, pi, ua, skinned](SPShader* shader)
+        [pi, ua, skinned](SPShader* shader)
         {
             // First pass
             assert(!pi[0].m_vertex_shader.empty() ||

src/graphics/sp/sp_shader_manager.cpp

@@ -152,12 +152,13 @@ void Screen::loadFromFile()
 void Screen::unload()
 {
     assert(m_magic_number == 0xCAFEC001);
+#ifndef NDEBUG
     Widget* w;
     for_in (w, m_widgets)
     {
         assert(w->m_magic_number == 0xCAFEC001);
     }
-
+#endif
     m_loaded = false;
     m_widgets.clearAndDeleteAll();
 

src/guiengine/screen.cpp

@@ -351,6 +351,7 @@ void PlayerKartWidget::add()
 
     assert(KartSelectionScreen::getRunningInstance()
            ->m_kart_widgets.contains(this));
+#ifdef DEBUG
     if (m_associated_player) // if player is local
     {
 #ifdef DEBUG
@@ -366,7 +367,7 @@ void PlayerKartWidget::add()
         assert(mineInList);
 #endif
     }
-
+#endif
     // the first player will have an ID of its own to allow for keyboard
     // navigation despite this widget being added last
     if (m_irrlicht_widget_id != -1)

src/guiengine/widgets/player_kart_widget.cpp

@@ -1552,16 +1552,17 @@ void SkiddingAI::handleRaceStart()
         // smaller depending on the difficulty.
         m_start_delay = stk_config->time2Ticks(
                         m_ai_properties->m_min_start_delay
-                      + (float) rand() / RAND_MAX
-                      * (m_ai_properties->m_max_start_delay -
-                         m_ai_properties->m_min_start_delay)   );
+                        + static_cast<float>(
+                           static_cast<double>(rand()) / static_cast<double>(RAND_MAX)
+                           * (m_ai_properties->m_max_start_delay -
+                              m_ai_properties->m_min_start_delay)));
 
         float false_start_probability =
                m_superpower == RaceManager::SUPERPOWER_NOLOK_BOSS
                ? 0.0f  : m_ai_properties->m_false_start_probability;
 
         // Now check for a false start. If so, add 1 second penalty time.
-        if (rand() < RAND_MAX * false_start_probability)
+        if (static_cast<double>(rand()) < static_cast<double>(RAND_MAX) * false_start_probability)
         {
             m_start_delay+=stk_config->m_penalty_ticks;
             return;

src/karts/controller/test_ai.cpp

@@ -900,7 +900,6 @@ void LinearWorld::updateRacePosition()
             setKartPosition(i, kart->getPosition());
             continue;
         }
-        KartInfo& kart_info = m_kart_info[i];
 
         int p = 1 ;
 

src/modes/linear_world.cpp

@@ -31,11 +31,13 @@
 #include <assert.h>
 #include <string>
 
-#if defined(CURLOPT_XFERINFODATA)
+#if LIBCURL_VERSION_MAJOR > 7 || (LIBCURL_VERSION_MAJOR == 7 && LIBCURL_VERSION_MINOR > 31)
+// Use CURLOPT_XFERINFOFUNCTION (introduced in 7.32.0)
 #define PROGRESSDATA     CURLOPT_XFERINFODATA
 #define PROGRESSFUNCTION CURLOPT_XFERINFOFUNCTION
 typedef curl_off_t progress_t;
 #else
+// Use CURLOPT_PROGRESSFUNCTION (deprecated since 7.32.0)
 #define PROGRESSDATA     CURLOPT_PROGRESSDATA
 #define PROGRESSFUNCTION CURLOPT_PROGRESSFUNCTION
 typedef double progress_t;

src/online/http_request.hpp

@@ -350,8 +350,8 @@ class RaceManager
     int                              m_skipped_tracks_in_gp;
     /** Time target for GP, used in Lap Trial mode */
     float                            m_gp_time_target;
-    /** Total laps from every track, used in Lap Trial mode */
-    int                              m_gp_total_laps;
+    /** Total laps from every track, used in Lap Trial mode
+        int                              m_gp_total_laps;*/
     void startNextRace();    // start a next race
 
     friend bool operator< (const KartStatus& left, const KartStatus& right)

src/race/race_manager.hpp

@@ -1514,6 +1514,7 @@ bool KartSelectionScreen::validateIdentChoices()
             m_kart_widgets[n].m_player_ident_spinner->markAsCorrect();
 
             // verify internal consistency in debug mode
+#ifndef NDEBUG
             if (m_multiplayer)
             {
                 int spinner_value = m_kart_widgets[n].m_player_ident_spinner->getValue();
@@ -1522,6 +1523,7 @@ bool KartSelectionScreen::validateIdentChoices()
                 assert(m_kart_widgets[n].getAssociatedPlayer()->getProfile() ==
                     PlayerManager::get()->getPlayer(spinner_value));
             }
+#endif
         }
     }
 

src/states_screens/kart_selection.cpp

@@ -1294,7 +1294,9 @@ void RaceResultGUI::renderGlobal(float dt)
                 break;
             case RR_INCREASE_POINTS:
             {
+#ifndef NDEBUG
                 WorldWithRank *wwr = dynamic_cast<WorldWithRank*>(World::getWorld());
+#endif
                 assert(wwr);
                 ri->m_current_displayed_points += dt * m_most_points / time_for_points;
                 if (ri->m_current_displayed_points > ri->m_new_overall_points)