Skip to content

Commit 8b6d0b5

Browse files
committed
Dropped support for Ruby 2.3 and 2.4
* added Ruby 2.7 to the TravisCI config * rubocop-performance gem added * rubocop rake task added to the default rake task * all development dependencies updated
1 parent 6c7d9e9 commit 8b6d0b5

File tree

9 files changed

+37
-19
lines changed

9 files changed

+37
-19
lines changed

.rubocop.yml

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,15 @@
11
require:
22
- 'rubocop-rspec'
3+
- 'rubocop-performance'
34

45
AllCops:
5-
TargetRubyVersion: 2.3
6+
TargetRubyVersion: 2.5
67

78
DisplayCopNames: true
89
DisplayStyleGuide: true
910
ExtraDetails: true
1011

11-
Documentation:
12-
Enabled: false
13-
14-
Metrics/LineLength:
12+
Layout/LineLength:
1513
Max: 120
1614

1715
Metrics/BlockLength:
@@ -21,12 +19,21 @@ Metrics/BlockLength:
2119
Metrics/MethodLength:
2220
Max: 15
2321

24-
Bundler/OrderedGems:
22+
Style/Documentation:
2523
Enabled: false
2624

2725
Style/NumericPredicate:
2826
Enabled: false
2927

28+
Style/HashEachMethods:
29+
Enabled: true
30+
31+
Style/HashTransformKeys:
32+
Enabled: true
33+
34+
Style/HashTransformValues:
35+
Enabled: true
36+
3037
RSpec/ExampleLength:
3138
Enabled: false
3239

.travis.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,9 @@ env:
88
- CC_TEST_REPORTER_ID=9995f7b2aa6866b0427aef31d946ff1feded8f6e109eaf6ccb58e91c73d0bfeb
99

1010
rvm:
11-
- 2.3
12-
- 2.4
1311
- 2.5
1412
- 2.6
13+
- 2.7
1514
- ruby-head
1615
- jruby-head
1716
- truffleruby

CHANGELOG.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,13 @@
11
# Changelog
22

3+
## v4.0.0
4+
5+
* dropped support for Ruby 2.3 and 2.4
6+
* added Ruby 2.7 to the TravisCI config
7+
* rubocop-performance gem added
8+
* rubocop rake task added to the default rake task
9+
* all development dependencies updated
10+
311
## v3.0.0
412

513
* dropped support for Ruby 1.9-2.2 and Rubinius

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ If you need something more fully-featured you should use absolutely awesome [HTT
1717
Add this line to your Gemfile:
1818

1919
```ruby
20-
gem 'http_wrapper', '~> 3.0'
20+
gem 'http_wrapper', '~> 4.0'
2121
```
2222

2323
And then execute:

Rakefile

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,10 @@
22

33
require 'bundler/gem_tasks'
44
require 'rspec/core/rake_task'
5+
require 'rubocop/rake_task'
6+
7+
RuboCop::RakeTask.new
58

69
RSpec::Core::RakeTask.new(:spec)
710

8-
task default: :spec
11+
task default: %i[rubocop spec]

http_wrapper.gemspec

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,14 @@ Gem::Specification.new do |spec|
1818
spec.test_files = Dir['spec/*']
1919
spec.require_paths = %w[lib]
2020

21-
spec.required_ruby_version = '>= 2.3.0'
21+
spec.required_ruby_version = '>= 2.5.0'
2222

2323
spec.add_development_dependency 'bundler'
2424
spec.add_development_dependency 'rake'
25-
spec.add_development_dependency 'rspec', '~> 3.7'
26-
spec.add_development_dependency 'rubocop', '~> 0.75.0'
27-
spec.add_development_dependency 'rubocop-rspec', '~> 1.32'
28-
spec.add_development_dependency 'simplecov', '~> 0.17.1'
29-
spec.add_development_dependency 'webmock', '~> 3.5'
25+
spec.add_development_dependency 'rspec', '~> 3.9'
26+
spec.add_development_dependency 'rubocop', '~> 0.80'
27+
spec.add_development_dependency 'rubocop-performance', '~> 1.5'
28+
spec.add_development_dependency 'rubocop-rspec', '~> 1.38'
29+
spec.add_development_dependency 'simplecov', '~> 0.18'
30+
spec.add_development_dependency 'webmock', '~> 3.8'
3031
end

lib/http_wrapper/request.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ def initialize(url, method, params = {}) # rubocop:disable Metrics/AbcSize
3232
attr_reader :uri
3333

3434
def uri=(url)
35-
url = "http://#{url}" unless url =~ %r{\Ahttps?://}
35+
url = "http://#{url}" unless %r{\Ahttps?://}.match?(url)
3636
@uri = URI.parse url
3737
end
3838

lib/http_wrapper/version.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# frozen_string_literal: true
22

33
class HTTPWrapper
4-
VERSION = '3.0.0'
4+
VERSION = '4.0.0'
55
end

spec/http_wrapper_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@
6565
WebMock.allow_net_connect!
6666
begin
6767
http.get 'localhost'
68-
rescue StandardError # rubocop:disable Lint/HandleExceptions
68+
rescue StandardError # rubocop:disable Lint/SuppressedException
6969
# NOOP, rescue from "connection refused" and such
7070
end
7171
WebMock.disable_net_connect!

0 commit comments

Comments
 (0)