style(Rails/TimeZone): manual

Author: antonsavitskiy

.rubocop_todo.yml

@@ -756,51 +756,6 @@ Rails/SkipsModelValidations:
     - 'spec/mongoid/touchable_spec.rb'
     - 'spec/support/models/server.rb'
 
-# Offense count: 159
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: strict, flexible
-Rails/TimeZone:
-  Exclude:
-    - 'lib/mongoid/criteria/queryable/extensions/date.rb'
-    - 'lib/mongoid/criteria/queryable/extensions/string.rb'
-    - 'lib/mongoid/extensions/array.rb'
-    - 'lib/mongoid/extensions/date.rb'
-    - 'lib/mongoid/extensions/float.rb'
-    - 'lib/mongoid/extensions/integer.rb'
-    - 'lib/mongoid/extensions/string.rb'
-    - 'lib/mongoid/extensions/time.rb'
-    - 'lib/mongoid/timestamps/created.rb'
-    - 'lib/mongoid/timestamps/updated.rb'
-    - 'lib/mongoid/touchable.rb'
-    - 'spec/integration/criteria/date_field_spec.rb'
-    - 'spec/integration/criteria/raw_value_spec.rb'
-    - 'spec/integration/persistence/range_field_spec.rb'
-    - 'spec/mongoid/association/referenced/has_and_belongs_to_many_spec.rb'
-    - 'spec/mongoid/association/referenced/has_many_spec.rb'
-    - 'spec/mongoid/attributes/readonly_spec.rb'
-    - 'spec/mongoid/attributes_spec.rb'
-    - 'spec/mongoid/copyable_spec.rb'
-    - 'spec/mongoid/criteria/queryable/extensions/array_spec.rb'
-    - 'spec/mongoid/criteria/queryable/extensions/date_spec.rb'
-    - 'spec/mongoid/criteria/queryable/extensions/date_time_spec.rb'
-    - 'spec/mongoid/criteria/queryable/extensions/range_spec.rb'
-    - 'spec/mongoid/criteria/queryable/extensions/time_with_zone_spec.rb'
-    - 'spec/mongoid/criteria/queryable/selectable_logical_spec.rb'
-    - 'spec/mongoid/criteria/queryable/selectable_spec.rb'
-    - 'spec/mongoid/criteria/queryable/selector_spec.rb'
-    - 'spec/mongoid/extensions/range_spec.rb'
-    - 'spec/mongoid/extensions/time_spec.rb'
-    - 'spec/mongoid/extensions/time_with_zone_spec.rb'
-    - 'spec/mongoid/mongoizable_spec.rb'
-    - 'spec/mongoid/persistable/savable_spec.rb'
-    - 'spec/mongoid/persistable/updatable_spec.rb'
-    - 'spec/mongoid/timestamps/updated/short_spec.rb'
-    - 'spec/mongoid/timestamps/updated_spec.rb'
-    - 'spec/mongoid/timestamps_spec.rb'
-    - 'spec/mongoid/touchable_spec.rb'
-    - 'spec/support/models/post.rb'
-
 # Offense count: 5
 # Configuration parameters: Include.
 # Include: spec/**/*.rb, test/**/*.rb

docs/reference/associations.txt

@@ -589,7 +589,7 @@ help of MongoDB projection operation:
   # {"find"=>"bands",
   #  "filter"=>{"started_on"=>{"$gt"=>2018-07-01 00:00:00 UTC}},
   #  "projection"=>{"_id"=>1, "label"=>1}}
-  Band.where(started_on: {'$gt' => Time.now - 1.year}).only(:label).map(&:label).compact.uniq
+  Band.where(started_on: {'$gt' => Time.zone.now - 1.year}).only(:label).map(&:label).compact.uniq
 
 Setting Stale Values on Referenced Associations
 ```````````````````````````````````````````````

docs/reference/crud.txt

@@ -455,7 +455,7 @@ are:
     	  end
 
           post = Post.create!
-          post.set('metadata.published_at' => Time.now)
+          post.set('metadata.published_at' => Time.zone.now)
           post.metadata['published_at'] # => Time instance
 
           post.set('metadata.approved.today' => true)

lib/mongoid/criteria/queryable/extensions/date.rb

@@ -25,7 +25,7 @@ def __evolve_date__
           #
           # @return [ Time | ActiveSupport::TimeWithZone ] The date as a local time.
           def __evolve_time__
-            ::Time.configured.local(year, month, day)
+            ::Time.zone.local(year, month, day)
           end
 
           module ClassMethods

lib/mongoid/criteria/queryable/extensions/string.rb

@@ -15,7 +15,9 @@ module String
           #
           # @return [ Time ] The time at UTC midnight.
           def __evolve_date__
-            time = ::Time.parse(self)
+            time = ::Time.zone.parse(self)
+            return nil if time.nil?
+
             ::Time.utc(time.year, time.month, time.day, 0, 0, 0, 0)
           end
 
@@ -26,6 +28,8 @@ def __evolve_date__
           #
           # @return [ Time ] The string as a time.
           def __evolve_time__
+            return nil if __evolve_date__.nil?
+
             __mongoize_time__.utc
           end
 

lib/mongoid/extensions/array.rb

@@ -50,7 +50,7 @@ def __mongoize_object_id__
       #   configured default time zone corresponding to date/time components
       #   in this array.
       def __mongoize_time__
-        ::Time.configured.local(*self)
+        ::Time.zone.local(*self)
       end
 
       # Checks whether conditions given in this array are known to be

lib/mongoid/extensions/date.rb

@@ -16,7 +16,7 @@ module Date
       #   configured default time zone corresponding to local midnight of
       #   this date.
       def __mongoize_time__
-        ::Time.configured.local(year, month, day)
+        ::Time.zone.local(year, month, day)
       end
 
       # Turn the object from the ruby type we deal with to a Mongo friendly
@@ -71,7 +71,7 @@ def mongoize(object)
           begin
             time = if object.is_a?(String)
                      # https://jira.mongodb.org/browse/MONGOID-4460
-                     ::Time.parse(object)
+                     ::Time.zone.parse(object)
                    else
                      object.__mongoize_time__
                    end

lib/mongoid/extensions/float.rb

@@ -13,7 +13,7 @@ module Float
       #
       # @return [ Time | ActiveSupport::TimeWithZone ] The time.
       def __mongoize_time__
-        ::Time.configured.at(self)
+        ::Time.zone.at(self)
       end
 
       # Is the float a number?

lib/mongoid/extensions/integer.rb

@@ -13,7 +13,7 @@ module Integer
       #
       # @return [ Time | ActiveSupport::TimeWithZone ] The time.
       def __mongoize_time__
-        ::Time.configured.at(self)
+        ::Time.zone.at(self)
       end
 
       # Is the integer a number?

lib/mongoid/extensions/string.rb

@@ -44,11 +44,11 @@ def __mongoize_time__
         # either returns nil or Time.now if the string is empty or invalid,
         # which is a regression from pre-3.0 and also does not agree with
         # the core Time API.
-        parsed = ::Time.parse(self)
-        if ::Time.configured == ::Time
+        parsed = ::Time.zone.parse(self)
+        if ::Time.zone == ::Time
           parsed
         else
-          ::Time.configured.parse(self)
+          ::Time.zone.parse(self)
         end
       end