[mod] [BREAKING] Change default min-level

Default before this commit: 2
Default after  this commit: :info (equivalent to integer 50)

Motivation:

  Tufte v2 levels were integers in #{0 1 2 3 4 5}
  Tufte v3 levels are ARBITRARY integers OR special keywords that
  are mapped to integers as:
    {          :trace 10 :debug 20         :info 50 :warn 60 :error 70 :fatal  80 :report  90
     :low--- 0 :low-- 10 :low-  20 :low 30 :med  50 :high 60 :high+ 70 :high++ 80 :high+++ 90}

  The new levels are more expressive, and are shared exactly by Telemere.

Migration:

  This change won't affect you unless you have `profiled` or `profile` calls with custom
  `:level` values.

  If you DO have custom `:level` values then either:

    Ensure that you call `set-min-level!`, etc. to set an appropriate minmimum.

      -OR-

    Update your `profiled` and `profile` calls to use an appropriate `:level`.

Author: ptaoussanis

src/taoensso/tufte.cljc

@@ -14,8 +14,8 @@
     `p`, `profiled`, `profile`, `add-handler!`, etc.
 
     (p        [opts & body] [id & body]) ; e.g. `(p ::my-id (do-work))`
-    (profiled [opts & body])             ; e.g. `(profiled {:level 2} (my-fn))`
-    (profile  [opts & body])             ; e.g. `(profiled {:level 2} (my-fn))`
+    (profiled [opts & body])             ; e.g. `(profiled {:level :info} (my-fn))`
+    (profile  [opts & body])             ; e.g. `(profiled {:level :info} (my-fn))`
 
     (add-handler! [handler-id handler-fn dispatch-opts])
 
@@ -101,11 +101,6 @@
   (impl/defhelp help:signal-content       :signal-content)
   (impl/defhelp help:environmental-config :environmental-config))
 
-;;;; Vestigial
-
-(def ^:dynamic *min-level* "Vestigial, currently ignored." 2)
-(def ^:dynamic *ns-filter* "Vestigial, currently ignored." "*")
-
 ;;;; Low-level primitives
 
 (defn profiling? "Returns e/o #{nil :thread :dynamic}."
@@ -228,7 +223,7 @@
       :arglists '([id & body] [{:keys [id level]} & body])}
      [s1 & body]
      (let [opts       (if (map? s1) s1 {:id s1})
-           level-form (get opts :level 5)
+           level-form (get opts :level :info)
            id-form    (get opts :id)
            location
            (enc/assoc-some nil
@@ -272,7 +267,7 @@
 
      [opts & body]
      (impl/valid-opts! &form &env 'tufte/profiled opts body)
-     (let [opts     (merge {:level 5} opts)
+     (let [opts     (merge {:level :info} opts)
            ns-form* (get opts :ns :auto)
            ns-form  (auto-> ns-form* (str *ns*))
 
@@ -299,9 +294,9 @@
   (macroexpand '(profiled {:allow? false}))
 
   (profiled {} (p :p1 nil))
-  (profiled {} (p {:level 5 :id :p1} nil))
+  (profiled {} (p {:level :info :id :p1} nil))
   (profiled {} (p (let [x :foo/id] x) "body"))
-  (profiled {:level 2 :when (chance 0.5)} (p :p1 "body"))
+  (profiled {:level :info :when (chance 0.5)} (p :p1 "body"))
   (profiled {} (p :foo (p :bar nil))))
 
 #?(:clj
@@ -316,7 +311,7 @@
      (let [cljs?    (boolean (:ns &env))
            clj?     (not cljs?)
 
-           opts     (merge {:level 5} opts)
+           opts     (merge {:level :info} opts)
            ns-form* (get opts :ns :auto)
            ns-form  (auto-> ns-form* (str *ns*))
 
@@ -801,8 +796,8 @@
       (p :10ms (Thread/sleep 10))
       "Result"))
 
-  (profile {:level 2 :id ::sleepy :data "foo"}    (sleepy-threads))
-  (profile {:level 2 :id ::sleepy :dynamic? true} (sleepy-threads))
+  (profile {:level :info :id ::sleepy :data "foo"}    (sleepy-threads))
+  (profile {:level :info :id ::sleepy :dynamic? true} (sleepy-threads))
   (p :hello "Hello, this is a result") ; Falls through (no pdata context)
 
   (defnp arithmetic []
@@ -819,7 +814,7 @@
   (profile  {} (dotimes [n 1e5] (p :p1 nil)))
   (profile  {} (dotimes [n 1e6] (p :p1 nil)))
   (profiled {} (dotimes [n 1e6] (p :p1 nil)))
-  (profiled {:level 2 :when (chance 0.5)} "body")
+  (profiled {:level :info :when (chance 0.5)} "body")
 
   @(second (profiled {:nmax 10000 :dynamic? true} (dotimes [n 200] (p :p1 nil))))
 

src/taoensso/tufte/impl.cljc

@@ -699,10 +699,10 @@
           :id-filter (or id-filter (get base :id-filter))
           :min-level (or min-level (get base :min-level))}))))
 
-(let [base      (enc/get-env {:as :edn}             [:taoensso.tufte/rt-filters<.platform><.edn>])
-      ns-filter (enc/get-env {:as :edn}             [:taoensso.tufte/rt-ns-filter<.platform><.edn>])
-      id-filter (enc/get-env {:as :edn}             [:taoensso.tufte/rt-id-filter<.platform><.edn>])
-      min-level (enc/get-env {:as :edn, :default 2} [:taoensso.tufte/rt-min-level<.platform><.edn>])]
+(let [base      (enc/get-env {:as :edn}                 [:taoensso.tufte/rt-filters<.platform><.edn>])
+      ns-filter (enc/get-env {:as :edn}                 [:taoensso.tufte/rt-ns-filter<.platform><.edn>])
+      id-filter (enc/get-env {:as :edn}                 [:taoensso.tufte/rt-id-filter<.platform><.edn>])
+      min-level (enc/get-env {:as :edn, :default :info} [:taoensso.tufte/rt-min-level<.platform><.edn>])]
 
   (enc/defonce ^:dynamic *rt-call-filter*
     "`SpecFilter` used for runtime filtering, or nil."