Skip to content

Commit 20aab2b

Browse files
committed
[mod] [BREAKING] Omit defn_/fn_ prefix for named fns
1 parent 2ff92d0 commit 20aab2b

File tree

2 files changed

+29
-26
lines changed

2 files changed

+29
-26
lines changed

src/taoensso/tufte.cljc

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -678,7 +678,10 @@
678678
base-id
679679
(if ?meta-pid
680680
(enc/as-qname ?meta-pid)
681-
(str *ns* "/" (if def? "defn_" "fn_") (name fn-sym)))
681+
(str *ns* "/"
682+
(if ?fn-sym
683+
(name ?fn-sym)
684+
(str (if def? "defn_" "fn_") (name fn-sym)))))
682685

683686
get-ids
684687
(if single-arity?

test/taoensso/tufte_tests.cljc

Lines changed: 25 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -538,15 +538,15 @@
538538
;;;; Util macros
539539

540540
(do
541-
(tufte/defnp fn1 [x] x) ; Line 541
542-
(tufte/defnp fn2 [x] x)
543-
(tufte/defnp ^{:tufte/id :__fn3} fn3 [x] x)
544-
(tufte/defnp ^{:tufte/id "__fn4"} fn4 ([x] x) ([x y] [x y]))
545-
(tufte/defnp- fn5 [x] x)
541+
(tufte/defnp fn1 [x] x) ; Line 541
542+
(tufte/defnp fn2 [x] x)
543+
(tufte/defnp ^{:tufte/id :my-fn3} fn3 [x] x)
544+
(tufte/defnp ^{:tufte/id "my-fn4"} fn4 ([x] x) ([x y] [x y]))
545+
(tufte/defnp- fn5 [x] x)
546546

547547
(defn run-test-fns []
548-
(let [fn6 (tufte/fnp fn6 [x] x)
549-
fn7 (tufte/fnp ^{:tufte/id :__fn7} fn7 [x] x)]
548+
(let [fn6 (tufte/fnp fn6 [x] x)
549+
fn7 (tufte/fnp ^{:tufte/id :my-fn7} fn7 [x] x)]
550550
[(fn1 "fn1")
551551
(fn2 "fn2")
552552
(fn3 "fn3")
@@ -561,15 +561,15 @@
561561
[(let [[r ps] (profiled {} (run-test-fns))]
562562
[(is (= r ["fn1" "fn2" "fn3" "fn4_1" ["fn4_2x" "fn4_2y"] "fn5" "fn6" "fn7" "fn1+2"]))
563563
(is (enc/submap? @ps
564-
{:stats {::defn_fn1 {:n 2},
565-
::defn_fn2 {:n 2},
566-
:__fn3 {:n 1},
567-
:__fn4 {:n 2}
568-
:__fn4_1 {:n 1}
569-
:__fn4_2 {:n 1}
570-
::defn_fn5 {:n 1}
571-
::fn_fn6 {:n 1}
572-
:__fn7 {:n 1}}}))])])
564+
{:stats {::fn1 {:n 2},
565+
::fn2 {:n 2},
566+
:my-fn3 {:n 1},
567+
:my-fn4 {:n 2}
568+
:my-fn4_1 {:n 1}
569+
:my-fn4_2 {:n 1}
570+
::fn5 {:n 1}
571+
::fn6 {:n 1}
572+
:my-fn7 {:n 1}}}))])])
573573

574574
;;;; Location info
575575

@@ -606,15 +606,15 @@
606606
[(is
607607
(enc/submap? @ps
608608
(let [nref 541]
609-
{:stats {::defn_fn1 {:loc {:line nref}}
610-
::defn_fn2 {:loc {:line (+ nref 1)}}
611-
:__fn3 {:loc {:line (+ nref 2)}}
612-
:__fn4 {:loc {:line (+ nref 3)}}
613-
:__fn4_1 {:loc {:line (+ nref 3)}}
614-
:__fn4_2 {:loc {:line (+ nref 3)}}
615-
::defn_fn5 {:loc {:line (+ nref 4)}}
616-
::fn_fn6 {:loc {:line (+ nref 7)}}
617-
:__fn7 {:loc {:line (+ nref 8)}}}})))])])
609+
{:stats {::fn1 {:loc {:line nref}}
610+
::fn2 {:loc {:line (+ nref 1)}}
611+
:my-fn3 {:loc {:line (+ nref 2)}}
612+
:my-fn4 {:loc {:line (+ nref 3)}}
613+
:my-fn4_1 {:loc {:line (+ nref 3)}}
614+
:my-fn4_2 {:loc {:line (+ nref 3)}}
615+
::fn5 {:loc {:line (+ nref 4)}}
616+
::fn6 {:loc {:line (+ nref 7)}}
617+
:my-fn7 {:loc {:line (+ nref 8)}}}})))])])
618618

619619
(comment (let [f1 (tufte/fnp foo [x] x #_(p :x x))]))
620620

0 commit comments

Comments
 (0)