Chore: Improve linting, add RUF linter (Ruff-specific rules)

Author: amotl

pyproject.toml

@@ -168,6 +168,8 @@ lint.select = [
   "PD",
   # return
   "RET",
+  # Ruff-specific rules
+  "RUF",
   # Bandit
   "S",
   # print

src/rapporto/github/actions.py

@@ -60,7 +60,7 @@ def markdown(self):
 # CI failures report {dt.datetime.now().strftime("%Y-%m-%d")}
 A report about GitHub Actions workflow runs that failed recently (now-{self.request.DELTA_HOURS}h).
 {mdc.render()}
-        """.strip()  # noqa: E501
+        """.strip()
 
 
 class GitHubActionsRequest:
@@ -72,7 +72,7 @@ class GitHubActionsRequest:
 
     DELTA_HOURS = 24
 
-    event_section_map = OrderedDict(
+    event_section_map: t.ClassVar[t.OrderedDict[str, str]] = OrderedDict(
         schedule="Schedule",
         pull_request="Pull requests",
         # push="Pushes",
@@ -140,7 +140,9 @@ class MultiRepositoryInquiry:
     repositories: t.List[str]
 
     @classmethod
-    def make(cls, repository: str, repositories_file: Path = None) -> "MultiRepositoryInquiry":
+    def make(
+        cls, repository: str, repositories_file: t.Optional[Path] = None
+    ) -> "MultiRepositoryInquiry":
         if repository:
             return cls(repositories=[repository])
         elif repositories_file:

src/rapporto/github/activity.py

@@ -116,7 +116,7 @@ def format_pr(item: "PullRequestMetadata"):
 
     @property
     def markdown(self) -> str:
-        timerange = self.inquiry.created and f"for {self.inquiry.created}" or ""
+        timerange = (self.inquiry.created and f"for {self.inquiry.created}") or ""
         with redirect_stdout(io.StringIO()) as buffer:
             print(f"# PPP report {timerange}")
             # print("## Overview")

src/rapporto/github/attention.py

@@ -20,7 +20,7 @@ class GitHubAttentionQueryBuilder(GitHubQueryBuilder):
     Find all open issues and pull requests with labels "bug" or "important".
     """
 
-    labels = [
+    labels: t.ClassVar[t.List[str]] = [
         "bug",  # GitHub standard.
         "important",  # CrateDB.
         "stale",  # CrateDB.
@@ -44,14 +44,14 @@ class GitHubAttentionReport:
     Find all issues and pull requests with labels "bug" or "important".
     """
 
-    label_section_map = OrderedDict(
+    label_section_map: t.ClassVar[t.OrderedDict[str, str]] = OrderedDict(
         bug="Bugs",
         important="Important",
         stale="Stale",
         others="Others",
     )
 
-    label_aliases = {
+    label_aliases: t.ClassVar[t.Dict[str, t.List[str]]] = {
         "bug": ["type-bug", "type-crash", "type: Bug", "type: bug"],
     }
 
@@ -109,4 +109,4 @@ def markdown(self):
 A report about important items that deserve your attention, bugs first.
 Time range: {self.search.query_builder.timeinterval.githubformat() or "n/a"}
 {mdc.render()}
-        """.strip()  # noqa: E501
+        """.strip()

src/rapporto/github/backup.py

@@ -9,5 +9,5 @@
 
 class GitHubBackup:
     def run(self, args):
-        cmd = [which("github-backup")] + args
+        cmd = [which("github-backup"), *args]
         subprocess.check_call(cmd)  # noqa: S603

src/rapporto/github/cli.py

@@ -60,7 +60,9 @@ def print_output(report, format_):
 @repository_option
 @repositories_file_option
 @format_option
-def actions(repository: str, repositories_file: Path = None, format_: t.Optional[str] = None):
+def actions(
+    repository: str, repositories_file: t.Optional[Path] = None, format_: t.Optional[str] = None
+):
     """
     CI/GHA failures.
     """

src/rapporto/github/model.py

@@ -143,7 +143,7 @@ def issues_and_prs(self):
 
 @dataclasses.dataclass()
 class MarkdownContent:
-    labels: OrderedDict = dataclasses.field(default_factory=OrderedDict)
+    labels: t.OrderedDict[str, str] = dataclasses.field(default_factory=OrderedDict)
     content: t.Dict[str, t.List[str]] = dataclasses.field(default_factory=dict)
 
     def add(self, section, content):