fix: add quotes to URLs in integration.json endpoint

CynthiaWahome · CynthiaWahome · commit a329dac9e1bd · 2025-02-20T17:58:58.000+03:00
- Add quotes around target_url and tick_url values
- Fix string literal syntax in integration.json response
- Ensure proper JSON serialization for URLs
diff --git a/app.py b/app.py
@@ -102,7 +102,7 @@ def github_webhook():
 # Integration JSON endpoint
 @app.route("/integration.json", methods=["GET"])
 def get_integration_json():
-    base_url = os.environ.get('APP_URL', request.url_root.rstrip('/'))
+    # base_url = os.environ.get('APP_URL', request.url_root.rstrip('/'))
     integration_json = {
         "data": {
             "date": {
@@ -134,7 +134,7 @@ def get_integration_json():
                 "default": "True"
             }
         ],
-        "target_url": f"{base_url}/github-webhook",
+        "target_url": https://github-commit-monitor-4a53c549b932.herokuapp.com/github-webhook",
         "tick_url": "https://github-commit-monitor-4a53c549b932.herokuapp.com"
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -102,7 +102,7 @@ def github_webhook():`
`102`	`102`	`# Integration JSON endpoint`
`103`	`103`	`@app.route("/integration.json", methods=["GET"])`
`104`	`104`	`def get_integration_json():`
`105`		`- base_url = os.environ.get('APP_URL', request.url_root.rstrip('/'))`
	`105`	`+ # base_url = os.environ.get('APP_URL', request.url_root.rstrip('/'))`
`106`	`106`	`integration_json = {`
`107`	`107`	`"data": {`
`108`	`108`	`"date": {`
`@@ -134,7 +134,7 @@ def get_integration_json():`
`134`	`134`	`"default": "True"`
`135`	`135`	`}`
`136`	`136`	`],`
`137`		`- "target_url": f"{base_url}/github-webhook",`
	`137`	`+ "target_url": https://github-commit-monitor-4a53c549b932.herokuapp.com/github-webhook",`
`138`	`138`	`"tick_url": "https://github-commit-monitor-4a53c549b932.herokuapp.com"`
`139`	`139`	`}`
`140`	`140`	`}`