chore(deps): update terraform terraform-ibm-modules/landing-zone/ibm to v5.28.0 (#901)

* chore(deps): update terraform terraform-ibm-modules/landing-zone/ibm to v5.28.0

* fix: added prefix to slz-edge-rg resource group as this was changed in v5.27.1 of landing-zone module

---------

Co-authored-by: ludwig-mueller <ludwig.mueller@ibm.com>

Author: terraform-ibm-modules-ops

modules/powervs-vpc-landing-zone/README.md

@@ -101,7 +101,7 @@ Creates VPC Landing Zone | Performs VPC VSI OS Config | Creates PowerVS Infrastr
 |------|--------|---------|
 | <a name="module_client_to_site_vpn"></a> [client\_to\_site\_vpn](#module\_client\_to\_site\_vpn) | terraform-ibm-modules/client-to-site-vpn/ibm | 1.7.15 |
 | <a name="module_configure_network_services"></a> [configure\_network\_services](#module\_configure\_network\_services) | ./submodules/ansible | n/a |
-| <a name="module_landing_zone"></a> [landing\_zone](#module\_landing\_zone) | terraform-ibm-modules/landing-zone/ibm//patterns//vsi//module | 5.27.0 |
+| <a name="module_landing_zone"></a> [landing\_zone](#module\_landing\_zone) | terraform-ibm-modules/landing-zone/ibm//patterns//vsi//module | 5.28.0 |
 | <a name="module_powervs_workspace"></a> [powervs\_workspace](#module\_powervs\_workspace) | terraform-ibm-modules/powervs-workspace/ibm | 2.0.0 |
 | <a name="module_private_secret_engine"></a> [private\_secret\_engine](#module\_private\_secret\_engine) | terraform-ibm-modules/secrets-manager-private-cert-engine/ibm | 1.3.2 |
 | <a name="module_secrets_manager_group"></a> [secrets\_manager\_group](#module\_secrets\_manager\_group) | terraform-ibm-modules/secrets-manager-secret-group/ibm | 1.2.2 |

modules/powervs-vpc-landing-zone/client2sitevpn.tf

@@ -63,7 +63,7 @@ resource "ibm_resource_instance" "secrets_manager" {
   service           = "secrets-manager"
   plan              = var.sm_service_plan
   location          = local.sm_region
-  resource_group_id = module.landing_zone.resource_group_data["slz-edge-rg"]
+  resource_group_id = module.landing_zone.resource_group_data["${var.prefix}-slz-edge-rg"]
   timeouts {
     create = "20m" # Extending provisioning time to 20 minutes
   }
@@ -127,7 +127,7 @@ module "client_to_site_vpn" {
   count     = var.client_to_site_vpn.enable ? 1 : 0
 
   vpn_gateway_name              = "${var.prefix}-vpc-pvs-vpn"
-  resource_group_id             = module.landing_zone.resource_group_data["slz-edge-rg"]
+  resource_group_id             = module.landing_zone.resource_group_data["${var.prefix}-slz-edge-rg"]
   access_group_name             = "${var.prefix}-client-to-site-vpn-access-group"
   subnet_ids                    = [for subnet in module.landing_zone.subnet_data : subnet.id if subnet.name == "${var.prefix}-edge-vpn-zone-1"]
   client_ip_pool                = var.client_to_site_vpn.client_ip_pool

modules/powervs-vpc-landing-zone/main.tf

@@ -4,7 +4,7 @@
 
 module "landing_zone" {
   source    = "terraform-ibm-modules/landing-zone/ibm//patterns//vsi//module"
-  version   = "5.27.0"
+  version   = "5.28.0"
   providers = { ibm = ibm.ibm-is }
 
   ssh_public_key       = var.ssh_public_key
@@ -23,7 +23,7 @@ module "vpc_file_share_alb" {
   count     = var.configure_nfs_server ? 1 : 0
 
   vpc_zone                      = "${lookup(local.ibm_powervs_zone_cloud_region_map, var.powervs_zone, null)}-1"
-  resource_group_id             = module.landing_zone.resource_group_data["slz-edge-rg"]
+  resource_group_id             = module.landing_zone.resource_group_data["${var.prefix}-slz-edge-rg"]
   file_share_name               = "${var.prefix}-file-share-nfs"
   file_share_size               = var.nfs_server_config.size
   file_share_iops               = var.nfs_server_config.iops