feat: secret endpoint type (#69)

* feat: secret endpoint type

* feat: secret endpoint type

* feat: secret endpoint type

Author: rajatagarwal-ibm

solutions/banking/main.tf

@@ -43,6 +43,7 @@ module "secrets_manager_secret_ibm_iam" {
   secret_description      = "IBM IAM Api key"
   secret_type             = "arbitrary" #checkov:skip=CKV_SECRET_6
   secret_payload_password = var.ibmcloud_api_key
+  endpoint_type           = var.secrets_endpoint_type
 }
 
 # secrets manager secrets - IBM signing key
@@ -59,6 +60,7 @@ module "secrets_manager_secret_signing_key" {
   secret_description      = "IBM Signing GPG key"
   secret_type             = "arbitrary" #checkov:skip=CKV_SECRET_6
   secret_payload_password = var.signing_key
+  endpoint_type           = var.secrets_endpoint_type
 }
 
 # secrets manager secrets - WATSONX ADMIN API KEY
@@ -75,6 +77,7 @@ module "secrets_manager_secret_watsonx_admin_api_key" {
   secret_description      = "WatsonX Admin API Key"
   secret_type             = "arbitrary" #checkov:skip=CKV_SECRET_6
   secret_payload_password = var.watsonx_admin_api_key
+  endpoint_type           = var.secrets_endpoint_type
 }
 
 

solutions/banking/variables.tf

@@ -107,6 +107,12 @@ variable "create_secrets" {
   default     = true
 }
 
+variable "secrets_endpoint_type" {
+  type        = string
+  description = "The endpoint type to communicate with the provided secrets manager instance. Possible values are `public` or `private`"
+  default     = "private"
+}
+
 variable "secrets_manager_guid" {
   description = "Secrets Manager GUID where the API key and signing key will be stored."
   type        = string

tests/pr_test.go

@@ -82,6 +82,7 @@ func TestRunBankingSolutions(t *testing.T) {
 				"secrets_manager_region":                         region,
 				"signing_key":                                    terraform.Output(t, existingTerraformOptions, "signing_key"),
 				"trigger_ci_pipeline_run":                        false,
+				"secrets_endpoint_type":                          "public",
 			},
 		})