feat: exposed the ability to set the provider_visibility in the DA [Learn more](https://registry.terraform.io/providers/IBM-Cloud/IBM/latest/docs#visibility-1)(#227)

Author: Aditya-ranjan-16

README.md

@@ -159,6 +159,7 @@ statement instead the previous block.
 | <a name="input_existing_studio_instance"></a> [existing\_studio\_instance](#input\_existing\_studio\_instance) | CRN of the an existing Watson Studio instance. | `string` | `null` | no |
 | <a name="input_ibmcloud_api_key"></a> [ibmcloud\_api\_key](#input\_ibmcloud\_api\_key) | The API key that's used with the IBM Cloud Terraform IBM provider. | `string` | n/a | yes |
 | <a name="input_location"></a> [location](#input\_location) | The location that's used with the IBM Cloud Terraform IBM provider. It's also used during resource creation. | `string` | `"us-south"` | no |
+| <a name="input_provider_visibility"></a> [provider\_visibility](#input\_provider\_visibility) | Set the visibility value for the IBM terraform provider. Supported values are `public`, `private`, `public-and-private`. [Learn more](https://registry.terraform.io/providers/IBM-Cloud/ibm/latest/docs/guides/custom-service-endpoints). | `string` | `"private"` | no |
 | <a name="input_resource_group_name"></a> [resource\_group\_name](#input\_resource\_group\_name) | The name of a new or an existing resource group where the resources are created. | `string` | n/a | yes |
 | <a name="input_resource_prefix"></a> [resource\_prefix](#input\_resource\_prefix) | The name to be used on all Watson resources as a prefix. | `string` | `"watsonx-poc"` | no |
 | <a name="input_use_existing_resource_group"></a> [use\_existing\_resource\_group](#input\_use\_existing\_resource\_group) | Determines whether to use an existing resource group. | `bool` | `false` | no |

cra-config.yaml

@@ -8,3 +8,4 @@ CRA_TARGETS:
       TF_VAR_watsonx_admin_api_key: "fake_value"
       TF_VAR_resource_group_name: "test"
       TF_VAR_cos_kms_crn: "crn:v1:bluemix:public:kms:us-south:a/abac0df06b644a9cabc6e44f55b3880e:a20230fb-9ec3-4376-a27d-8ca21a94728a::"
+      TF_VAR_provider_visibility: "public"

ibm_catalog.json

@@ -72,6 +72,23 @@
               "required": true,
               "type": "password"
             },
+            {
+              "key": "provider_visibility",
+              "options": [
+                {
+                  "displayname": "private",
+                  "value": "private"
+                },
+                {
+                  "displayname": "public",
+                  "value": "public"
+                },
+                {
+                  "displayname": "public-and-private",
+                  "value": "public-and-private"
+                }
+              ]
+            },
             {
               "key": "location",
               "type": "string",

providers.tf

@@ -2,12 +2,14 @@ provider "ibm" {
   alias            = "deployer"
   ibmcloud_api_key = var.ibmcloud_api_key
   region           = var.location
+  visibility       = var.provider_visibility
 }
 
 provider "ibm" {
   alias            = "watsonx_admin"
   ibmcloud_api_key = var.watsonx_admin_api_key == null || var.watsonx_admin_api_key == "" ? var.ibmcloud_api_key : var.watsonx_admin_api_key
   region           = var.location
+  visibility       = var.provider_visibility
 }
 
 

tests/pr_test.go

@@ -66,6 +66,7 @@ func setupOptionsRootDA(t *testing.T, prefix string, dir string) *testhelper.Tes
 			"location":                  validRegions[rand.Intn(len(validRegions))],
 			"resource_group_name":       prefix,
 			"enable_cos_kms_encryption": false,
+			"provider_visibility":       "public",
 		},
 	})
 
@@ -153,6 +154,7 @@ func TestWithExistingKP(t *testing.T) {
 			TerraformVars: map[string]interface{}{
 				"location":            validRegions[rand.Intn(len(validRegions))],
 				"resource_group_name": prefix,
+				"provider_visibility": "public",
 				"cos_kms_crn":         terraform.Output(t, existingTerraformOptions, "key_protect_crn"),
 				"cos_kms_key_crn":     terraform.Output(t, existingTerraformOptions, "kms_key_crn"),
 			},

variables.tf

@@ -3,7 +3,16 @@ variable "ibmcloud_api_key" {
   sensitive   = true
   type        = string
 }
+variable "provider_visibility" {
+  description = "Set the visibility value for the IBM terraform provider. Supported values are `public`, `private`, `public-and-private`. [Learn more](https://registry.terraform.io/providers/IBM-Cloud/ibm/latest/docs/guides/custom-service-endpoints)."
+  type        = string
+  default     = "private"
 
+  validation {
+    condition     = contains(["public", "private", "public-and-private"], var.provider_visibility)
+    error_message = "Invalid visibility option. Allowed values are 'public', 'private', or 'public-and-private'."
+  }
+}
 variable "watsonx_admin_api_key" {
   default     = null
   description = "The API key of the IBM watsonx administrator in the target account. The API key is used to configure the user and the project."