remove cookies all together

Author: Jay-Lalwani

tcf_core/context_processors.py

@@ -1,7 +1,5 @@
 """Inject extra context to TCF templates."""
 
-import ast
-
 from django.conf import settings
 
 from tcf_website.models import Discipline, Semester, Subdepartment
@@ -16,33 +14,6 @@ def base(request):
     }
 
 
-def history_cookies(request):
-    """Puts history from cookies into context variables."""
-    if "previous_paths" in request.COOKIES:
-        previous_paths = request.COOKIES["previous_paths"]
-        previous_paths = ast.literal_eval(previous_paths)
-    else:
-        previous_paths = ""
-
-    if "previous_paths_titles" in request.COOKIES:
-        previous_paths_titles = request.COOKIES["previous_paths_titles"]
-        previous_paths_titles = ast.literal_eval(previous_paths_titles)
-    else:
-        previous_paths_titles = ""
-
-    previous_paths_titles = [title[:80] for title in previous_paths_titles]
-
-    previous_paths_and_titles = None
-    if len(previous_paths) > 0 and len(previous_paths_titles) > 0:
-        previous_paths_and_titles = zip(previous_paths, previous_paths_titles)
-
-    return {
-        "previous_paths": previous_paths,
-        "previous_path_titles": previous_paths_titles,
-        "previous_paths_and_titles": previous_paths_and_titles,
-    }
-
-
 def searchbar_context(request):
     """Provide context for the search bar."""
     latest_semester = Semester.latest()

tcf_core/settings/base.py

@@ -131,7 +131,6 @@
                 "django.contrib.auth.context_processors.auth",
                 "django.contrib.messages.context_processors.messages",
                 "tcf_core.context_processors.base",
-                "tcf_core.context_processors.history_cookies",
                 "tcf_core.context_processors.searchbar_context",
             ],
         },

tcf_core/settings/record_middleware.py

@@ -1,34 +1,22 @@
 """Middleware for recording cookie information."""
 
-import ast
-
 
 class RecordMiddleware:  # pylint: disable=too-few-public-methods
-    """Records information about course section info into cookies."""
+    """
+    Previously recorded course section info into cookies.
+    Now does nothing as this functionality has been moved to client-side
+    localStorage to avoid polluting Django sessions.
+    """
 
     def __init__(self, get_response):
         self.get_response = get_response
 
     def __call__(self, request):
-        if "previous_paths_titles" in request.COOKIES:
-            previous_paths = request.COOKIES["previous_paths"]
-            # Converts string representation of list into list object
-            previous_paths = ast.literal_eval(previous_paths)
-
-            previous_paths_titles = request.COOKIES["previous_paths_titles"]
-            # Converts string representation of list into list object
-            previous_paths_titles = ast.literal_eval(previous_paths_titles)
-        else:
-            previous_paths = []
-            previous_paths_titles = []
-
         # Process the request and get response
         response = self.get_response(request)
 
-        # We no longer manage history through the middleware
-        # This is now handled by client-side JavaScript using localStorage
-        # The cookie is still retained for backwards compatibility
-        # but it's populated by JavaScript, not by the middleware
+        # We no longer set cookies for history tracking
+        # All history is now managed via localStorage in the browser
 
         return response
 

tcf_website/static/common/recently_viewed.js

@@ -79,21 +79,4 @@ function saveCourseInfoIfPresent() {
     "previous_paths_titles",
     JSON.stringify(previousPathsTitles),
   );
-
-  // Also set cookies for compatibility with existing server-side code
-  setCookie("previous_paths", JSON.stringify(previousPaths), 30);
-  setCookie("previous_paths_titles", JSON.stringify(previousPathsTitles), 30);
-}
-
-/**
- * Helper function to set cookies
- */
-function setCookie(name, value, days) {
-  let expires = "";
-  if (days) {
-    const date = new Date();
-    date.setTime(date.getTime() + days * 24 * 60 * 60 * 1000);
-    expires = "; expires=" + date.toUTCString();
-  }
-  document.cookie = name + "=" + (value || "") + expires + "; path=/";
 }

tcf_website/templates/common/history_page_modal.html

@@ -12,16 +12,62 @@ <h5 class="modal-title font-weight-bold">Recently Viewed</h5>
             </div>
             <div class="modal-body py-0 px-4">
                 <div class="text-center">
-                    {% if previous_paths_and_titles is None %}
+                    <div id="history-items-container">
                         <p class="text-muted my-4">No course sections viewed yet.</p>
-                    {% endif %}
-                    <div class="list-group list-group-flush mb-3">
-                    {% for path, title in previous_paths_and_titles %}
-                        <a class="list-group-item list-group-item-action border-left-0 border-right-0 rounded-0" href={{path}}>{{title}}</a>
-                    {% endfor %}
                     </div>
                 </div>
             </div>
         </div>
     </div>
 </div>
+
+<script>
+// Load and display history from localStorage when the modal is opened
+document.addEventListener('DOMContentLoaded', function() {
+    // Get the modal element
+    const historyModal = document.getElementById('{{ path_id }}');
+    
+    // Add event listener for when the modal is shown
+    $(historyModal).on('show.bs.modal', function() {
+        loadHistoryFromLocalStorage();
+    });
+    
+    // Function to load history from localStorage
+    function loadHistoryFromLocalStorage() {
+        const container = document.getElementById('history-items-container');
+        
+        try {
+            // Get history from localStorage
+            const paths = JSON.parse(localStorage.getItem('previous_paths') || '[]');
+            const titles = JSON.parse(localStorage.getItem('previous_paths_titles') || '[]');
+            
+            // Clear the container
+            container.innerHTML = '';
+            
+            // If no history, show message
+            if (paths.length === 0 || titles.length === 0) {
+                container.innerHTML = '<p class="text-muted my-4">No course sections viewed yet.</p>';
+                return;
+            }
+            
+            // Create list group
+            const listGroup = document.createElement('div');
+            listGroup.className = 'list-group list-group-flush mb-3';
+            
+            // Add each history item
+            for (let i = 0; i < Math.min(paths.length, titles.length); i++) {
+                const link = document.createElement('a');
+                link.className = 'list-group-item list-group-item-action border-left-0 border-right-0 rounded-0';
+                link.href = paths[i];
+                link.textContent = titles[i];
+                listGroup.appendChild(link);
+            }
+            
+            container.appendChild(listGroup);
+        } catch (e) {
+            console.error('Error loading history from localStorage:', e);
+            container.innerHTML = '<p class="text-muted my-4">Error loading history.</p>';
+        }
+    }
+});
+</script>