Skip to content

Commit 5143086

Browse files
authored
Merge pull request #1113 from thecourseforum/fixing-open-section-filter
fixing open section filter
2 parents de65341 + ef51e67 commit 5143086

File tree

1 file changed

+6
-7
lines changed

1 file changed

+6
-7
lines changed

tcf_website/views/search.py

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -198,13 +198,6 @@ def filter_courses(filters):
198198
# Apply filters
199199
results = apply_filters(results, filters)
200200

201-
# Filter for open sections
202-
if filters.get("open_sections"):
203-
open_sections_filtered = Course.filter_by_open_sections()
204-
results = results.filter(
205-
id__in=open_sections_filtered.values_list("id", flat=True)
206-
)
207-
208201
results = results.distinct().order_by("subdepartment__mnemonic", "number")[:15]
209202

210203
# Convert to same format as fetch_courses
@@ -248,4 +241,10 @@ def apply_filters(results, filters):
248241
)
249242
results = results.filter(id__in=time_filtered.values_list("id", flat=True))
250243

244+
if filters.get("open_sections"):
245+
open_sections_filtered = Course.filter_by_open_sections()
246+
results = results.filter(
247+
id__in=open_sections_filtered.values_list("id", flat=True)
248+
)
249+
251250
return results

0 commit comments

Comments
 (0)