cranktakular: nits

Author: shazbert

exchanges/binance/binance.go

@@ -118,10 +118,6 @@ func (e *Exchange) GetExchangeInfo(ctx context.Context) (ExchangeInfo, error) {
 }
 
 // GetOrderBook returns full orderbook information
-//
-// OrderBookDataRequestParams contains the following members
-// symbol: string of currency pair
-// limit: returned limit amount
 func (e *Exchange) GetOrderBook(ctx context.Context, pair currency.Pair, limit int) (*OrderBookResponse, error) {
 	params := url.Values{}
 	symbol, err := e.FormatSymbol(pair, asset.Spot)

exchanges/binance/binance_websocket.go

@@ -461,6 +461,8 @@ func (e *Exchange) SeedLocalCacheWithBook(p currency.Pair, orderbookNew *OrderBo
 	t := orderbookNew.Timestamp.Time()
 	if t.IsZero() {
 		t = time.Now() // Time not provided for this REST book.
+	} else {
+		fmt.Println("Using server time for orderbook", p)
 	}
 	newOrderBook := orderbook.Book{
 		Pair:              p,

exchanges/binanceus/binanceus_types.go

@@ -162,12 +162,6 @@ func (a *AggregatedTrade) toTradeData(p currency.Pair, exchange string, aType as
 	}
 }
 
-// OrderbookItem stores an individual orderbook item
-type OrderbookItem struct {
-	Price    float64
-	Quantity float64
-}
-
 // OrderBookData is resp data from orderbook endpoint
 type OrderBookData struct {
 	LastUpdateID int64                            `json:"lastUpdateId"`

exchanges/binanceus/binanceus_wrapper.go

@@ -318,12 +318,10 @@ func (e *Exchange) UpdateOrderbook(ctx context.Context, pair currency.Pair, asse
 	if err := e.CurrencyPairs.IsAssetEnabled(assetType); err != nil {
 		return nil, err
 	}
-
 	orderbookNew, err := e.GetOrderBookDepth(ctx, pair, 1000)
 	if err != nil {
 		return nil, err
 	}
-
 	if err := (&orderbook.Book{
 		Exchange:          e.Name,
 		Pair:              pair,

exchanges/btcmarkets/btcmarkets_types.go

@@ -52,12 +52,6 @@ type tempOrderbook struct {
 	Bids       orderbook.LevelsArrayPriceAmount `json:"bids"`
 }
 
-// OBData stores orderbook data
-type OBData struct {
-	Price  float64
-	Volume float64
-}
-
 // Orderbook holds current orderbook information returned from the exchange
 type Orderbook struct {
 	MarketID   currency.Pair

exchanges/gateio/gateio_test.go

@@ -3558,3 +3558,13 @@ func TestWebsocketSubmitOrders(t *testing.T) {
 	_, err = e.WebsocketSubmitOrders(request.WithVerbose(t.Context()), []*order.Submit{sub, &cpy})
 	require.NoError(t, err)
 }
+
+func TestUnmarshalJSONOrderbookLevels(t *testing.T) {
+	t.Parallel()
+	var ob OrderbookLevels
+	require.NoError(t, ob.UnmarshalJSON([]byte(`[{"p":"123.45","s":"0.001"}]`)))
+	assert.Equal(t, 123.45, ob[0].Price)
+	assert.Equal(t, 0.001, ob[0].Amount)
+
+	require.Error(t, ob.UnmarshalJSON([]byte(`["p":"123.45","s":"0.001"]`)))
+}

exchanges/gateio/gateio_wrapper.go

@@ -678,7 +678,7 @@ func (e *Exchange) UpdateOrderbookWithLimit(ctx context.Context, p currency.Pair
 		Exchange:          e.Name,
 		Asset:             a,
 		ValidateOrderbook: e.ValidateOrderbook,
-		Pair:              p.Upper(),
+		Pair:              p,
 		LastUpdateID:      o.ID,
 		LastUpdated:       o.Update.Time(),
 		LastPushed:        o.Current.Time(),

exchanges/orderbook/orderbook_test.go

@@ -566,7 +566,7 @@ func TestLevelsArrayPriceAmountUnmarshalJSON(t *testing.T) {
 	t.Parallel()
 
 	var asks LevelsArrayPriceAmount
-	err := asks.UnmarshalJSON([]byte(`[[1,2],[3,4]]`))
+	err := asks.UnmarshalJSON([]byte(`[[1,2],["3","4"]]`))
 	require.NoError(t, err)
 	assert.Len(t, asks, 2)
 	assert.Equal(t, 1.0, asks[0].Price)

exchanges/poloniex/poloniex_types.go

@@ -41,12 +41,6 @@ type OrderbookResponse struct {
 	Seq      int64                            `json:"seq"`
 }
 
-// OrderbookItem holds data on an individual item
-type OrderbookItem struct {
-	Price  float64
-	Amount float64
-}
-
 // OrderbookAll contains the full range of orderbooks
 type OrderbookAll struct {
 	Data map[string]Orderbook