some refactory

Author: tiamo

src/Management.php

@@ -55,8 +55,6 @@ public function __construct($options = [])
      * @param string $encoding
      *
      * @return MimePart
-     *
-     * @noinspection PhpUnused
      */
     public function buildMessageFromFile(
         MessageInterface $message,
@@ -641,24 +639,29 @@ public function buildMdn(MessageInterface $message, $confirmationText = null, $e
      * Sends the AS2 MDN to the partner.
      *
      * @return bool|mixed|ResponseInterface
+     * @noinspection PhpDocMissingThrowsInspection
      */
     public function sendMdn(MessageInterface $message)
     {
-        // TODO: cron, queue, new thread
         try {
             $partner = $message->getSender();
             $mdn     = MimePart::fromString($message->getMdnPayload());
+
             $options = [
                 'body'    => $mdn->getBody(),
                 'headers' => $mdn->getHeaders(),
             ];
+
             if ($partner->getAuthMethod()) {
                 $options['auth'] = [$partner->getAuthUser(), $partner->getAuthPassword(), $partner->getAuthMethod()];
             }
+
+            /** @noinspection PhpUnhandledExceptionInspection */
             $response = $this->getHttpClient()->post($partner->getTargetUrl(), $options);
             if ($response->getStatusCode() !== 200) {
                 throw new \RuntimeException('Message send failed with error');
             }
+
             $this->getLogger()->debug('AS2 MDN has been sent.');
             $message->setMdnStatus(MessageInterface::MDN_STATUS_SENT);
 
@@ -683,6 +686,16 @@ public function getHttpClient()
         return $this->httpClient;
     }
 
+    // /**
+    //  * @return $this
+    //  */
+    // public function setHttpClient(ClientInterface $client)
+    // {
+    //     $this->httpClient = $client;
+    //
+    //     return $this;
+    // }
+
     /**
      * @param string $name
      * @param string $default

src/Server.php

@@ -172,6 +172,8 @@ public function execute(ServerRequestInterface $request = null)
                                     $messageId
                                 )
                             );
+
+                            // TODO: async, event, queue, etc.
                             $this->manager->sendMdn($message);
                         }
                     }