Possible Scheme Issues.

[j-c-m]

I am sanity checking themes, I will follow-up, here are some possible issues I have flagged so far.

base16 Blueish (base16-blueish.json)

Issues Found

• Adjacent colors ansi-3-hex and ansi-4-hex are identical (#82aaff)
• Adjacent colors ansi-11-hex and ansi-12-hex are identical (#82aaff)

base16 Charcoal Dark (base16-charcoal-dark.json)

Issues Found

• Adjacent colors ansi-5-hex and ansi-6-hex are identical (#a28662)
• Adjacent colors ansi-13-hex and ansi-14-hex are identical (#a28662)

base16 Edge Light (base16-edge-light.json)

Issues Found

• Adjacent colors ansi-7-hex and ansi-8-hex are identical (#5e646f)

base16 eris (base16-eris.json)

Issues Found

• Adjacent colors ansi-2-hex and ansi-3-hex are identical (#faaea2)
• Adjacent colors ansi-10-hex and ansi-11-hex are identical (#faaea2)

base16 Green Screen (base16-green-screen.json)

Issues Found

• Adjacent colors ansi-8-hex and ansi-9-hex are identical (#007700)

base16 Material Lighter (base16-material-lighter.json)

Issues Found

• foreground-hex (#80cbc4) on background-hex (#fafafa) fails WCAG contrast (ratio: 1.79, required: 2.00)

base16 Tokyo Night Moon (base16-tokyo-night-moon.json)

Issues Found

• foreground-hex (#3b4261) on background-hex (#222436) fails WCAG contrast (ratio: 1.56, required: 2.00)

base24 Builtin Solarized Light (base24-builtin-solarized-light.json)

Issues Found

• foreground-hex (#b2b8ad) on background-hex (#fdf6e3) fails WCAG contrast (ratio: 1.88, required: 2.00)

base24 Fideloper (base24-fideloper.json)

Issues Found

• Adjacent colors ansi-9-hex and ansi-10-hex are identical (#d35f5a)

base24 Galaxy (base24-galaxy.json)

Issues Found

• Adjacent colors ansi-3-hex and ansi-4-hex are identical (#589cf5)

base24 Later This Evening (base24-later-this-evening.json)

Issues Found

• foreground-hex (#3e3f3f) on background-hex (#212121) fails WCAG contrast (ratio: 1.52, required: 2.00)

base24 Man Page (base24-man-page.json)

Issues Found

• foreground-hex (#b2b2b2) on background-hex (#fef49c) fails WCAG contrast (ratio: 1.88, required: 2.00)

base24 Material (base24-material.json)

Issues Found

• foreground-hex (#c3c3c3) on background-hex (#eaeaea) fails WCAG contrast (ratio: 1.47, required: 2.00)

base24 Monokai Vivid (base24-monokai-vivid.json)

Issues Found

• Adjacent colors ansi-3-hex and ansi-4-hex are identical (#0442fe)

base24 Night Owlish Light (base24-night-owlish-light.json)

Issues Found

• Adjacent colors ansi-7-hex and ansi-8-hex are identical (#7a8181)

base24 One Half Light (base24-one-half-light.json)

Issues Found

• foreground-hex (#cfd0d2) on background-hex (#fafafa) fails WCAG contrast (ratio: 1.48, required: 2.00)

base24 Pencil Light (base24-pencil-light.json)

Issues Found

• foreground-hex (#b3b3b3) on background-hex (#f1f1f1) fails WCAG contrast (ratio: 1.86, required: 2.00)

base24 Piatto Light (base24-piatto-light.json)

Issues Found

• foreground-hex (#cfcfcf) on background-hex (#ffffff) fails WCAG contrast (ratio: 1.56, required: 2.00)
• Adjacent colors ansi-3-hex and ansi-4-hex are identical (#3c5ea8)

base24 Pro Light (base24-pro-light.json)

Issues Found

• foreground-hex (#cccccc) on background-hex (#feffff) fails WCAG contrast (ratio: 1.60, required: 2.00)

base24 Tango Adapted (base24-tango-adapted.json)

Issues Found

• foreground-hex (#d0d4cb) on background-hex (#fffefe) fails WCAG contrast (ratio: 1.49, required: 2.00)

base24 Tango Half Adapted (base24-tango-half-adapted.json)

Issues Found

• foreground-hex (#c6cac1) on background-hex (#fffefe) fails WCAG contrast (ratio: 1.65, required: 2.00)

base24 Unikitty (base24-unikitty.json)

Issues Found

• foreground-hex (#b9b1b8) on background-hex (#ff8cd9) fails WCAG contrast (ratio: 1.00, required: 2.00)

[j-c-m]

Updated my check logic, base24-unikitty needs further checking, a few of the other base24 themese have a low contrast between foreground and background, just making sure that is intentional.

[JamyGolden]

This is a great list! All of these issues (including the base24 ones you mentioned) aren't intentional and we should fix them.

[JamyGolden]

Someone else mentioned base16-tokyo-night-moon as an issue: tinted-theming/base16-zed#3 (comment). Linking to gather everything in one place.

[j-c-m]

It seems like one of the issues is from themes imported from other systems that have a seperate foreground & ansi7 (base05) definition, whereas the base16/24 themes don't. In their templates when the output system doesn't have a seperation, they actually put the foreground color in for ansi7.

[JamyGolden]

Yeah we just need to use the ansi7 for white and leave out the official theme foreground since base16 doesn’t support that difference.