Remove redundant function solve( for relaxation integrators (#2509)

Author: DanielDoehring

src/time_integration/relaxation_methods/methods_subdiagonal.jl

@@ -51,7 +51,8 @@ For details on the relaxation procedure, see
 Currently implemented are the third-order, three-stage method by Ralston [`Ralston3`](@ref) 
 and the canonical fourth-order, four-stage method by Kutta [`RK44`](@ref).
 """
-abstract type SubDiagonalRelaxationAlgorithm <: AbstractTimeIntegrationAlgorithm end
+abstract type SubDiagonalRelaxationAlgorithm <:
+              AbstractRelaxationTimeIntegrationAlgorithm end
 
 """
     Ralston3()
@@ -196,16 +197,6 @@ function init(ode::ODEProblem, alg::SubDiagonalRelaxationAlgorithm;
     return integrator
 end
 
-# Fakes `solve`: https://diffeq.sciml.ai/v6.8/basics/overview/#Solving-the-Problems-1
-function solve(ode::ODEProblem,
-               alg::SubDiagonalRelaxationAlgorithm;
-               dt, callback = nothing, kwargs...)
-    integrator = init(ode, alg, dt = dt, callback = callback; kwargs...)
-
-    # Start actual solve
-    solve!(integrator)
-end
-
 function step!(integrator::SubDiagonalRelaxationIntegrator)
     @unpack prob = integrator.sol
     @unpack alg = integrator

src/time_integration/relaxation_methods/methods_vanderHouwen.jl

@@ -30,7 +30,7 @@ Currently implemented methods are the Carpenter-Kennedy-Lewis 4-stage, 3rd-order
 and the Carpenter-Kennedy-Lewis 5-stage, 4th-order method [`CKL54`](@ref) which are optimized for the 
 compressible Navier-Stokes equations.
 """
-abstract type vanderHouwenAlgorithm end
+abstract type vanderHouwenAlgorithm <: AbstractTimeIntegrationAlgorithm end
 
 """
     vanderHouwenRelaxationAlgorithm
@@ -53,7 +53,8 @@ Currently implemented methods are the Carpenter-Kennedy-Lewis 4-stage, 3rd-order
 and the Carpenter-Kennedy-Lewis 5-stage, 4th-order method [`RelaxationCKL54`](@ref) which are optimized for the 
 compressible Navier-Stokes equations.
 """
-abstract type vanderHouwenRelaxationAlgorithm end
+abstract type vanderHouwenRelaxationAlgorithm <:
+              AbstractRelaxationTimeIntegrationAlgorithm end
 
 """
     CKL43()
@@ -233,16 +234,6 @@ function init(ode::ODEProblem, alg::vanderHouwenRelaxationAlgorithm;
     return integrator
 end
 
-# Fakes `solve`: https://diffeq.sciml.ai/v6.8/basics/overview/#Solving-the-Problems-1
-function solve(ode::ODEProblem,
-               alg::vanderHouwenRelaxationAlgorithm;
-               dt, callback = nothing, kwargs...)
-    integrator = init(ode, alg, dt = dt, callback = callback; kwargs...)
-
-    # Start actual solve
-    solve!(integrator)
-end
-
 function step!(integrator::vanderHouwenRelaxationIntegrator)
     @unpack prob = integrator.sol
     @unpack alg = integrator
@@ -301,7 +292,7 @@ function step!(integrator::vanderHouwenRelaxationIntegrator)
 
             bsminus1_minus_as = alg.b[stage - 1] - alg.a[stage]
             @threaded for i in eachindex(integrator.u)
-                # Try to enable optimizations due to `muladd` by avoidin `+=`
+                # Try to enable optimizations due to `muladd` by avoiding `+=`
                 # https://github.com/trixi-framework/Trixi.jl/pull/2480#discussion_r2224531702
                 integrator.direction[i] = integrator.direction[i] +
                                           bs_dt * integrator.du[i]

src/time_integration/relaxation_methods/relaxation_methods.jl

@@ -1,3 +1,5 @@
+abstract type AbstractRelaxationTimeIntegrationAlgorithm <: AbstractTimeIntegrationAlgorithm end
+
 abstract type RelaxationIntegrator <: AbstractTimeIntegrator end
 
 get_tmp_cache(integrator::RelaxationIntegrator) = (integrator.u_tmp,)