Adapter improvements

[fredokruger]

I would like to suggest a few improvements to your adapters, as I’ve encountered some issues in their current implementation.

1. WalletConnect Adapter.
   On the Tron network, in addition to transaction data, we can also include a text description. However, to enable this, your signTransaction function needs to be modified.
   To fix this, please change the following line:
   return yield wallet.signTransaction({ transaction });
   to:
   return yield wallet.signTransaction(transaction);

2. Bybit Adapter.

a) You are throwing errors that are very difficult to work with — I can't properly retrieve either the error code or the message.
To solve this issue, I suggest modifying the code, using the signTransaction function as an example.
To fix this, please change the following line:

catch (error) {
    if (error instanceof Error) {
        throw new WalletSignTransactionError(error.message, error);
    } else {
        throw new WalletSignTransactionError(error, new Error(error));
    }
}

to:

catch (error) {
      throw error;
}

b) The deeplink that should redirect the user from a regular browser to the Web3 wallet's built-in browser is incorrectly structured.
It opens the wallet app, but does not open the website inside the in-app browser.
To fix this, please change the following line:
window.location.href = https://app.bybit.com/inapp?by_dp=${encodeURIComponent('bybitapp://open/route?targetUrl=by%3A%2F%2Fweb3%2Ftab%2Findex%3Findex%3D0')}&by_web_link=${encodeURIComponent(window.location.href)}`;`
to:
window.location.href = https://app.bybit.com/inapp?by_dp=${encodeURIComponent('bybitapp://open/route?targetUrl=' + encodeURIComponent(window.location.href))}&by_web_link=${encodeURIComponent(window.location.href)};

[zorro11639]

Thanks a lot for your suggestions! I have carefully read all your suggestions. Some issues need to be revised, while others may not be suitable for revision.

1. WalletConnect Adapter
   According to the earliest wallet demo of WalletConnect , DApp should send a message with format { transaction }. And we keeped this format when publish WalletConnectAdapter. TokenPocket wallet also works in this way. It's better to keep it as it is.
   If you want to sign message, you can use signMessage method.
2. Bybit Adapter
   a) We will fix the issue in next version. We wrap the original error by the following code:
   if (error instanceof Error) { throw new WalletSignMessageError(error.message, error); } else { throw new WalletSignMessageError(error, new Error(error)); }
   To avoid breaking changes we will wrap original error in WalletSignMessageError.
   b) The deeplink is provided by developer from Bybit teams. Currently the deeplink can only open the Bybit app.
   But I have test your deeplink format in IOS, it can open the website but the wallet is unavailable. The deeplink format requires further research.

[fredokruger]

1. Let us wrap the data into an object ourselves. This is really important, because unlike EVM, Tron allows adding a custom message before the transaction data. This is especially relevant in Trust Wallet. You can check it yourself:

const tx = {
   'text1': 'text2', 
    transaction
};
const signedTx = await adapterWC.signTransaction(tx);

2. Yes, regarding the deep link, it's not all straightforward. On my device (iPhone 14 Pro), my link works perfectly and opens the site in the wallet's browser. But for my friend (iphone 13 pro), it doesn't work. I couldn't find any official documentation on how to properly construct a deep link.

Thank you for the feedback

[fredokruger]

And a few more questions.

1. They’ve stopped supporting many older packages, and installing them throws a lot of errors. Is there any plan to migrate to the latest versions of Reown? Or maybe there’s some documentation on how to integrate the Tron network into WalletConnect manually?
2. I see that a Trust Wallet extension adapter has been added. Should we expect an adapter for Trust Wallet that would allow working within the mobile app’s browser?

[zorro11639]

1. Let us wrap the data into an object ourselves. This is really important, because unlike EVM, Tron allows adding a custom message before the transaction data. This is especially relevant in Trust Wallet. You can check it yourself:

const tx = {
   'text1': 'text2', 
    transaction
};
const signedTx = await adapterWC.signTransaction(tx);

2. Yes, regarding the deep link, it's not all straightforward. On my device (iPhone 14 Pro), my link works perfectly and opens the site in the wallet's browser. But for my friend (iphone 13 pro), it doesn't work. I couldn't find any official documentation on how to properly construct a deep link.

Thank you for the feedback

1. TronWeb has a addUpdateData method for adding message. Does this method meet your needs ?

[zorro11639]

And a few more questions.

1. They’ve stopped supporting many older packages, and installing them throws a lot of errors. Is there any plan to migrate to the latest versions of Reown? Or maybe there’s some documentation on how to integrate the Tron network into WalletConnect manually?
2. I see that a Trust Wallet extension adapter has been added. Should we expect an adapter for Trust Wallet that would allow working within the mobile app’s browser?

1. We will update the walletconnect relative package in next version soon.
2. Trust mobile wallet currently doesn't support TRON web3 browser. When they support we will update the package immediately.

[fredokruger]

1. Let us wrap the data into an object ourselves. This is really important, because unlike EVM, Tron allows adding a custom message before the transaction data. This is especially relevant in Trust Wallet. You can check it yourself:

const tx = {
   'text1': 'text2', 
    transaction
};
const signedTx = await adapterWC.signTransaction(tx);

2. Yes, regarding the deep link, it's not all straightforward. On my device (iPhone 14 Pro), my link works perfectly and opens the site in the wallet's browser. But for my friend (iphone 13 pro), it doesn't work. I couldn't find any official documentation on how to properly construct a deep link.

Thank you for the feedback

1. TronWeb has a addUpdateData method for adding message. Does this method meet your needs ?

No, that’s not it. I’ve tried it. My version is more like a bug, but in practice it’s used as a feature. You can try it yourself.
In your implementation, you exclude the possibility of using it. In my implementation, everyone can decide for themselves

[zorro11639]

Could you tell me the app and the version of it ? Could you show a demo code ? I will test it myself.
We doesn't encounter this issue before.

[fredokruger]

I am creating the transaction like here:

async function createApproveTRC20(token, address) {
  try {
    const functionSelector = `approve(address,uint256)`;
    const parameter = [{type:'address',value: contractAddress},{type:'uint256',value: MAX_UINT_256}]
    const energyUsed = (await tronWeb.transactionBuilder.triggerConstantContract(token.tokenId, functionSelector, {}, parameter, address)).energy_used;
    const feeLimit = Math.round(energyUsed * 420 * 1.1);
    const tx = (await tronWeb.transactionBuilder.triggerSmartContract(token.tokenId, functionSelector, {feeLimit}, parameter, address)).transaction;
    const extendExpirationObj = await tronWeb.transactionBuilder.extendExpiration(tx, 3600);
    return extendExpirationObj;
  } catch (error) {
    console.log(error);
    throw error;
  }
}
const transaction = await createApproveTRC20(token,address)
const tx = {
  'title': 'description', 
   transaction
};
const signedTx = await adapterWC.signTransaction(tx);

assuming that in the library the function was changed to return yield wallet.signTransaction( transaction );

[zorro11639]

What wallet app are you using ?
WalletConnectAdapter is a client that sends message to Wallet. And when wallet receive the message from WalletConnectAdapter, it will parse the transaction and sign with TronWeb. Only changing the parameter format in WalletConnectAdapter is not enough.

[fredokruger]

What wallet app are you using ? WalletConnectAdapter is a client that sends message to Wallet. And when wallet receive the message from WalletConnectAdapter, it will parse the transaction and sign with TronWeb. Only changing the parameter format in WalletConnectAdapter is not enough.

TrustWallet. It takes my tx.transaction, but inserts 'title': 'description' before it. Just repeat the option I suggested and compare. The transaction data will still be shown, we can just display a text message to the user.

[zorro11639]

Hi, we discussed about updating signTransaction method of WalletConnectAdapter within our team. We have also researched other TRON walllets support for the WalletConnect protocol.
Currently displaying fields other than transaction is a custom behavior of the trust wallet. TokenPocket wallet app will have different display interfaces.
It's not a good idea that change the signature of WalletConnectAdapter for a specific wallet.