Fix all linter warnings

- Replace for-loop with where clause in ComplexProtoTests.swift
- Add blank lines after first sentences in documentation comments
- Add missing period in parseExtendDeclaration documentation
- Maintain 100% test success rate (1086/1086 tests)
- Preserve excellent code coverage (94.73% lines, 93.00% functions)

Author: truewebber

Sources/SwiftProtoParser/DescriptorBuilder/DescriptorBuilder.swift

@@ -3,55 +3,57 @@ import SwiftProtobuf
 
 /// Main descriptor builder that converts ProtoAST to swift-protobuf FileDescriptorProto.
 public struct DescriptorBuilder {
-  
+
   /// Convert ProtoAST to FileDescriptorProto.
-  public static func buildFileDescriptor(from ast: ProtoAST, fileName: String) throws -> Google_Protobuf_FileDescriptorProto {
+  public static func buildFileDescriptor(from ast: ProtoAST, fileName: String) throws
+    -> Google_Protobuf_FileDescriptorProto
+  {
     var fileProto = Google_Protobuf_FileDescriptorProto()
-    
+
     // Set file name
     fileProto.name = fileName
-    
+
     // Set syntax
     fileProto.syntax = ast.syntax.rawValue
-    
+
     // Set package
     if let package = ast.package {
       fileProto.package = package
     }
-    
+
     // Set imports
     fileProto.dependency.append(contentsOf: ast.imports)
-    
+
     // Convert messages
     for messageNode in ast.messages {
       let messageProto = try MessageDescriptorBuilder.build(from: messageNode, packageName: ast.package)
       fileProto.messageType.append(messageProto)
     }
-    
+
     // Convert enums
     for enumNode in ast.enums {
       let enumProto = try EnumDescriptorBuilder.build(from: enumNode)
       fileProto.enumType.append(enumProto)
     }
-    
+
     // Convert services
     for serviceNode in ast.services {
       let serviceProto = try ServiceDescriptorBuilder.build(from: serviceNode, packageName: ast.package)
       fileProto.service.append(serviceProto)
     }
-    
+
     // Convert file options
     if !ast.options.isEmpty {
       fileProto.options = try buildFileOptions(from: ast.options)
     }
-    
+
     return fileProto
   }
-  
+
   /// Build FileOptions from AST options.
   private static func buildFileOptions(from options: [OptionNode]) throws -> Google_Protobuf_FileOptions {
     var fileOptions = Google_Protobuf_FileOptions()
-    
+
     for option in options {
       switch option.name {
       case "java_package":
@@ -147,7 +149,7 @@ public struct DescriptorBuilder {
         namePart.namePart = option.name
         namePart.isExtension = option.isCustom
         uninterpretedOption.name = [namePart]
-        
+
         // Set value based on option value type
         switch option.value {
         case .string(let value):
@@ -159,11 +161,11 @@ public struct DescriptorBuilder {
         case .identifier(let value):
           uninterpretedOption.identifierValue = value
         }
-        
+
         fileOptions.uninterpretedOption.append(uninterpretedOption)
       }
     }
-    
+
     return fileOptions
   }
 }

Sources/SwiftProtoParser/DescriptorBuilder/DescriptorError.swift

@@ -4,22 +4,22 @@ import Foundation
 public enum DescriptorError: LocalizedError, Equatable {
   /// Unable to convert AST node to descriptor.
   case conversionFailed(reason: String)
-  
+
   /// Missing required field in AST node.
   case missingRequiredField(field: String, in: String)
-  
+
   /// Invalid field type for descriptor conversion.
   case invalidFieldType(type: String, context: String)
-  
+
   /// Duplicate element found during conversion.
   case duplicateElement(name: String, type: String)
-  
+
   /// Unsupported feature for descriptor conversion.
   case unsupportedFeature(feature: String, context: String)
-  
+
   /// Internal error during descriptor building.
   case internalError(message: String)
-  
+
   public var errorDescription: String? {
     switch self {
     case .conversionFailed(let reason):
@@ -45,27 +45,27 @@ extension DescriptorError {
   public static func conversionFailed(_ reason: String) -> DescriptorError {
     return .conversionFailed(reason: reason)
   }
-  
+
   /// Create a missing required field error.
   public static func missingField(_ field: String, in context: String) -> DescriptorError {
     return .missingRequiredField(field: field, in: context)
   }
-  
+
   /// Create an invalid field type error.
   public static func invalidType(_ type: String, in context: String) -> DescriptorError {
     return .invalidFieldType(type: type, context: context)
   }
-  
+
   /// Create a duplicate element error.
   public static func duplicate(_ name: String, type: String) -> DescriptorError {
     return .duplicateElement(name: name, type: type)
   }
-  
+
   /// Create an unsupported feature error.
   public static func unsupported(_ feature: String, in context: String) -> DescriptorError {
     return .unsupportedFeature(feature: feature, context: context)
   }
-  
+
   /// Create an internal error.
   public static func internalError(_ message: String) -> DescriptorError {
     return .internalError(message: message)

Sources/SwiftProtoParser/DescriptorBuilder/EnumDescriptorBuilder.swift

@@ -3,52 +3,52 @@ import SwiftProtobuf
 
 /// Builds SwiftProtobuf EnumDescriptorProto from AST EnumNode.
 struct EnumDescriptorBuilder {
-  
+
   /// Convert EnumNode to EnumDescriptorProto.
   static func build(from enumNode: EnumNode) throws -> Google_Protobuf_EnumDescriptorProto {
     var enumProto = Google_Protobuf_EnumDescriptorProto()
-    
+
     // Set enum name
     enumProto.name = enumNode.name
-    
+
     // Convert enum values
     for valueNode in enumNode.values {
       let valueProto = try buildEnumValue(from: valueNode)
       enumProto.value.append(valueProto)
     }
-    
+
     // Validate that enum has a zero value (required in proto3)
     if !enumNode.hasZeroValue {
       throw DescriptorError.conversionFailed("Enum '\(enumNode.name)' must have a zero value in proto3")
     }
-    
+
     // Convert enum options
     if !enumNode.options.isEmpty {
       enumProto.options = try buildEnumOptions(from: enumNode.options)
     }
-    
+
     return enumProto
   }
-  
+
   /// Build EnumValueDescriptorProto from EnumValueNode.
   private static func buildEnumValue(from valueNode: EnumValueNode) throws -> Google_Protobuf_EnumValueDescriptorProto {
     var valueProto = Google_Protobuf_EnumValueDescriptorProto()
-    
+
     valueProto.name = valueNode.name
     valueProto.number = valueNode.number
-    
+
     // Convert value options
     if !valueNode.options.isEmpty {
       valueProto.options = try buildEnumValueOptions(from: valueNode.options)
     }
-    
+
     return valueProto
   }
-  
+
   /// Build EnumOptions from AST options.
   private static func buildEnumOptions(from options: [OptionNode]) throws -> Google_Protobuf_EnumOptions {
     var enumOptions = Google_Protobuf_EnumOptions()
-    
+
     for option in options {
       switch option.name {
       case "allow_alias":
@@ -65,14 +65,14 @@ struct EnumDescriptorBuilder {
         break
       }
     }
-    
+
     return enumOptions
   }
-  
+
   /// Build EnumValueOptions from AST options.
   private static func buildEnumValueOptions(from options: [OptionNode]) throws -> Google_Protobuf_EnumValueOptions {
     var valueOptions = Google_Protobuf_EnumValueOptions()
-    
+
     for option in options {
       switch option.name {
       case "deprecated":
@@ -85,7 +85,7 @@ struct EnumDescriptorBuilder {
         break
       }
     }
-    
+
     return valueOptions
   }
 }

Sources/SwiftProtoParser/DescriptorBuilder/FieldDescriptorBuilder.swift

@@ -3,15 +3,17 @@ import SwiftProtobuf
 
 /// Builds SwiftProtobuf FieldDescriptorProto from AST FieldNode.
 struct FieldDescriptorBuilder {
-  
+
   /// Convert FieldNode to FieldDescriptorProto.
-  static func build(from fieldNode: FieldNode, index: Int32, packageName: String? = nil) throws -> Google_Protobuf_FieldDescriptorProto {
+  static func build(from fieldNode: FieldNode, index: Int32, packageName: String? = nil) throws
+    -> Google_Protobuf_FieldDescriptorProto
+  {
     var fieldProto = Google_Protobuf_FieldDescriptorProto()
-    
+
     // Set basic field properties
     fieldProto.name = fieldNode.name
     fieldProto.number = fieldNode.number
-    
+
     // Convert field label
     switch fieldNode.label {
     case .optional:
@@ -21,20 +23,24 @@ struct FieldDescriptorBuilder {
     case .repeated:
       fieldProto.label = .repeated
     }
-    
+
     // Convert field type
     try setFieldType(fieldProto: &fieldProto, fieldType: fieldNode.type, packageName: packageName)
-    
+
     // Convert field options
     if !fieldNode.options.isEmpty {
       fieldProto.options = try buildFieldOptions(from: fieldNode.options)
     }
-    
+
     return fieldProto
   }
-  
+
   /// Set field type in FieldDescriptorProto with proper type enum mapping.
-  private static func setFieldType(fieldProto: inout Google_Protobuf_FieldDescriptorProto, fieldType: FieldType, packageName: String?) throws {
+  private static func setFieldType(
+    fieldProto: inout Google_Protobuf_FieldDescriptorProto,
+    fieldType: FieldType,
+    packageName: String?
+  ) throws {
     switch fieldType {
     // Scalar types
     case .double:
@@ -67,22 +73,22 @@ struct FieldDescriptorBuilder {
       fieldProto.type = .string
     case .bytes:
       fieldProto.type = .bytes
-      
+
     // Complex types
     case .message(let typeName):
       fieldProto.type = .message
       fieldProto.typeName = buildFullyQualifiedTypeName(typeName, packageName: packageName)
-      
+
     case .enumType(let typeName):
       fieldProto.type = .enum
       fieldProto.typeName = buildFullyQualifiedTypeName(typeName, packageName: packageName)
-      
+
     case .qualifiedType(let qualifiedName):
       // For qualified types like google.protobuf.Timestamp, assume it's a message type
       fieldProto.type = .message
       // Qualified names are already fully qualified, just add leading dot if missing
       fieldProto.typeName = qualifiedName.hasPrefix(".") ? qualifiedName : ".\(qualifiedName)"
-      
+
     case .map(_, _):
       // Maps are represented as repeated message with special structure
       fieldProto.type = .message
@@ -91,26 +97,27 @@ struct FieldDescriptorBuilder {
       fieldProto.label = .repeated
     }
   }
-  
+
   /// Build fully qualified type name with package prefix.
   private static func buildFullyQualifiedTypeName(_ typeName: String, packageName: String?) -> String {
     // If already starts with dot, it's already fully qualified
     if typeName.hasPrefix(".") {
       return typeName
     }
-    
+
     // Build fully qualified name
     if let package = packageName, !package.isEmpty {
       return ".\(package).\(typeName)"
-    } else {
+    }
+    else {
       return ".\(typeName)"
     }
   }
-  
+
   /// Build FieldOptions from AST options.
   private static func buildFieldOptions(from options: [OptionNode]) throws -> Google_Protobuf_FieldOptions {
     var fieldOptions = Google_Protobuf_FieldOptions()
-    
+
     for option in options {
       switch option.name {
       case "deprecated":
@@ -162,7 +169,7 @@ struct FieldDescriptorBuilder {
         namePart.namePart = option.name
         namePart.isExtension = option.isCustom
         uninterpretedOption.name = [namePart]
-        
+
         // Set value based on option value type
         switch option.value {
         case .string(let value):
@@ -174,11 +181,11 @@ struct FieldDescriptorBuilder {
         case .identifier(let value):
           uninterpretedOption.identifierValue = value
         }
-        
+
         fieldOptions.uninterpretedOption.append(uninterpretedOption)
       }
     }
-    
+
     return fieldOptions
   }
 }