Skip to content

Commit 63deaed

Browse files
NSProgrammerNSProgrammer
authored
Update TIP to v2.12.2 (#45)
### 2.12.2 - Add automatic handling of unnecessary image download errors when the download has finished loading - It is not uncommon for a service/CDN to yield an error after the final byte of the response has been loaded by the client - The consequence of treating a successful load as a failure is that upon next fetch for that image an unnessecary network request will trigger: - For image resumption supported loads, resumes the load beyond the available byte range - For full image loads, a redundant download - When TIP sees an error on image download but has all the bytes (looking at `Content-Length` header), TIP now posts `TIPProblemImageDownloadedWithUnnecessaryError` problem Also, many misc bug fixes
1 parent 9d98639 commit 63deaed

File tree

51 files changed

+1576
-976
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

51 files changed

+1576
-976
lines changed

‎BuildConfiguration/TwitterImagePipeline.Debug.xcconfig

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
//
2+
// TwitterImagePipeline.Debug.xcconfig
3+
// TwitterImagePipeline
4+
//
5+
// Created on 5/25/19.
6+
// Copyright © 2019 Twitter. All rights reserved.
7+
//
8+
9+
// Configuration settings file format documentation can be found at:
10+
// https://help.apple.com/xcode/#/dev745c5c974
11+
12+
#include "TwitterImagePipeline.xcconfig"
13+
14+
// Architectures
15+
ONLY_ACTIVE_ARCH = YES
16+
17+
// Build Options
18+
DEBUG_INFORMATION_FORMAT = dwarf
19+
ENABLE_TESTABILITY = YES
20+
VALIDATE_PRODUCT = NO
21+
22+
// Apple LLVM 6.0 - Code Generation
23+
GCC_OPTIMIZATION_LEVEL = 0
24+
25+
// Apple LLVM 6.0 - Preprocessing
26+
ENABLE_NS_ASSERTIONS = YES
27+
GCC_PREPROCESSOR_DEFINITIONS = DEBUG=1
28+
29+
// Swift Compiler - Code Generation
30+
SWIFT_OPTIMIZATION_LEVEL = -Onone

‎BuildConfiguration/TwitterImagePipeline.Release.xcconfig

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
//
2+
// TwitterImagePipeline.Release.xcconfig
3+
// TwitterImagePipeline
4+
//
5+
// Created on 5/25/19.
6+
// Copyright © 2019 Twitter. All rights reserved.
7+
//
8+
9+
// Configuration settings file format documentation can be found at:
10+
// https://help.apple.com/xcode/#/dev745c5c974
11+
12+
#include "TwitterImagePipeline.xcconfig"
13+
14+
// Deployment
15+
COPY_PHASE_STRIP = YES
16+
17+
GCC_OPTIMIZATION_LEVEL = fast
18+

‎BuildConfiguration/TwitterImagePipeline.Test.app.xcconfig

Lines changed: 45 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,45 @@
1+
//
2+
// TwitterImagePipeline.Test.app.xcconfig
3+
// TwitterImagePipeline
4+
//
5+
// Created on 5/25/19.
6+
// Copyright © 2019 Twitter. All rights reserved.
7+
//
8+
9+
// Configuration settings file format documentation can be found at:
10+
// https://help.apple.com/xcode/#/dev745c5c974
11+
12+
#include "TwitterImagePipeline.Test.xcconfig"
13+
14+
// Architectures
15+
ONLY_ACTVE_ARCH = YES
16+
17+
// Deployment
18+
COPY_PHASE_STRIP = NO
19+
IPHONEOS_DEPLOYMENT_TARGET = 10.0 // 3 of the 4 sample apps use Foundation or UIKit API introduced in 10.0
20+
21+
// Asset Catalog Compiler - Options
22+
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon
23+
24+
// Apple Clang - Language
25+
GCC_C_LANGUAGE_STANDARD = gnu11
26+
27+
// Apple Clang - Language - C++
28+
CLANG_CXX_LANGUAGE_STANDARD = "gnu++14"
29+
30+
// Apple Clang - Warnings - All Languages
31+
CLANG_WARN_UNGUARDED_AVAILABILITY = YES_AGGRESSIVE
32+
33+
// Deployment
34+
SKIP_INSTALL = NO
35+
36+
// Linking
37+
LD_RUNPATH_SEARCH_PATHS = $(inherited) @executable_path/Frameworks
38+
39+
// Packaging
40+
INFOPLIST_FILE = $(TARGET_NAME)/Info.plist
41+
PRODUCT_BUNDLE_IDENTIFIER = com.twitter.${PRODUCT_NAME:rfc1034identifier}
42+
PRODUCT_NAME = $(TARGET_NAME)
43+
44+
// Search Paths
45+
FRAMEWORK_SEARCH_PATHS = $(inherited) $(PROJECT_DIR)/Extended

‎BuildConfiguration/TwitterImagePipeline.Test.ios.xcconfig

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
//
2+
// TwitterImagePipeline.Test.ios.xcconfig
3+
// TwitterImagePipeline
4+
//
5+
// Created on 5/25/19.
6+
// Copyright © 2019 Twitter. All rights reserved.
7+
//
8+
9+
// Configuration settings file format documentation can be found at:
10+
// https://help.apple.com/xcode/#/dev745c5c974
11+
12+
#include "TwitterImagePipeline.Test.xcconfig"
13+
14+
// Architectures
15+
SDKROOT = iphoneos
16+
17+
// Deployment
18+
IPHONEOS_DEPLOYMENT_TARGET = 8.0
19+
20+
// Search Paths
21+
22+
// 1. we keep WebP.framework in our local "Extended" subfolder
23+
// 2. while there is an XCTest.framework at the appropriate location relative to SDKROOT
24+
// as referened in the projet, the compiler can't find it without the second setting
25+
// when building the TIPTests.framework intermediate frameworks
26+
FRAMEWORK_SEARCH_PATHS = $(inherited) $(PROJECT_DIR)/Extended $(SDKROOT)/../../Library/Frameworks

‎BuildConfiguration/TwitterImagePipeline.Test.swift.xcconfig

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
//
2+
// TwitterImagePipeline.Test.swift.xcconfig
3+
// TwitterImagePipeline
4+
//
5+
// Created on 5/25/19.
6+
// Copyright © 2019 Twitter. All rights reserved.
7+
//
8+
9+
// Configuration settings file format documentation can be found at:
10+
// https://help.apple.com/xcode/#/dev745c5c974
11+
12+
#include "TwitterImagePipeline.Test.app.xcconfig"
13+
14+
// Deployment
15+
16+
// required for Swift compilation
17+
IPHONEOS_DEPLOYMENT_TARGET = 10.0
18+
19+
SWIFT_ACTIVE_COMPILATION_CONDITIONS = DEBUG
20+
SWIFT_OBJC_BRIDGING_HEADER = $(TARGET_NAME)/Sample-Bridging-Header.h;
21+
SWIFT_VERSION = 5.0;

‎BuildConfiguration/TwitterImagePipeline.Test.tvos.xcconfig

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
//
2+
// TwitterImagePipeline.Test.tvos.xcconfig
3+
// TwitterImagePipeline
4+
//
5+
// Created on 5/25/19.
6+
// Copyright © 2019 Twitter. All rights reserved.
7+
//
8+
9+
// Configuration settings file format documentation can be found at:
10+
// https://help.apple.com/xcode/#/dev745c5c974
11+
12+
#include "TwitterImagePipeline.Test.xcconfig"
13+
14+
// Architectures
15+
SDKROOT = appletvos
16+
17+
// Deployment
18+
TARGETED_DEVICE_FAMILY = 3
19+
TVOS_DEPLOYMENT_TARGET = 9.0
20+
21+
// Search Paths
22+
23+
// while there is an XCTest.framework at the appropriate location in
24+
// Developer/AppleTVOS.platform/Developer/Library/Frameworks, the compiler
25+
// can't find it without the following setting:
26+
FRAMEWORK_SEARCH_PATHS = $(inherited) $(SDKROOT)/../../Library/Frameworks

‎BuildConfiguration/TwitterImagePipeline.Test.xcconfig

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
//
2+
// TwitterImagePipeline.Test.xcconfig
3+
// TwitterImagePipeline
4+
//
5+
// Created on 5/25/19.
6+
// Copyright © 2019 Twitter. All rights reserved.
7+
//
8+
9+
// Configuration settings file format documentation can be found at:
10+
// https://help.apple.com/xcode/#/dev745c5c974
11+
12+
// Architectures
13+
ONLY_ACTIVE_ARCH = YES
14+
15+
// Build Options
16+
DEBUG_INFORMATION_FORMAT = dwarf
17+
18+
// Deployment
19+
COPY_PHASE_STRIP = NO
20+
SKIP_INSTALL = YES
21+
22+
// Linking
23+
LD_RUNPATH_SEARCH_PATHS = $(inherited) @executable_path/Frameworks @loader_path/Frameworks
24+
25+
// Packaging
26+
INFOPLIST_FILE = $(TARGET_NAME)/Info.plist
27+
PRODUCT_BUNDLE_IDENTIFIER = com.twitter.${PRODUCT_NAME:rfc1034identifier}
28+
PRODUCT_NAME = $(TARGET_NAME)
29+

‎BuildConfiguration/TwitterImagePipeline.framework.ios.xcconfig

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
//
2+
// TwitterImagePipeline.framework.ios.xcconfig
3+
// TwitterImagePipeline
4+
//
5+
// Created on 5/25/19.
6+
// Copyright © 2019 Twitter. All rights reserved.
7+
//
8+
9+
// Configuration settings file format documentation can be found at:
10+
// https://help.apple.com/xcode/#/dev745c5c974
11+
12+
#include "TwitterImagePipeline.framework.xcconfig"
13+
14+
// Architectures
15+
SDKROOT = iphoneos
16+
17+
// Deployment
18+
IPHONEOS_DEPLOYMENT_TARGET = 8.0

‎BuildConfiguration/TwitterImagePipeline.framework.tvos.xcconfig

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
//
2+
// TwitterImagePipeline.framework.tvos.xcconfig
3+
// TwitterImagePipeline
4+
//
5+
// Created on 5/25/19.
6+
// Copyright © 2019 Twitter. All rights reserved.
7+
//
8+
9+
// Configuration settings file format documentation can be found at:
10+
// https://help.apple.com/xcode/#/dev745c5c974
11+
12+
#include "TwitterImagePipeline.framework.xcconfig"
13+
14+
// Architectures
15+
SDKROOT = appletvos
16+
17+
// Deployment
18+
CODE_SIGN_IDENTITY =
19+
TARGETED_DEVICE_FAMILY = 3
20+
TVOS_DEPLOYMENT_TARGET = 9.0

‎BuildConfiguration/TwitterImagePipeline.framework.xcconfig

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
1+
//
2+
// TwitterImagePipeline.framework.xcconfig
3+
// TwitterImagePipeline
4+
//
5+
// Created on 5/25/19.
6+
// Copyright © 2019 Twitter. All rights reserved.
7+
//
8+
9+
// Configuration settings file format documentation can be found at:
10+
// https://help.apple.com/xcode/#/dev745c5c974
11+
12+
// Build Options
13+
APPLICATION_EXTENSION_API_ONLY = YES
14+
15+
// Deployment
16+
SKIP_INSTALL = YES
17+
18+
// Apple Clang - Preprocessing
19+
GCC_PREPROCESSOR_DEFINITIONS = $(inherited) TIP_PROJECT_VERSION=$(CURRENT_PROJECT_VERSION)
20+
21+
// Linking
22+
DYLIB_COMPATIBILITY_VERSION = 1
23+
DYLIB_CURRENT_VERSION = $(CURRENT_PROJECT_VERSION)
24+
DYLIB_INSTALL_NAME_BASE = @rpath
25+
LD_RUNPATH_SEARCH_PATHS = $(inherited) @executable_path/Frameworks @loader_path/Frameworks
26+
27+
// Packaging
28+
DEFINES_MODULE = YES
29+
INFOPLIST_FILE = $(PROJECT_NAME)/Info.plist
30+
PRODUCT_BUNDLE_IDENTIFIER = com.twitter.${PROJECT_NAME:rfc1034identifier}
31+
PRODUCT_NAME = $(PROJECT_NAME)

0 commit comments

Comments
 (0)