Skip to content

Commit 2d0e625

Browse files
committed
CTP-3558 coding standards more spaces
1 parent a1d4d57 commit 2d0e625

26 files changed

+60
-63
lines changed

classes/allocation/manager.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -191,8 +191,8 @@ public function auto_generate_moderation_set() {
191191
* @return array
192192
*/
193193
public function get_sampling_options() {
194-
return array('0' =>get_string('manual', 'mod_coursework'),
195-
'1' =>get_string('automatic', 'mod_coursework'));
194+
return array('0' => get_string('manual', 'mod_coursework'),
195+
'1' => get_string('automatic', 'mod_coursework'));
196196

197197
}
198198

@@ -344,7 +344,7 @@ public function auto_generate_sample_set() {
344344

345345
// save sample set
346346
if (!empty($auto_sample_set)) {
347-
foreach ($auto_sample_set as $allocatable) {
347+
foreach ($auto_sample_set as $allocatable) {
348348
$sample = new \stdClass();
349349
$sample->courseworkid = $this->coursework->id;
350350
$sample->allocatableid = $allocatable->id;

classes/allocation/upload.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ public function validate_csv($content, $encoding, $delimeter) {
147147
$s++;
148148
}
149149

150-
return (!empty($errors)) ? $errors : false;
150+
return (!empty($errors)) ? $errors : false;
151151
}
152152

153153
/**
@@ -262,7 +262,7 @@ public function process_csv($content, $encoding, $delimiter, $processingresults)
262262
$s++;
263263
}
264264

265-
return (!empty($errors)) ? $errors : false;
265+
return (!empty($errors)) ? $errors : false;
266266

267267
}
268268

classes/controllers/deadline_extensions_controller.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -293,7 +293,7 @@ public function ajax_edit_mitigation($data_params) {
293293
$ability->require_can('edit', $deadline_extension);
294294
$time_content = '';
295295
$time = '';
296-
if ($this->coursework->personaldeadlineenabled && $personal_deadline = $this->personal_deadline()) {
296+
if ($this->coursework->personaldeadlineenabled && $personal_deadline = $this->personal_deadline()) {
297297
$time_content = 'Personal deadline: ' . userdate($personal_deadline->personal_deadline);
298298
$time = date('d-m-Y H:i', $personal_deadline->personal_deadline);
299299
} else if ($this->coursework->deadline) {

classes/controllers/feedback_controller.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ protected function show_feedback() {
7070

7171
$urlparams = array('feedbackid' => $this->params['feedbackid']);
7272
$PAGE->set_url('/mod/coursework/actions/feedbacks/show.php', $urlparams);
73-
$ajax = (isset($this->params['ajax'])) ? $this->params['ajax'] : 0;
73+
$ajax = (isset($this->params['ajax'])) ? $this->params['ajax'] : 0;
7474

7575
$teacherfeedback = new feedback($this->params['feedbackid']);
7676

classes/controllers/personal_deadlines_controller.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ protected function new_personal_deadline() {
9090

9191
$allocatables = unserialize($data->allocatableid);
9292

93-
foreach ($allocatables as $allocatableid) {
93+
foreach ($allocatables as $allocatableid) {
9494
$data->allocatableid = $allocatableid;
9595
$data->id = '';
9696
//$data->id = '';
@@ -212,7 +212,7 @@ public function insert_update($time) {
212212
} else {
213213
$allocatables = unserialize($data->allocatableid);
214214

215-
foreach ($allocatables as $allocatableid) {
215+
foreach ($allocatables as $allocatableid) {
216216
$data->allocatableid = $allocatableid;
217217
$data->id = '';
218218
//$data->id = '';

classes/export/csv/cells/agreedgrade_cell.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ public function get_cell($submission, $student, $stage_identifier) {
4545
$gradedata = [];
4646
$this->get_rubric_scores_gradedata($agreedgrade, $gradedata); // multiple parts are handled here
4747
} else {
48-
$gradedata = (!$agreedgrade) ? '': $this->get_actual_grade($agreedgrade->grade);
48+
$gradedata = (!$agreedgrade) ? '' : $this->get_actual_grade($agreedgrade->grade);
4949
}
5050

5151
return $gradedata;

classes/export/csv/cells/assessorgrade_cell.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ public function get_cell($submission, $student, $stage_identifier) {
6060
$gradedata = [];
6161
$this->get_rubric_scores_gradedata($grade, $gradedata); // multiple parts are handled here
6262
} else {
63-
$gradedata = (!$grade) ? '': $this->get_actual_grade($grade->grade);
63+
$gradedata = (!$grade) ? '' : $this->get_actual_grade($grade->grade);
6464

6565
}
6666

classes/export/csv/cells/cell_base.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,7 @@ public function get_stage_identifier_for_assessor($submission, $student) {
227227
$stageidentifier = '';
228228
if ($this->coursework->allocation_enabled()) {
229229
$stageidentifier = $this->coursework->get_assessors_stage_identifier($student->id, $USER->id);
230-
} else if ($this->coursework->get_max_markers()>1) {
230+
} else if ($this->coursework->get_max_markers() > 1) {
231231
// get existing feedback
232232

233233
$sql = "SELECT * FROM {coursework_feedbacks}

classes/export/csv/cells/singlegrade_cell.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ public function get_cell($submission, $student, $stage_identifier) {
4747
$gradedata = [];
4848
$this->get_rubric_scores_gradedata($grade, $gradedata); // multiple parts are handled here
4949
} else {
50-
$gradedata = (!$grade) ? '': $this->get_actual_grade($grade->grade);
50+
$gradedata = (!$grade) ? '' : $this->get_actual_grade($grade->grade);
5151
}
5252

5353
return $gradedata;

classes/export/grading_sheet.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ public static function cells_array($coursework) {
159159

160160
// based on capabilities decide what view display - singlegrade or multiplegrade
161161
if ((has_capability('mod/coursework:addagreedgrade', $PAGE->context) || has_capability('mod/coursework:administergrades', $PAGE->context))
162-
&& $coursework->get_max_markers()>1 ) {
162+
&& $coursework->get_max_markers() > 1 ) {
163163
for ($i = 1; $i <= $coursework->get_max_markers(); $i++) {
164164
// extra column with allocated assessor name
165165
if ($coursework->allocation_enabled() && $coursework->get_max_markers() > 1
@@ -173,7 +173,7 @@ public static function cells_array($coursework) {
173173
$csv_cells[] = 'agreedgrade';
174174
$csv_cells[] = 'agreedfeedback';
175175

176-
} else if (has_capability('mod/coursework:addallocatedagreedgrade', $PAGE->context) && $coursework->get_max_markers() >1) {
176+
} else if (has_capability('mod/coursework:addallocatedagreedgrade', $PAGE->context) && $coursework->get_max_markers() > 1) {
177177
$csv_cells[] = 'singlegrade';
178178
$csv_cells[] = 'feedbackcomments';
179179

0 commit comments

Comments
 (0)