CTP-3558 coding std insert spaces in comments

Author: watson8

actions/allocate.php

@@ -196,7 +196,7 @@
 // Add coursework id etc.
 echo \html_writer::input_hidden_params($PAGE->url);
 
-if ($coursework->sampling_enabled()) { //  Do not delete yet - refactoring...
+if ($coursework->sampling_enabled()) { // Do not delete yet - refactoring...
     echo \html_writer::start_tag('form', array('id' => 'sampling_form',
         'method' => 'post'));
     $samplesetwidget = $allocationsmanager->get_sampling_set_widget();

actions/processallocation.php

@@ -20,10 +20,10 @@
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 
-//this stops the page from aborting when an ajax call disconnects
+// This stops the page from aborting when an ajax call disconnects
 ignore_user_abort(true);
 
-//we have to set the time limit to 0 as depending on
+// We have to set the time limit to 0 as depending on
 set_time_limit ( 0 );
 
 use mod_coursework\models\coursework;

actions/upload_allocations.php

@@ -60,15 +60,15 @@
 
 if ($data = $allocationsuploadform->get_data()) {
 
-    //perform checks on data
+    // Perform checks on data
 
     $content = $allocationsuploadform->get_file_content('allocationsdata');
 
     $csvimport = new \mod_coursework\allocation\upload($coursework);
 
     $procsessingresults = $csvimport->validate_csv($content, $data->encoding, $data->delimiter_name);
 
-    //process
+    // Process
     $csvimport->process_csv($content, $data->encoding, $data->delimiter_name, $procsessingresults);
     $page_renderer = $PAGE->get_renderer('mod_coursework', 'page');
     echo $page_renderer->process_csv_upload($procsessingresults, $content, $csvtype);

actions/upload_feedback.php

@@ -60,7 +60,7 @@
 
 if ($data = $feedbackform->get_data()) {
 
-    //perform checks on data
+    // Perform checks on data
     $courseworktempdir = $CFG->dataroot."/temp/coursework/";
 
     if (!is_dir($courseworktempdir)) {

actions/upload_grading_sheet.php

@@ -61,7 +61,7 @@
 
 if ($data = $gradinguploadform->get_data()) {
 
-    //perform checks on data
+    // Perform checks on data
 
     $content = $gradinguploadform->get_file_content('gradingdata');
 
@@ -73,9 +73,9 @@
 
     $procsessingresults = $csvimport->validate_csv($content, $data->encoding, $data->delimiter_name, $csv_cells);
 
-    //process
+    // Process
 
-    //if (!empty($procsessingresults)) {
+    // If (!empty($procsessingresults)) {
     $csvimport->process_csv($content, $data->encoding, $data->delimiter_name, $csv_cells, $procsessingresults);
     $page_renderer = $PAGE->get_renderer('mod_coursework', 'page');
     echo $page_renderer->process_csv_upload($procsessingresults, $content, $csvtype);

backup/moodle2/backup_coursework_activity_task.class.php

@@ -29,7 +29,7 @@ static public function encode_content_links($content) {
 
       $base = preg_quote($CFG->wwwroot, "/");
 
-      //These have to be picked up by the restore code COURSEWORK... are arbitrary
+      // These have to be picked up by the restore code COURSEWORK... are arbitrary
       $search = "/(".$base."\/mod\/coursework\/index.php\?id\=)([0-9]+)/";
       $content = preg_replace($search, '$@COURSEWORKINDEX*$2@$', $content);
 

backup/moodle2/backup_coursework_stepslib.php

@@ -307,31 +307,31 @@ protected function define_structure() {
                                                         "selectiontype"
                                                 ));
 
-            //A coursework instance has submissions.
+            // A coursework instance has submissions.
             $coursework->add_child($submissions);
-            //Each coursework may have reminders
+            // Each coursework may have reminders
             $coursework->add_child($reminders);
-            //And allocations pairs
+            // And allocations pairs
             $coursework->add_child($pairs);
-            //And moderation sets
+            // And moderation sets
             $coursework->add_child($modsetrules);
-            //And a set of extensionsenabled
+            // And a set of extensionsenabled
             $coursework->add_child($extensions);
-            //And a set of personaldeadlines
+            // And a set of personaldeadlines
             $coursework->add_child($personal_deadlines);
-            //And a set of moderation rule sets
+            // And a set of moderation rule sets
             $coursework->add_child($modsetmembers);
-            //And allocation configs
+            // And allocation configs
             $coursework->add_child($allocation_configs);
-            //And sample members
+            // And sample members
             $coursework->add_child($sample_members);
 
-            //And submissions are made up from individual submission instances
+            // And submissions are made up from individual submission instances
             $submissions->add_child($submission);
-            //Submissions have multiple feedback items
+            // Submissions have multiple feedback items
             $submission->add_child($feedbacks);
 
-            //Feedbacks is a set of individual items
+            // Feedbacks is a set of individual items
             $feedbacks->add_child($feedback);
 
             $feedback->add_child($moderation_agreements);
@@ -340,7 +340,7 @@ protected function define_structure() {
             $submission->add_child($plagiarism_flags);
             $plagiarism_flags->add_child($plagiarism_flag);
 
-            //as are reminders, pairs, extensions, modsets and modsetrules,
+            // as are reminders, pairs, extensions, modsets and modsetrules,
             // and allocation configs
             $reminders->add_child($reminder);
             $pairs->add_child($pair);
@@ -387,7 +387,7 @@ protected function define_structure() {
             $allocation_config->set_source_table('coursework_allocation_config',
                                                  array('courseworkid' => backup::VAR_PARENTID));
 
-            //Mark important foreign keys
+            // Mark important foreign keys
             $feedback->annotate_ids('user', 'assessorid');
             $feedback->annotate_ids('user', 'lasteditedbyuser');
             $feedback->annotate_ids('user', 'markernumber');

backup/moodle2/restore_coursework_stepslib.php

@@ -50,9 +50,9 @@ protected function define_structure() {
         if ($userinfo) {
             // Define each element separated.
             // Note: when I started the code I didn't realise that the names were arbitrary
-            //       and that the coursework_ prefix is not needed.
-            //   It would be nice to go back and take these out here and in backup.
-            //       But not essential
+            // and that the coursework_ prefix is not needed.
+            // It would be nice to go back and take these out here and in backup.
+            // But not essential
             $bits = array('submission' => 'coursework_submissions',
                         'feedback' => 'coursework_submissions/coursework_submission/coursework_feedbacks',
                         'reminder' => 'coursework_reminders',
@@ -120,7 +120,7 @@ protected function process_coursework_submission($data) {
             $newitemid = $DB->insert_record('coursework_submissions', $data);
             $this->set_mapping('coursework_submission', $oldid, $newitemid);
 
-            //Tell system how to map the old submission id to its new one.
+            // Tell system how to map the old submission id to its new one.
             $this->set_mapping('coursework_submission', $oldid, $newitemid, false, null, $this->task->get_old_contextid());
         }
 
@@ -389,7 +389,7 @@ protected function process_coursework($data) {
                                 'deadline'), $data);
 
         $now = time();
-        //Taken from install.xml
+        // Taken from install.xml
         $this->set_defaults(array('formid' => 0,
                                   'course' => 0,
                                   'name' => '',
@@ -493,7 +493,7 @@ protected function after_execute() {
         $this->add_related_files('mod_coursework', 'submission', 'coursework_submission');
         $this->add_related_files('mod_coursework', 'feedback', 'coursework_feedback');
 
-        //Fixup names
+        // Fixup names
         $fs = get_file_storage();
         $ctx = context::instance_by_id($this->task->get_contextid());
 

classes/ability.php

@@ -145,7 +145,7 @@ function (coursework $coursework) {
         $this->allow_edit_moderation_if_user_is_allocated_to_moderate();
         $this->allow_edit_moderation_if_user_can_administer_grades();
 
-        //show moderation
+        // Show moderation
         $this->allow_show_moderation_if_user_can_view_grades_at_all_times();
 
         // Feedback rules

classes/allocation/manager.php

@@ -51,12 +51,12 @@ class manager {
     /**
      * @var strategy\base
      */
-    private  $assessorallocationstrategy;
+    private $assessorallocationstrategy;
 
     /**
      * @var strategy\base
      */
-    private  $moderatorallocationstrategy;
+    private $moderatorallocationstrategy;
 
     /**
      * New instance created with references to the coursework stored.
@@ -295,7 +295,7 @@ public function auto_generate_sample_set() {
 
         $final_agreed_allocatables = $this->get_allocatables_with_final_agreed();
 
-        //remove any allocatables that have a status of final agreed as these can not be sampled
+        // Remove any allocatables that have a status of final agreed as these can not be sampled
         foreach ($final_agreed_allocatables as $faa) {
             if (isset($allocatables[$faa->allocatableid]))  unset($allocatables[$faa->allocatableid]);
         }
@@ -323,9 +323,9 @@ public function auto_generate_sample_set() {
 
                 $auto_with_feedback = $this->get_automatic_with_feedback($stage);
 
-                //ok this array merge is being carried out using an foreach rather than array_merge as we want to preserve keys
-                //I am also not using add the two arrays as using the overloaded + can produce dubious results when a key exists
-                //in both arrays
+                // Ok this array merge is being carried out using an foreach rather than array_merge as we want to preserve keys
+                // I am also not using add the two arrays as using the overloaded + can produce dubious results when a key exists
+                // In both arrays
 
                 foreach ($auto_with_feedback as $k => $v) {
                     if (!isset($manual_sample_set[$k])) $manual_sample_set[$k] = $v;
@@ -342,7 +342,7 @@ public function auto_generate_sample_set() {
 
                 }
 
-                //save sample set
+                // Save sample set
                 if (!empty($auto_sample_set)) {
                         foreach ($auto_sample_set    as  $allocatable) {
                             $sample = new \stdClass();
@@ -352,7 +352,7 @@ public function auto_generate_sample_set() {
                             $sample->stage_identifier = "assessor_{$stage_number}";
                             $sample->selectiontype = "automatic";
 
-                            //if this a manually selected allocatable check to see if the allocatable is already in the table
+                            // If this a manually selected allocatable check to see if the allocatable is already in the table
                             $DB->insert_record("coursework_sample_set_mbrs", $sample);
 
                         }
@@ -377,7 +377,7 @@ public function get_include_in_sample_set($stage_number) {
                      AND        stage_identifier = :stage_identifier
                      AND        selectiontype = 'manual'";
 
-        //get all users in manually selected for stage in coursework
+        // Get all users in manually selected for stage in coursework
         return $DB->get_records_sql($sql,
             array('courseworkid' => $this->coursework->id, 'stage_identifier' => $stage));