Skip to content

Commit 4b8daaa

Browse files
authored
Merge pull request #49 from uicrooks/dev
v2.4.13
2 parents 980085b + 1c937d3 commit 4b8daaa

File tree

3 files changed

+162
-121
lines changed

3 files changed

+162
-121
lines changed

README.md

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@ Shopify Theme Lab is a customizable modular development environment for blazing-
6363
- [Shopify & environment initialization](#shopify--environment-initialization)
6464
- [Shopify + webpack](#shopify--webpack)
6565
- [Shopify remote auto-reloading](#shopify-remote-auto-reloading)
66+
- [Common pitfalls](#common-pitfalls)
6667
- [Limitations](#limitations)
6768
- [Contributing](#contributing)
6869
<!-- toc (end) -->
@@ -77,6 +78,7 @@ Shopify Theme Lab is a customizable modular development environment for blazing-
7778
| - | - | - |
7879
| [Shopify Theme Lab](https://github.com/uicrooks/shopify-theme-lab) | <img src="https://img.shields.io/github/package-json/v/uicrooks/shopify-theme-lab?color=%236e78ff"> | Modular development environment for blazing-fast Shopify theming |
7980
| [Shopify Theme Lab CLI](https://github.com/uicrooks/shopify-theme-lab-cli) | <img src="https://img.shields.io/github/package-json/v/uicrooks/shopify-theme-lab-cli?color=%236e78ff"> | Command Line Interface for Shopify Theme Lab |
81+
| [Shopify Settings Control](https://github.com/uicrooks/shopify-settings-control) | <img src="https://img.shields.io/github/package-json/v/uicrooks/shopify-settings-control?color=%236e78ff"> | Automatic Git version control for Shopify `settings_data.json` |
8082
| [Shopify Foundation Theme](https://github.com/uicrooks/shopify-foundation-theme) | <img src="https://img.shields.io/github/package-json/v/uicrooks/shopify-foundation-theme?color=%236e78ff"> | A modern Shopify starter theme built with Vue and Tailwind CSS
8183
<!-- ecosystem (end) -->
8284

@@ -626,13 +628,19 @@ By running `shopify:init` and entering credentials, the task initializes a new t
626628
While `npm run start` task is running: The `shopify/` directory is being watched for changes and all changed files are uploaded to the Shopify remote server. After the upload is finished, a request is sent to a `localhost:port` address (specified in `package.json`) and the [shopify-reloadr](https://github.com/uicrooks/shopify-reloadr) package reloads all connected Shopify store sites. *Open the web console to check if a site is connected.*
627629
<!-- development environment concepts (end) -->
628630

631+
<!-- common pitfalls (start) -->
632+
## Common pitfalls
633+
634+
- `<style></style>` and `<script></script>` will be removed on mount inside Vue components (basically everything inside `<div id="app">...</div>`), use `<component is="style"><componet>` and `<component is="script"></componet>` instead
635+
- If you want to pass an entire Shopify Drop (Object) as a prop, you have to first convert the Drop to `json` and replace all double quotes with single quotes: `<component :shopify-data="{{ product | json | replace: '"', "'" }}"></component>`. Not all Drops can be converted to `json`, if you get an `{"error":"json not allowed for this object"}` it's a Shopify limitation and you have to pass the values in question individually
636+
<!-- common pitfalls (end) -->
637+
629638
<!-- limitations (start) -->
630639
## Limitations
631640

632641
- When the development task is running, the browser console throws a `bundle.css` missing error
633642
- Already running Shopify tasks only upload files which are changed, a simple re-save of a file, without editing it, won't upload the file to the remote store
634643
- Vue components inside `.liquid` files can only be used in a non-self-closing `<kebab-case></kebap-case>` manner
635-
- `<style></style>` and `<script></script>` will be removed on mount inside Vue components (basically everything inside `<div id="app">...</div>`), use `<component is="style"><componet>` and `<component is="script"></componet>` instead
636644
<!-- limitations (end) -->
637645

638646
<!-- contributing (start) -->

0 commit comments

Comments
 (0)